diff mbox series

[v2] cmd: gpt: remove redundant print messages

Message ID 1617214549-26153-1-git-send-email-rahasij@linux.microsoft.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series [v2] cmd: gpt: remove redundant print messages | expand

Commit Message

Ravik Hasija March 31, 2021, 6:15 p.m. UTC 
Removing printfs from do_gpt API as the messages are generic and does not
specify error codes for failure cases.

Signed-off-by: Ravik Hasija <rahasij@linux.microsoft.com>
Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
---
Changes for v2:
  - Updated usage message for gpt read
  - Added removed printfs for write & verify
  - Rearranged verify printf
---
 cmd/gpt.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Tom Rini April 19, 2021, 3:10 p.m. UTC | #1 
On Wed, Mar 31, 2021 at 11:15:49AM -0700, Ravik Hasija wrote:

> Removing printfs from do_gpt API as the messages are generic and does not
> specify error codes for failure cases.
> 
> Signed-off-by: Ravik Hasija <rahasij@linux.microsoft.com>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> Changes for v2:
>   - Updated usage message for gpt read
>   - Added removed printfs for write & verify
>   - Rearranged verify printf

This change in output breaks test_gpt_verify (see
test/py/tests/test_gpt.py) so that needs to be updated at the same time,
thanks.
diff mbox series

Patch

diff --git a/cmd/gpt.c b/cmd/gpt.c
index 76a95ade6c..ba0fa4c69c 100644
--- a/cmd/gpt.c
+++ b/cmd/gpt.c
@@ -971,9 +971,11 @@  static int do_gpt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 	if ((strcmp(argv[1], "write") == 0) && (argc == 5)) {
 		printf("Writing GPT: ");
 		ret = gpt_default(blk_dev_desc, argv[4]);
+		ret ? printf("error!\n") : printf("success!\n");
 	} else if ((strcmp(argv[1], "verify") == 0)) {
-		ret = gpt_verify(blk_dev_desc, argv[4]);
 		printf("Verify GPT: ");
+		ret = gpt_verify(blk_dev_desc, argv[4]);
+		ret ? printf("error!\n") : printf("success!\n");
 	} else if ((strcmp(argv[1], "setenv") == 0)) {
 		ret = gpt_setenv(blk_dev_desc, argv[4]);
 	} else if ((strcmp(argv[1], "enumerate") == 0)) {
@@ -992,11 +994,9 @@  static int do_gpt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 	}
 
 	if (ret) {
-		printf("error!\n");
 		return CMD_RET_FAILURE;
 	}
 
-	printf("success!\n");
 	return CMD_RET_SUCCESS;
 }
 
@@ -1017,7 +1017,7 @@  U_BOOT_CMD(gpt, CONFIG_SYS_MAXARGS, 1, do_gpt,
 	"      gpt_partition_name, gpt_partition_entry\n"
 	" gpt enumerate mmc 0\n"
 	"    - store list of partitions to gpt_partition_list environment variable\n"
-	" read <interface> <dev>\n"
+	" gpt read <interface> <dev>\n"
 	"    - read GPT into a data structure for manipulation\n"
 	" gpt guid <interface> <dev>\n"
 	"    - print disk GUID\n"