diff mbox series

[v2] configs: mt8512: enable device mode of mtu3 explicitly

Message ID 1602680044-19794-1-git-send-email-chunfeng.yun@mediatek.com
State New
Delegated to: Marek Vasut
Headers show
Series [v2] configs: mt8512: enable device mode of mtu3 explicitly | expand

Commit Message

Chunfeng Yun Oct. 14, 2020, 12:54 p.m. UTC
Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly,
try to avoid build error:
"undefined reference to `dm_usb_gadget_handle_interrupts'"

Fixes: 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2: change fixes info suggested by Bin
---
 configs/mt8512_bm1_emmc_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Marek Vasut Oct. 14, 2020, 1:01 p.m. UTC | #1
On 10/14/20 2:54 PM, Chunfeng Yun wrote:
> Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly,
> try to avoid build error:
> "undefined reference to `dm_usb_gadget_handle_interrupts'"
> 
> Fixes: 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")

Should I just squash this into ^ that commit in usb/next ?
Chunfeng Yun Oct. 14, 2020, 1:03 p.m. UTC | #2
On Wed, 2020-10-14 at 15:01 +0200, Marek Vasut wrote:
> On 10/14/20 2:54 PM, Chunfeng Yun wrote:
> > Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly,
> > try to avoid build error:
> > "undefined reference to `dm_usb_gadget_handle_interrupts'"
> > 
> > Fixes: 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")
> 
> Should I just squash this into ^ that commit in usb/next ?
Fine to me if it can fix the build error, thanks
Marek Vasut Oct. 14, 2020, 1:31 p.m. UTC | #3
On 10/14/20 3:03 PM, Chunfeng Yun wrote:
> On Wed, 2020-10-14 at 15:01 +0200, Marek Vasut wrote:
>> On 10/14/20 2:54 PM, Chunfeng Yun wrote:
>>> Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly,
>>> try to avoid build error:
>>> "undefined reference to `dm_usb_gadget_handle_interrupts'"
>>>
>>> Fixes: 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")
>>
>> Should I just squash this into ^ that commit in usb/next ?
> Fine to me if it can fix the build error, thanks

So, can you please test it and then send me all the patches you want me
to apply and possibly add a note in them if they should be squashed
somewhere ?

Thanks
Chunfeng Yun Oct. 15, 2020, 12:11 a.m. UTC | #4
On Wed, 2020-10-14 at 15:31 +0200, Marek Vasut wrote:
> On 10/14/20 3:03 PM, Chunfeng Yun wrote:
> > On Wed, 2020-10-14 at 15:01 +0200, Marek Vasut wrote:
> >> On 10/14/20 2:54 PM, Chunfeng Yun wrote:
> >>> Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly,
> >>> try to avoid build error:
> >>> "undefined reference to `dm_usb_gadget_handle_interrupts'"
> >>>
> >>> Fixes: 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")
> >>
> >> Should I just squash this into ^ that commit in usb/next ?
> > Fine to me if it can fix the build error, thanks
> 
> So, can you please test it and then send me all the patches you want me
> to apply and possibly add a note in them if they should be squashed
> somewhere ?
Ok, I'll test and send them again, please apply them directly, that may
be easier

Thanks a lot

> 
> Thanks
Chunfeng Yun Oct. 15, 2020, 1:52 a.m. UTC | #5
On Wed, 2020-10-14 at 15:31 +0200, Marek Vasut wrote:
> On 10/14/20 3:03 PM, Chunfeng Yun wrote:
> > On Wed, 2020-10-14 at 15:01 +0200, Marek Vasut wrote:
> >> On 10/14/20 2:54 PM, Chunfeng Yun wrote:
> >>> Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly,
> >>> try to avoid build error:
> >>> "undefined reference to `dm_usb_gadget_handle_interrupts'"
> >>>
> >>> Fixes: 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")
> >>
> >> Should I just squash this into ^ that commit in usb/next ?
> > Fine to me if it can fix the build error, thanks
> 
> So, can you please test it and then send me all the patches you want me
> to apply and possibly add a note in them if they should be squashed
> somewhere ?
As I explained in another email, just apply the following patch into
u-boot-usb/next will fix build error:
https://patchwork.ozlabs.org/project/uboot/patch/1602681717-20850-1-git-send-email-chunfeng.yun@mediatek.com/
[RESEND,v9] usb: add MediaTek USB3 DRD driver

Thank you

> 
> Thanks
Marek Vasut Oct. 15, 2020, 12:28 p.m. UTC | #6
On 10/15/20 3:52 AM, Chunfeng Yun wrote:
> On Wed, 2020-10-14 at 15:31 +0200, Marek Vasut wrote:
>> On 10/14/20 3:03 PM, Chunfeng Yun wrote:
>>> On Wed, 2020-10-14 at 15:01 +0200, Marek Vasut wrote:
>>>> On 10/14/20 2:54 PM, Chunfeng Yun wrote:
>>>>> Set CONFIG_USB_MTU3_GADGET=y to enable device mode explicitly,
>>>>> try to avoid build error:
>>>>> "undefined reference to `dm_usb_gadget_handle_interrupts'"
>>>>>
>>>>> Fixes: 764751784727 ("configs: mt8512: enable fastboot and USB host related configs")
>>>>
>>>> Should I just squash this into ^ that commit in usb/next ?
>>> Fine to me if it can fix the build error, thanks
>>
>> So, can you please test it and then send me all the patches you want me
>> to apply and possibly add a note in them if they should be squashed
>> somewhere ?
> As I explained in another email, just apply the following patch into
> u-boot-usb/next will fix build error:
> https://patchwork.ozlabs.org/project/uboot/patch/1602681717-20850-1-git-send-email-chunfeng.yun@mediatek.com/
> [RESEND,v9] usb: add MediaTek USB3 DRD driver

OK, so to make it easy, just rebase whatever you have left on usb/next
and resend it.
diff mbox series

Patch

diff --git a/configs/mt8512_bm1_emmc_defconfig b/configs/mt8512_bm1_emmc_defconfig
index aaf59f52a8..c25a42cd3d 100644
--- a/configs/mt8512_bm1_emmc_defconfig
+++ b/configs/mt8512_bm1_emmc_defconfig
@@ -53,6 +53,7 @@  CONFIG_DM_USB=y
 CONFIG_DM_USB_GADGET=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_MTU3=y
+CONFIG_USB_MTU3_GADGET=y
 # CONFIG_USB_MTU3_HOST is not set
 CONFIG_USB_STORAGE=y
 CONFIG_USB_GADGET=y