From patchwork Mon Sep 28 10:56:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wasim Khan X-Patchwork-Id: 1372547 X-Patchwork-Delegate: priyanka.jain@nxp.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=JUjg/l/s; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C0KJK0v5xz9sPB for ; Mon, 28 Sep 2020 20:58:41 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9B98B823DE; Mon, 28 Sep 2020 12:57:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="JUjg/l/s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 89D45823AF; Mon, 28 Sep 2020 12:56:54 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0631.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::631]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9D09582396 for ; Mon, 28 Sep 2020 12:56:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=wasim.khan@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kwHVF0zwUwLFpV7mA6rui9Gp1ptZ/GoQ4AECDvtsjqAFqrfiPpo2JZ9SNmK6hgmhfT/1xETe6BQcegcuVT4BBPyN+vy2zzQdgtl3yJAeb6TkAlU22R5Eiqdc0REjieyObr7NJBZSqdkNjtbMoZd4c1u+8PvbimeGUqVniWRNgsFA9IrkerHvQe7ovVhKavgL+NdjF6mK1QR+K8dBCTcV1A0rEtO6x3f+xbmHQ4BE69C5m3pthIqPDNtQmfYOnsgwOHPpGsp/rc0vg0/Y2BEBPFNcyeZBQO1w1JV3rauznxKuSkIm2PibQfdLFMVETSJpLppZVrtt72r4VJNRqB6hUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BF73Fi7fOTJUs0cuxKg2d6+0QxoqHLDxOvE8RlNI8V0=; b=jlz+EDXuulGjapalZWF1vTWAnuAfanrhYm11EzVN4miR+iP8InzF/F7kR1vykPBBl2Idf7KL7T9UszemxlDMLEUsVpaFmltFGt26UmV38sXQ8zkbkbiOtcD1XMYAHs8dc0/XZhLHRXaowPI+SBOGt3L6Yfy1N5Z1qbr9O6PnXpPnia8Sc3kHEk6VWv8i7WqBsc0E23DVH25++Ks30LS000XXdDaVRYl6gsZtpK3aKTEeCKryygJCu5Alb3vUOkVWf4X0aMjEcB2iQGpeqZ4BqvLUz0v0z5qfyZzfeunfqPJxjJrXPBFVIeqMaFovLy/wlQ4QiN1OMwo9qyPGJPG5fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BF73Fi7fOTJUs0cuxKg2d6+0QxoqHLDxOvE8RlNI8V0=; b=JUjg/l/smpauIymzQlDsekdB+XhoL4278kqP/Isow+dUfJwtRXJJd3fyFTJeaBIONCEMCnxtnsK/6Fi53G1sAJtZzGT6qrkZA3Gkm1WDFp1n1xkbn6tqEe6hbBCmxNPZ4lY3JfERblsQ33+XMY1JnzvF5UIsw5xA0pnTXnLq0Kk= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VE1PR04MB6702.eurprd04.prod.outlook.com (2603:10a6:803:123::13) by VI1PR04MB3198.eurprd04.prod.outlook.com (2603:10a6:802:9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.25; Mon, 28 Sep 2020 10:56:50 +0000 Received: from VE1PR04MB6702.eurprd04.prod.outlook.com ([fe80::14a9:162d:295b:dc3e]) by VE1PR04MB6702.eurprd04.prod.outlook.com ([fe80::14a9:162d:295b:dc3e%4]) with mapi id 15.20.3412.029; Mon, 28 Sep 2020 10:56:50 +0000 From: Wasim Khan To: u-boot@lists.denx.de, zhiqiang.hou@nxp.com, priyanka.jain@oss.nxp.com, V.Sethi@nxp.com Cc: Wasim Khan , Hou Zhiqiang Subject: [PATCH v2 11/12] pci: layerscape: Add size check for config resource Date: Mon, 28 Sep 2020 16:26:13 +0530 Message-Id: <1601290574-20151-12-git-send-email-wasim.khan@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1601290574-20151-1-git-send-email-wasim.khan@nxp.com> References: <1601290574-20151-1-git-send-email-wasim.khan@nxp.com> X-ClientProxiedBy: SG2PR01CA0102.apcprd01.prod.exchangelabs.com (2603:1096:3:15::28) To VE1PR04MB6702.eurprd04.prod.outlook.com (2603:10a6:803:123::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from lsv03032.swis.in-blr01.nxp.com (14.142.151.118) by SG2PR01CA0102.apcprd01.prod.exchangelabs.com (2603:1096:3:15::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3412.20 via Frontend Transport; Mon, 28 Sep 2020 10:56:48 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [14.142.151.118] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0b56cf47-22fe-48f1-5459-08d8639d33f3 X-MS-TrafficTypeDiagnostic: VI1PR04MB3198: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:439; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QR8wxEDUhO+gv4TwLkD1F+Tg+DqNEIoRY7ETRUC9dlPy94fMo1M/Jh7EfvJAA8x407iva+MThPGGoMvaf+RhectjHRcllIYiRVjL/by7mLQdfd971HvKQM7jQVhmIyNFLyqHsCwlsy0DmjO/06qUIkWRIINVe1j4qfmzjjTruUhdYQIgN0uyX5niVZ8WvN2RrCUWfVJyzdil0aLSatvivVYiJBmLO+bPijEWQzyhN7XVFGF6eZilBbC41pbcTOyqIDddjjFV6SalzZmi/ICMX23n306BEfKUtjoxhumnGo6u6GCvVNOZ1Pkpzgm2tFqfeUO8nzgDReBPk5t0yiGgNOl3PV+5Pdkx36BS6px5k+XTjYGWApxGJlXKCb6rmrQOZXnGcWZjHyWAyXkkSVkHd557yMXHs0gyHX7JbZM/O6I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6702.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(39860400002)(136003)(366004)(376002)(55236004)(6636002)(5660300002)(66476007)(66556008)(86362001)(956004)(2616005)(66946007)(8936002)(8676002)(36756003)(478600001)(44832011)(16526019)(26005)(54906003)(186003)(2906002)(7696005)(52116002)(83380400001)(1006002)(6666004)(316002)(4326008)(6486002)(110426005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: XdnYCXqK4tKXzegTxaWyJxZEQHjRnUdPdjso0fS3lFX2Jzya0D/YRqFVfA/MEgGzMmSICNtilLV+zm3oyDM/Hb3mpFkXTs2JKfp4vzFnA4uaOmYEamRNSbD3dVMrazUO2tAQv0H62Lq+rOiUj2G0tAeGLjxK/q7mOBrvN0DcAxV0N3TQTDPqv7+ifOK/BCwAxVkc+dbmNv9+8hx9SjYtev5K0CY3epkY8tD4MPL7T5BNnjEfrQOByfhSlqIbsZwSfQwzg59IBJpN+BScoKdkCuoAtSwowzojRuERR+mnqRVAEgJwpuVRnHXpU3meZfZKIbAseR+tXOJJOqU9Moandgsf1vAUxDwGRk3a3zFElkLfnATDWTf86Gue6fkgAweBui5O4ZUBRmLpvv6kpVnFMzcqZEMDio5wxbdEUZ7gC+Kdcc1L03VCAz4uSWHsb4ty/E84D8D97gn3KKkttVM2H+fKoSwMJaxqzFum0ixy/3SsHoJlghA2ub1c13rn4eKNfg7gos6AgN6r8CAcBzieXJe0+M3ASNZCkM+LRolQxHIpv6NwM1H5GNyFbjAZqiNfLvXeE0i0V8OrKW4amlcTNgsE9MzY16GwoP+3GyunZKLNi2zZ/orwEmEQlGmGq1HPUTJuAiC+WYA9yqtz8os7nA== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b56cf47-22fe-48f1-5459-08d8639d33f3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6702.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2020 10:56:50.7434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G8tIJoKYQfIVyjPlMYlQuNt3Rp1AqtWu2Dt+13zChLUft3oCGvRaQxTJrrnJurUO0zV+1ZjjTX8TjcGH4gbq8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3198 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean resource "config" is required to have minimum 8KB space as per hardware documentation. Signed-off-by: Hou Zhiqiang Signed-off-by: Wasim Khan --- Changes in V2: - Updated commit description - Fix CheckPatch issue Changes in V3: - Fix compilation issue with ls102xa platforms drivers/pci/pcie_layerscape_rc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pcie_layerscape_rc.c b/drivers/pci/pcie_layerscape_rc.c index f9e3089..cdfcad6 100644 --- a/drivers/pci/pcie_layerscape_rc.c +++ b/drivers/pci/pcie_layerscape_rc.c @@ -314,6 +314,13 @@ static int ls_pcie_probe(struct udevice *dev) return ret; } + cfg_size = fdt_resource_size(&pcie_rc->cfg_res); + if (cfg_size < SZ_8K) { + printf("PCIe%d: %s Invalid size(0x%llx) for resource \"config\",expected minimum 0x%x\n", + PCIE_SRDS_PRTCL(pcie->idx), dev->name, (u64)cfg_size, SZ_8K); + return 0; + } + /* * Fix the pcie memory map address and PF control registers address * for LS2088A series SoCs @@ -323,7 +330,6 @@ static int ls_pcie_probe(struct udevice *dev) if (svr == SVR_LS2088A || svr == SVR_LS2084A || svr == SVR_LS2048A || svr == SVR_LS2044A || svr == SVR_LS2081A || svr == SVR_LS2041A) { - cfg_size = fdt_resource_size(&pcie_rc->cfg_res); pcie_rc->cfg_res.start = LS2088A_PCIE1_PHYS_ADDR + LS2088A_PCIE_PHYS_SIZE * pcie->idx; pcie_rc->cfg_res.end = pcie_rc->cfg_res.start + cfg_size;