| Message ID | 1599462727-2188-9-git-send-email-chunfeng.yun@mediatek.com |
|---|---|
| State | Superseded |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | [v3,1/9] usb: xhci: add a member hci_version in xhci_ctrl struct | expand |
On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > > Use readx_poll_sleep_timeout() to poll the register status > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > v3: no changes > > v2: fix typo of title suggested by Frank > --- > drivers/usb/host/xhci.c | 25 +++++++++++-------------- > 1 file changed, 11 insertions(+), 14 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On 9/8/20 3:44 AM, Bin Meng wrote: > On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: >> >> Use readx_poll_sleep_timeout() to poll the register status >> >> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> >> --- >> v3: no changes >> >> v2: fix typo of title suggested by Frank >> --- >> drivers/usb/host/xhci.c | 25 +++++++++++-------------- >> 1 file changed, 11 insertions(+), 14 deletions(-) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Thanks. So now I have half of a RESEND patchset with RB tags, and another half of just RB tags without patchset. Can someone of you please collect the tags and resend the patchset once more with the collected tags, so it's all in one place ? Thank you
Hi Marek, I've sent out v4; Hi Frank, Please forward this email to Marek, thanks a lot On Tue, 2020-09-08 at 13:13 +0200, Marek Vasut wrote: > On 9/8/20 3:44 AM, Bin Meng wrote: > > On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > >> > >> Use readx_poll_sleep_timeout() to poll the register status > >> > >> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > >> --- > >> v3: no changes > >> > >> v2: fix typo of title suggested by Frank > >> --- > >> drivers/usb/host/xhci.c | 25 +++++++++++-------------- > >> 1 file changed, 11 insertions(+), 14 deletions(-) > >> > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > Thanks. So now I have half of a RESEND patchset with RB tags, and > another half of just RB tags without patchset. Can someone of you please > collect the tags and resend the patchset once more with the collected > tags, so it's all in one place ? > > Thank you
Hi Marek, On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex@denx.de> wrote: > > On 9/8/20 3:44 AM, Bin Meng wrote: > > On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > >> > >> Use readx_poll_sleep_timeout() to poll the register status > >> > >> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > >> --- > >> v3: no changes > >> > >> v2: fix typo of title suggested by Frank > >> --- > >> drivers/usb/host/xhci.c | 25 +++++++++++-------------- > >> 1 file changed, 11 insertions(+), 14 deletions(-) > >> > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > Thanks. So now I have half of a RESEND patchset with RB tags, and > another half of just RB tags without patchset. Can someone of you please > collect the tags and resend the patchset once more with the collected > tags, so it's all in one place ? > I believe the latest version has all the RB tags. Regards, Bin
On 9/8/20 5:45 PM, Bin Meng wrote: > Hi Marek, Hi, > On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex@denx.de> wrote: >> >> On 9/8/20 3:44 AM, Bin Meng wrote: >>> On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: >>>> >>>> Use readx_poll_sleep_timeout() to poll the register status >>>> >>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> >>>> --- >>>> v3: no changes >>>> >>>> v2: fix typo of title suggested by Frank >>>> --- >>>> drivers/usb/host/xhci.c | 25 +++++++++++-------------- >>>> 1 file changed, 11 insertions(+), 14 deletions(-) >>>> >>> >>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >> >> Thanks. So now I have half of a RESEND patchset with RB tags, and >> another half of just RB tags without patchset. Can someone of you please >> collect the tags and resend the patchset once more with the collected >> tags, so it's all in one place ? >> > > I believe the latest version has all the RB tags. Thank you, I cannot apply a patchset which only has "Re:" in my mailbox, because the original patches are just not there.
Am 8. September 2020 18:15:05 MESZ schrieb Marek Vasut <marex@denx.de>: >Thank you, I cannot apply a patchset which only has "Re:" in my >mailbox, >because the original patches are just not there. Should i resend v4? Or could you apply from Patchwork (series link in upper right of Patch)? Thats the way i use :) https://patchwork.ozlabs.org/project/uboot/list/?series=200140 regards Frank
On 9/8/20 6:34 PM, Frank Wunderlich wrote: > > > Am 8. September 2020 18:15:05 MESZ schrieb Marek Vasut <marex@denx.de>: >> Thank you, I cannot apply a patchset which only has "Re:" in my >> mailbox, >> because the original patches are just not there. > > Should i resend v4? Or could you apply from Patchwork (series link in upper right of Patch)? Thats the way i use :) > > https://patchwork.ozlabs.org/project/uboot/list/?series=200140 Resend please, if I wanted to comment on any of those patches, I won't be able.
Am 8. September 2020 18:47:47 MESZ schrieb Marek Vasut <marex@denx.de>: >Resend please, if I wanted to comment on any of those patches, I won't >be able. Have resend with bit reduced recipients (afair ryder and weijie are in GSS mailinglist),because this floods others mailbox. It's only a workaround. Have you found problem or any idea why you not able to receive from chunfeng directly? regards Frank
On 9/8/20 7:14 PM, Frank Wunderlich wrote: > > > Am 8. September 2020 18:47:47 MESZ schrieb Marek Vasut <marex@denx.de>: > >> Resend please, if I wanted to comment on any of those patches, I won't >> be able. > > Have resend with bit reduced recipients (afair ryder and weijie are in GSS mailinglist),because this floods others mailbox. It's only a workaround. > > Have you found problem or any idea why you not able to receive from chunfeng directly? No, however I have no problems receiving emails from others.
Hi Marek, On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut <marex@denx.de> wrote: > > On 9/8/20 5:45 PM, Bin Meng wrote: > > Hi Marek, > > Hi, > > > On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex@denx.de> wrote: > >> > >> On 9/8/20 3:44 AM, Bin Meng wrote: > >>> On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > >>>> > >>>> Use readx_poll_sleep_timeout() to poll the register status > >>>> > >>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > >>>> --- > >>>> v3: no changes > >>>> > >>>> v2: fix typo of title suggested by Frank > >>>> --- > >>>> drivers/usb/host/xhci.c | 25 +++++++++++-------------- > >>>> 1 file changed, 11 insertions(+), 14 deletions(-) > >>>> > >>> > >>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > >> > >> Thanks. So now I have half of a RESEND patchset with RB tags, and > >> another half of just RB tags without patchset. Can someone of you please > >> collect the tags and resend the patchset once more with the collected > >> tags, so it's all in one place ? > >> > > > > I believe the latest version has all the RB tags. > > Thank you, I cannot apply a patchset which only has "Re:" in my mailbox, > because the original patches are just not there. You can use patchwork to help the custodian work. I found it very helpful to download the patches from patchwork and apply. Regards, Bin
On 9/9/20 3:55 AM, Bin Meng wrote: > Hi Marek, Hi, > On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut <marex@denx.de> wrote: >> >> On 9/8/20 5:45 PM, Bin Meng wrote: >>> Hi Marek, >> >> Hi, >> >>> On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex@denx.de> wrote: >>>> >>>> On 9/8/20 3:44 AM, Bin Meng wrote: >>>>> On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: >>>>>> >>>>>> Use readx_poll_sleep_timeout() to poll the register status >>>>>> >>>>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> >>>>>> --- >>>>>> v3: no changes >>>>>> >>>>>> v2: fix typo of title suggested by Frank >>>>>> --- >>>>>> drivers/usb/host/xhci.c | 25 +++++++++++-------------- >>>>>> 1 file changed, 11 insertions(+), 14 deletions(-) >>>>>> >>>>> >>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >>>> >>>> Thanks. So now I have half of a RESEND patchset with RB tags, and >>>> another half of just RB tags without patchset. Can someone of you please >>>> collect the tags and resend the patchset once more with the collected >>>> tags, so it's all in one place ? >>>> >>> >>> I believe the latest version has all the RB tags. >> >> Thank you, I cannot apply a patchset which only has "Re:" in my mailbox, >> because the original patches are just not there. > > You can use patchwork to help the custodian work. I found it very > helpful to download the patches from patchwork and apply. Can you also comment on patches via patchwork ? I mean, really, can we please just stick to the usual workflow ? That's all I am asking for , nothing else, nothing new.
On Wed, Sep 9, 2020 at 7:05 PM Marek Vasut <marex@denx.de> wrote: > > On 9/9/20 3:55 AM, Bin Meng wrote: > > Hi Marek, > > Hi, > > > On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut <marex@denx.de> wrote: > >> > >> On 9/8/20 5:45 PM, Bin Meng wrote: > >>> Hi Marek, > >> > >> Hi, > >> > >>> On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex@denx.de> wrote: > >>>> > >>>> On 9/8/20 3:44 AM, Bin Meng wrote: > >>>>> On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > >>>>>> > >>>>>> Use readx_poll_sleep_timeout() to poll the register status > >>>>>> > >>>>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > >>>>>> --- > >>>>>> v3: no changes > >>>>>> > >>>>>> v2: fix typo of title suggested by Frank > >>>>>> --- > >>>>>> drivers/usb/host/xhci.c | 25 +++++++++++-------------- > >>>>>> 1 file changed, 11 insertions(+), 14 deletions(-) > >>>>>> > >>>>> > >>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > >>>> > >>>> Thanks. So now I have half of a RESEND patchset with RB tags, and > >>>> another half of just RB tags without patchset. Can someone of you please > >>>> collect the tags and resend the patchset once more with the collected > >>>> tags, so it's all in one place ? > >>>> > >>> > >>> I believe the latest version has all the RB tags. > >> > >> Thank you, I cannot apply a patchset which only has "Re:" in my mailbox, > >> because the original patches are just not there. > > > > You can use patchwork to help the custodian work. I found it very > > helpful to download the patches from patchwork and apply. > > Can you also comment on patches via patchwork ? > > I mean, really, can we please just stick to the usual workflow ? That's > all I am asking for , nothing else, nothing new. I don't understand the question about "usual workflow". You asked "I cannot apply a patchset which only has "Re:" in my mailbox" and I recommended patchwork which will satisfy the requirement of what you asked. Regards, Bin
On 9/9/20 3:46 PM, Bin Meng wrote: > On Wed, Sep 9, 2020 at 7:05 PM Marek Vasut <marex@denx.de> wrote: >> >> On 9/9/20 3:55 AM, Bin Meng wrote: >>> Hi Marek, >> >> Hi, >> >>> On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut <marex@denx.de> wrote: >>>> >>>> On 9/8/20 5:45 PM, Bin Meng wrote: >>>>> Hi Marek, >>>> >>>> Hi, >>>> >>>>> On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex@denx.de> wrote: >>>>>> >>>>>> On 9/8/20 3:44 AM, Bin Meng wrote: >>>>>>> On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: >>>>>>>> >>>>>>>> Use readx_poll_sleep_timeout() to poll the register status >>>>>>>> >>>>>>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> >>>>>>>> --- >>>>>>>> v3: no changes >>>>>>>> >>>>>>>> v2: fix typo of title suggested by Frank >>>>>>>> --- >>>>>>>> drivers/usb/host/xhci.c | 25 +++++++++++-------------- >>>>>>>> 1 file changed, 11 insertions(+), 14 deletions(-) >>>>>>>> >>>>>>> >>>>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >>>>>> >>>>>> Thanks. So now I have half of a RESEND patchset with RB tags, and >>>>>> another half of just RB tags without patchset. Can someone of you please >>>>>> collect the tags and resend the patchset once more with the collected >>>>>> tags, so it's all in one place ? >>>>>> >>>>> >>>>> I believe the latest version has all the RB tags. >>>> >>>> Thank you, I cannot apply a patchset which only has "Re:" in my mailbox, >>>> because the original patches are just not there. >>> >>> You can use patchwork to help the custodian work. I found it very >>> helpful to download the patches from patchwork and apply. >> >> Can you also comment on patches via patchwork ? >> >> I mean, really, can we please just stick to the usual workflow ? That's >> all I am asking for , nothing else, nothing new. > > I don't understand the question about "usual workflow". You asked "I > cannot apply a patchset which only has "Re:" in my mailbox" and I > recommended patchwork which will satisfy the requirement of what you > asked. Right, I can, but if there is more I want to say about the patch, I cannot do it with patchwork. Then I need the patch, which I don't have. Hence my remark about the usual email-based workflow.
On Wed, Sep 9, 2020 at 10:02 PM Marek Vasut <marex@denx.de> wrote: > > On 9/9/20 3:46 PM, Bin Meng wrote: > > On Wed, Sep 9, 2020 at 7:05 PM Marek Vasut <marex@denx.de> wrote: > >> > >> On 9/9/20 3:55 AM, Bin Meng wrote: > >>> Hi Marek, > >> > >> Hi, > >> > >>> On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut <marex@denx.de> wrote: > >>>> > >>>> On 9/8/20 5:45 PM, Bin Meng wrote: > >>>>> Hi Marek, > >>>> > >>>> Hi, > >>>> > >>>>> On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex@denx.de> wrote: > >>>>>> > >>>>>> On 9/8/20 3:44 AM, Bin Meng wrote: > >>>>>>> On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > >>>>>>>> > >>>>>>>> Use readx_poll_sleep_timeout() to poll the register status > >>>>>>>> > >>>>>>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > >>>>>>>> --- > >>>>>>>> v3: no changes > >>>>>>>> > >>>>>>>> v2: fix typo of title suggested by Frank > >>>>>>>> --- > >>>>>>>> drivers/usb/host/xhci.c | 25 +++++++++++-------------- > >>>>>>>> 1 file changed, 11 insertions(+), 14 deletions(-) > >>>>>>>> > >>>>>>> > >>>>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > >>>>>> > >>>>>> Thanks. So now I have half of a RESEND patchset with RB tags, and > >>>>>> another half of just RB tags without patchset. Can someone of you please > >>>>>> collect the tags and resend the patchset once more with the collected > >>>>>> tags, so it's all in one place ? > >>>>>> > >>>>> > >>>>> I believe the latest version has all the RB tags. > >>>> > >>>> Thank you, I cannot apply a patchset which only has "Re:" in my mailbox, > >>>> because the original patches are just not there. > >>> > >>> You can use patchwork to help the custodian work. I found it very > >>> helpful to download the patches from patchwork and apply. > >> > >> Can you also comment on patches via patchwork ? > >> > >> I mean, really, can we please just stick to the usual workflow ? That's > >> all I am asking for , nothing else, nothing new. > > > > I don't understand the question about "usual workflow". You asked "I > > cannot apply a patchset which only has "Re:" in my mailbox" and I > > recommended patchwork which will satisfy the requirement of what you > > asked. > > Right, I can, but if there is more I want to say about the patch, I > cannot do it with patchwork. Then I need the patch, which I don't have. > Hence my remark about the usual email-based workflow. Yes, that's true. If we need to post comments about patches, we will have to use email. Regards, Bin
On Wed, Sep 09, 2020 at 10:05:42PM +0800, Bin Meng wrote: > On Wed, Sep 9, 2020 at 10:02 PM Marek Vasut <marex@denx.de> wrote: > > > > On 9/9/20 3:46 PM, Bin Meng wrote: > > > On Wed, Sep 9, 2020 at 7:05 PM Marek Vasut <marex@denx.de> wrote: > > >> > > >> On 9/9/20 3:55 AM, Bin Meng wrote: > > >>> Hi Marek, > > >> > > >> Hi, > > >> > > >>> On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut <marex@denx.de> wrote: > > >>>> > > >>>> On 9/8/20 5:45 PM, Bin Meng wrote: > > >>>>> Hi Marek, > > >>>> > > >>>> Hi, > > >>>> > > >>>>> On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex@denx.de> wrote: > > >>>>>> > > >>>>>> On 9/8/20 3:44 AM, Bin Meng wrote: > > >>>>>>> On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > > >>>>>>>> > > >>>>>>>> Use readx_poll_sleep_timeout() to poll the register status > > >>>>>>>> > > >>>>>>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > >>>>>>>> --- > > >>>>>>>> v3: no changes > > >>>>>>>> > > >>>>>>>> v2: fix typo of title suggested by Frank > > >>>>>>>> --- > > >>>>>>>> drivers/usb/host/xhci.c | 25 +++++++++++-------------- > > >>>>>>>> 1 file changed, 11 insertions(+), 14 deletions(-) > > >>>>>>>> > > >>>>>>> > > >>>>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > >>>>>> > > >>>>>> Thanks. So now I have half of a RESEND patchset with RB tags, and > > >>>>>> another half of just RB tags without patchset. Can someone of you please > > >>>>>> collect the tags and resend the patchset once more with the collected > > >>>>>> tags, so it's all in one place ? > > >>>>>> > > >>>>> > > >>>>> I believe the latest version has all the RB tags. > > >>>> > > >>>> Thank you, I cannot apply a patchset which only has "Re:" in my mailbox, > > >>>> because the original patches are just not there. > > >>> > > >>> You can use patchwork to help the custodian work. I found it very > > >>> helpful to download the patches from patchwork and apply. > > >> > > >> Can you also comment on patches via patchwork ? > > >> > > >> I mean, really, can we please just stick to the usual workflow ? That's > > >> all I am asking for , nothing else, nothing new. > > > > > > I don't understand the question about "usual workflow". You asked "I > > > cannot apply a patchset which only has "Re:" in my mailbox" and I > > > recommended patchwork which will satisfy the requirement of what you > > > asked. > > > > Right, I can, but if there is more I want to say about the patch, I > > cannot do it with patchwork. Then I need the patch, which I don't have. > > Hence my remark about the usual email-based workflow. > > Yes, that's true. If we need to post comments about patches, we will > have to use email. Which, to close the loop, is trivial with patchwork, if you're making a new comment, and hard if you are trying to join an ongoing conversation.
On 9/9/20 4:05 PM, Bin Meng wrote: > On Wed, Sep 9, 2020 at 10:02 PM Marek Vasut <marex@denx.de> wrote: >> >> On 9/9/20 3:46 PM, Bin Meng wrote: >>> On Wed, Sep 9, 2020 at 7:05 PM Marek Vasut <marex@denx.de> wrote: >>>> >>>> On 9/9/20 3:55 AM, Bin Meng wrote: >>>>> Hi Marek, >>>> >>>> Hi, >>>> >>>>> On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut <marex@denx.de> wrote: >>>>>> >>>>>> On 9/8/20 5:45 PM, Bin Meng wrote: >>>>>>> Hi Marek, >>>>>> >>>>>> Hi, >>>>>> >>>>>>> On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex@denx.de> wrote: >>>>>>>> >>>>>>>> On 9/8/20 3:44 AM, Bin Meng wrote: >>>>>>>>> On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: >>>>>>>>>> >>>>>>>>>> Use readx_poll_sleep_timeout() to poll the register status >>>>>>>>>> >>>>>>>>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> >>>>>>>>>> --- >>>>>>>>>> v3: no changes >>>>>>>>>> >>>>>>>>>> v2: fix typo of title suggested by Frank >>>>>>>>>> --- >>>>>>>>>> drivers/usb/host/xhci.c | 25 +++++++++++-------------- >>>>>>>>>> 1 file changed, 11 insertions(+), 14 deletions(-) >>>>>>>>>> >>>>>>>>> >>>>>>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >>>>>>>> >>>>>>>> Thanks. So now I have half of a RESEND patchset with RB tags, and >>>>>>>> another half of just RB tags without patchset. Can someone of you please >>>>>>>> collect the tags and resend the patchset once more with the collected >>>>>>>> tags, so it's all in one place ? >>>>>>>> >>>>>>> >>>>>>> I believe the latest version has all the RB tags. >>>>>> >>>>>> Thank you, I cannot apply a patchset which only has "Re:" in my mailbox, >>>>>> because the original patches are just not there. >>>>> >>>>> You can use patchwork to help the custodian work. I found it very >>>>> helpful to download the patches from patchwork and apply. >>>> >>>> Can you also comment on patches via patchwork ? >>>> >>>> I mean, really, can we please just stick to the usual workflow ? That's >>>> all I am asking for , nothing else, nothing new. >>> >>> I don't understand the question about "usual workflow". You asked "I >>> cannot apply a patchset which only has "Re:" in my mailbox" and I >>> recommended patchwork which will satisfy the requirement of what you >>> asked. >> >> Right, I can, but if there is more I want to say about the patch, I >> cannot do it with patchwork. Then I need the patch, which I don't have. >> Hence my remark about the usual email-based workflow. > > Yes, that's true. If we need to post comments about patches, we will > have to use email. The problem here is that for whatever reason, I didn't receive the original patches, Frank had to resend them, then I got RBs on some of each and it was a mess. I'd just like to get back to the usual. I think we agree, don't we ? Anyway, thanks for the RBs, that really helped.
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index fe30101..3547a9b 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -33,6 +33,7 @@ #include <linux/bug.h> #include <linux/delay.h> #include <linux/errno.h> +#include <linux/iopoll.h> #include <usb/xhci.h> #ifndef CONFIG_USB_MAX_CONTROLLER_COUNT @@ -143,23 +144,19 @@ struct xhci_ctrl *xhci_get_ctrl(struct usb_device *udev) * @param usec time to wait till * @return 0 if handshake is success else < 0 on failure */ -static int handshake(uint32_t volatile *ptr, uint32_t mask, - uint32_t done, int usec) +static int +handshake(uint32_t volatile *ptr, uint32_t mask, uint32_t done, int usec) { uint32_t result; + int ret; + + ret = readx_poll_sleep_timeout(xhci_readl, ptr, result, + (result & mask) == done || result == U32_MAX, + 1, usec); + if (result == U32_MAX) /* card removed */ + return -ENODEV; - do { - result = xhci_readl(ptr); - if (result == ~(uint32_t)0) - return -ENODEV; - result &= mask; - if (result == done) - return 0; - usec--; - udelay(1); - } while (usec > 0); - - return -ETIMEDOUT; + return ret; } /**
Use readx_poll_sleep_timeout() to poll the register status Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- v3: no changes v2: fix typo of title suggested by Frank --- drivers/usb/host/xhci.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-)