| Message ID | 1597289108-22936-11-git-send-email-chunfeng.yun@mediatek.com |
|---|---|
| State | Superseded |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | [01/11] usb: xhci: add a member hci_version in xhci_ctrl struct | expand |
> Gesendet: Donnerstag, 13. August 2020 um 05:25 Uhr > Von: "Chunfeng Yun" <chunfeng.yun@mediatek.com> > Betreff: [PATCH 11/11] usb: xhci: convet to readx_poll_sleep_timeout() just a small typo "convet" maybe it can be fixed while applying? regards Frank
On Sun, 2020-08-16 at 09:56 +0200, Frank Wunderlich wrote: > > Gesendet: Donnerstag, 13. August 2020 um 05:25 Uhr > > Von: "Chunfeng Yun" <chunfeng.yun@mediatek.com> > > Betreff: [PATCH 11/11] usb: xhci: convet to readx_poll_sleep_timeout() > > just a small typo "convet" Will fix it, thanks > > maybe it can be fixed while applying? > > regards Frank
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index fe30101..3547a9b 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -33,6 +33,7 @@ #include <linux/bug.h> #include <linux/delay.h> #include <linux/errno.h> +#include <linux/iopoll.h> #include <usb/xhci.h> #ifndef CONFIG_USB_MAX_CONTROLLER_COUNT @@ -143,23 +144,19 @@ struct xhci_ctrl *xhci_get_ctrl(struct usb_device *udev) * @param usec time to wait till * @return 0 if handshake is success else < 0 on failure */ -static int handshake(uint32_t volatile *ptr, uint32_t mask, - uint32_t done, int usec) +static int +handshake(uint32_t volatile *ptr, uint32_t mask, uint32_t done, int usec) { uint32_t result; + int ret; + + ret = readx_poll_sleep_timeout(xhci_readl, ptr, result, + (result & mask) == done || result == U32_MAX, + 1, usec); + if (result == U32_MAX) /* card removed */ + return -ENODEV; - do { - result = xhci_readl(ptr); - if (result == ~(uint32_t)0) - return -ENODEV; - result &= mask; - if (result == done) - return 0; - usec--; - udelay(1); - } while (usec > 0); - - return -ETIMEDOUT; + return ret; } /**
Use readx_poll_sleep_timeout() to poll the register status Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/usb/host/xhci.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-)