diff mbox series

[5/6] riscv: sifive/fu540: Drop NET_RANDOM_ETHADDR

Message ID 1596434946-12630-5-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit 50856c3f0f0d14da97634e9cdef2f0380210f9cc
Delegated to: Andes
Headers show
Series [1/6] riscv: Call spl_board_init_f() in the generic SPL board_init_f() | expand

Commit Message

Bin Meng Aug. 3, 2020, 6:09 a.m. UTC 
From: Bin Meng <bin.meng@windriver.com>

This option was enabled during the earlier U-Boot porting time. Now
we already have the OTP driver in place and the unique MAC address
is read from the OTP, there is no need to turn on this option.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 board/sifive/fu540/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Leo Liang Aug. 6, 2020, 3:35 a.m. UTC | #1 
On Sun, Aug 02, 2020 at 11:09:05PM -0700, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
> 
> This option was enabled during the earlier U-Boot porting time. Now
> we already have the OTP driver in place and the unique MAC address
> is read from the OTP, there is no need to turn on this option.
> 
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
> 
>  board/sifive/fu540/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/board/sifive/fu540/Kconfig b/board/sifive/fu540/Kconfig
> index fc28120..e70d1e5 100644
> --- a/board/sifive/fu540/Kconfig
> +++ b/board/sifive/fu540/Kconfig
> @@ -41,7 +41,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>  	imply EFI_PARTITION
>  	imply IP_DYN
>  	imply ISO_PARTITION
> -	imply NET_RANDOM_ETHADDR
>  	imply PHY_LIB
>  	imply PHY_MSCC
>  	imply SPI_FLASH
> -- 
> 2.7.4
> 

Reviewed-by: Leo Liang <ycliang@andestech.com>
Rick Chen Aug. 6, 2020, 6:56 a.m. UTC | #2 
> From: Bin Meng [mailto:bmeng.cn@gmail.com]
> Sent: Monday, August 03, 2020 2:09 PM
> To: Rick Jian-Zhi Chen(陳建志); Pragnesh Patel; U-Boot Mailing List
> Cc: Bin Meng
> Subject: [PATCH 5/6] riscv: sifive/fu540: Drop NET_RANDOM_ETHADDR
>
> From: Bin Meng <bin.meng@windriver.com>
>
> This option was enabled during the earlier U-Boot porting time. Now we already have the OTP driver in place and the unique MAC address is read from the OTP, there is no need to turn on this option.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
>  board/sifive/fu540/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Rick Chen <rick@andestech.com>
Pragnesh Patel Aug. 6, 2020, 7:40 a.m. UTC | #3 
>-----Original Message-----
>From: Bin Meng <bmeng.cn@gmail.com>
>Sent: 03 August 2020 11:39
>To: Rick Chen <rick@andestech.com>; Pragnesh Patel
><pragnesh.patel@sifive.com>; U-Boot Mailing List <u-boot@lists.denx.de>
>Cc: Bin Meng <bin.meng@windriver.com>
>Subject: [PATCH 5/6] riscv: sifive/fu540: Drop NET_RANDOM_ETHADDR
>
>[External Email] Do not click links or attachments unless you recognize the
>sender and know the content is safe
>
>From: Bin Meng <bin.meng@windriver.com>
>
>This option was enabled during the earlier U-Boot porting time. Now we already
>have the OTP driver in place and the unique MAC address is read from the OTP,
>there is no need to turn on this option.
>
>Signed-off-by: Bin Meng <bin.meng@windriver.com>
>---
>
> board/sifive/fu540/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Pragnesh Patel <pragnesh.patel@sifive.com>
Tested-by: Pragnesh Patel <pragnesh.patel@sifive.com>
diff mbox series

Patch

diff --git a/board/sifive/fu540/Kconfig b/board/sifive/fu540/Kconfig
index fc28120..e70d1e5 100644
--- a/board/sifive/fu540/Kconfig
+++ b/board/sifive/fu540/Kconfig
@@ -41,7 +41,6 @@  config BOARD_SPECIFIC_OPTIONS # dummy
 	imply EFI_PARTITION
 	imply IP_DYN
 	imply ISO_PARTITION
-	imply NET_RANDOM_ETHADDR
 	imply PHY_LIB
 	imply PHY_MSCC
 	imply SPI_FLASH