| Message ID | 1542796908-7947-2-git-send-email-tien.fong.chee@intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | Add support for loading FPGA bitstream | expand |
On 11/21/2018 11:41 AM, tien.fong.chee@intel.com wrote: > From: Tien Fong Chee <tien.fong.chee@intel.com> > > This patch adds description on properties about file name used for both > peripheral bitstream and core bitstream. > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > --- > .../fpga/altera-socfpga-a10-fpga-mgr.txt | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > index 2fd8e7a..010322a 100644 > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > @@ -7,6 +7,10 @@ Required properties: > - The second index is for writing FPGA configuration data. > - resets : Phandle and reset specifier for the device's reset. > - clocks : Clocks used by the device. > +- altr,bitstream_periph : File name for FPGA peripheral raw binary which is used > + to initialize FPGA IOs, PLL, IO48 and DDR. > +- altr,bitstream_core : File name for core raw binary which contains FPGA design > + which is used to program FPGA CRAM and ERAM. bitstream- instead of bitstream_ btw can we get something that works with full bitstream too ? > Example: > > @@ -16,4 +20,6 @@ Example: > 0xffcfe400 0x20>; > clocks = <&l4_mp_clk>; > resets = <&rst FPGAMGR_RESET>; > + altr,bitstream_periph = "ghrd_10as066n2.periph.rbf.mkimage"; > + altr,bitstream_core = "ghrd_10as066n2.core.rbf.mkimage"; > }; >
On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: > On 11/21/2018 11:41 AM, tien.fong.chee@intel.com wrote: > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > This patch adds description on properties about file name used for > > both > > peripheral bitstream and core bitstream. > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > --- > > .../fpga/altera-socfpga-a10-fpga-mgr.txt | 6 ++++++ > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- > > mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- > > mgr.txt > > index 2fd8e7a..010322a 100644 > > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > > @@ -7,6 +7,10 @@ Required properties: > > - The second index is for writing FPGA > > configuration data. > > - resets : Phandle and reset specifier for the device's reset. > > - clocks : Clocks used by the device. > > +- altr,bitstream_periph : File name for FPGA peripheral raw binary > > which is used > > + to initialize FPGA IOs, PLL, IO48 and > > DDR. > > +- altr,bitstream_core : File name for core raw binary which > > contains FPGA design > > + which is used to program FPGA CRAM and > > ERAM. > bitstream- instead of bitstream_ Noted. > > btw can we get something that works with full bitstream too ? This patchset actually support the full bitstream too, unfortunately it is blocked by hardware MPFE issue. The patchset for the MPFE workaround would come after this patchset. I would advice to use the early IO release method for the sake of performance. For details of issue, you can read the from the link https://github.com /altera-opensource/u-boot-socfpga/commits/socfpga_v2014.10_arria10_brin gup FogBugz #410989-6: Masking hardware sequenced warm reset for logic in… … Tien Fong Chee Tien Fong Chee committed on Feb 16, 2017 FogBugz #410989-5: Enable RAM boot … Tien Fong Chee Tien Fong Chee committed on Feb 16, 2017 FogBugz #410989-4: Added software reset for QSPI … Tien Fong Chee Tien Fong Chee committed on Feb 8, 2017 FogBugz #410989-3: Disable redundant redundant messages after a warm … … Tien Fong Chee Tien Fong Chee committed on Dec 21, 2016 FogBugz #410989-2: Reset MPFE NoC after programming periperal rbf … Tien Fong Chee Tien Fong Chee committed on Dec 21, 2016 FogBugz #410989-1: Functions for setting/checking magic no. to isw_ha… … Tien Fong Chee Tien Fong Chee committed on Dec 21, 2016 > > > > > Example: > > > > @@ -16,4 +20,6 @@ Example: > > 0xffcfe400 0x20>; > > clocks = <&l4_mp_clk>; > > resets = <&rst FPGAMGR_RESET>; > > + altr,bitstream_periph = > > "ghrd_10as066n2.periph.rbf.mkimage"; > > + altr,bitstream_core = > > "ghrd_10as066n2.core.rbf.mkimage"; > > }; > > >
On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: > On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: >> On 11/21/2018 11:41 AM, tien.fong.chee@intel.com wrote: >>> >>> From: Tien Fong Chee <tien.fong.chee@intel.com> >>> >>> This patch adds description on properties about file name used for >>> both >>> peripheral bitstream and core bitstream. >>> >>> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> >>> --- >>> .../fpga/altera-socfpga-a10-fpga-mgr.txt | 6 ++++++ >>> 1 files changed, 6 insertions(+), 0 deletions(-) >>> >>> diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- >>> mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- >>> mgr.txt >>> index 2fd8e7a..010322a 100644 >>> --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt >>> +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt >>> @@ -7,6 +7,10 @@ Required properties: >>> - The second index is for writing FPGA >>> configuration data. >>> - resets : Phandle and reset specifier for the device's reset. >>> - clocks : Clocks used by the device. >>> +- altr,bitstream_periph : File name for FPGA peripheral raw binary >>> which is used >>> + to initialize FPGA IOs, PLL, IO48 and >>> DDR. >>> +- altr,bitstream_core : File name for core raw binary which >>> contains FPGA design >>> + which is used to program FPGA CRAM and >>> ERAM. >> bitstream- instead of bitstream_ > Noted. >> >> btw can we get something that works with full bitstream too ? > This patchset actually support the full bitstream too, unfortunately it > is blocked by hardware MPFE issue. The patchset for the MPFE workaround > would come after this patchset. I would advice to use the early IO > release method for the sake of performance. > > For details of issue, you can read the from the link https://github.com > /altera-opensource/u-boot-socfpga/commits/socfpga_v2014.10_arria10_brin > gup > FogBugz #410989-6: Masking hardware sequenced warm reset for logic > in… … Does that work on ES2 ? I don't think so ...
On Fri, 2018-11-23 at 13:23 +0100, Marek Vasut wrote: > On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: > > > > On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: > > > > > > On 11/21/2018 11:41 AM, tien.fong.chee@intel.com wrote: > > > > > > > > > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > This patch adds description on properties about file name used > > > > for > > > > both > > > > peripheral bitstream and core bitstream. > > > > > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > > > --- > > > > .../fpga/altera-socfpga-a10-fpga-mgr.txt | 6 > > > > ++++++ > > > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10- > > > > fpga- > > > > mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10- > > > > fpga- > > > > mgr.txt > > > > index 2fd8e7a..010322a 100644 > > > > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- > > > > mgr.txt > > > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- > > > > mgr.txt > > > > @@ -7,6 +7,10 @@ Required properties: > > > > - The second index is for writing FPGA > > > > configuration data. > > > > - resets : Phandle and reset specifier for the device's > > > > reset. > > > > - clocks : Clocks used by the device. > > > > +- altr,bitstream_periph : File name for FPGA peripheral raw > > > > binary > > > > which is used > > > > + to initialize FPGA IOs, PLL, IO48 > > > > and > > > > DDR. > > > > +- altr,bitstream_core : File name for core raw binary which > > > > contains FPGA design > > > > + which is used to program FPGA CRAM and > > > > ERAM. > > > bitstream- instead of bitstream_ > > Noted. > > > > > > > > > btw can we get something that works with full bitstream too ? > > This patchset actually support the full bitstream too, > > unfortunately it > > is blocked by hardware MPFE issue. The patchset for the MPFE > > workaround > > would come after this patchset. I would advice to use the early IO > > release method for the sake of performance. > > > > For details of issue, you can read the from the link https://github > > .com > > /altera-opensource/u-boot- > > socfpga/commits/socfpga_v2014.10_arria10_brin > > gup > > FogBugz #410989-6: Masking hardware sequenced warm reset for logic > > in… … > Does that work on ES2 ? I don't think so ... Why you think it doesn't work, using early IO or full rbf? The bitstream limitation? What you see from the print out? >
On 11/26/2018 10:44 AM, Chee, Tien Fong wrote: > On Fri, 2018-11-23 at 13:23 +0100, Marek Vasut wrote: >> On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: >>> >>> On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: >>>> >>>> On 11/21/2018 11:41 AM, tien.fong.chee@intel.com wrote: >>>>> >>>>> >>>>> From: Tien Fong Chee <tien.fong.chee@intel.com> >>>>> >>>>> This patch adds description on properties about file name used >>>>> for >>>>> both >>>>> peripheral bitstream and core bitstream. >>>>> >>>>> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> >>>>> --- >>>>> .../fpga/altera-socfpga-a10-fpga-mgr.txt | 6 >>>>> ++++++ >>>>> 1 files changed, 6 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10- >>>>> fpga- >>>>> mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10- >>>>> fpga- >>>>> mgr.txt >>>>> index 2fd8e7a..010322a 100644 >>>>> --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- >>>>> mgr.txt >>>>> +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- >>>>> mgr.txt >>>>> @@ -7,6 +7,10 @@ Required properties: >>>>> - The second index is for writing FPGA >>>>> configuration data. >>>>> - resets : Phandle and reset specifier for the device's >>>>> reset. >>>>> - clocks : Clocks used by the device. >>>>> +- altr,bitstream_periph : File name for FPGA peripheral raw >>>>> binary >>>>> which is used >>>>> + to initialize FPGA IOs, PLL, IO48 >>>>> and >>>>> DDR. >>>>> +- altr,bitstream_core : File name for core raw binary which >>>>> contains FPGA design >>>>> + which is used to program FPGA CRAM and >>>>> ERAM. >>>> bitstream- instead of bitstream_ >>> Noted. >>>> >>>> >>>> btw can we get something that works with full bitstream too ? >>> This patchset actually support the full bitstream too, >>> unfortunately it >>> is blocked by hardware MPFE issue. The patchset for the MPFE >>> workaround >>> would come after this patchset. I would advice to use the early IO >>> release method for the sake of performance. >>> >>> For details of issue, you can read the from the link https://github >>> .com >>> /altera-opensource/u-boot- >>> socfpga/commits/socfpga_v2014.10_arria10_brin >>> gup >>> FogBugz #410989-6: Masking hardware sequenced warm reset for logic >>> in… … >> Does that work on ES2 ? I don't think so ... > Why you think it doesn't work, using early IO or full rbf? The > bitstream limitation? What you see from the print out? ES2 can only use full RBF, I don't think this is handled in this patchset at all.
On Mon, 2018-11-26 at 12:15 +0100, Marek Vasut wrote: > On 11/26/2018 10:44 AM, Chee, Tien Fong wrote: > > > > On Fri, 2018-11-23 at 13:23 +0100, Marek Vasut wrote: > > > > > > On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > On 11/21/2018 11:41 AM, tien.fong.chee@intel.com wrote: > > > > > > > > > > > > > > > > > > > > > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > > > > > This patch adds description on properties about file name > > > > > > used > > > > > > for > > > > > > both > > > > > > peripheral bitstream and core bitstream. > > > > > > > > > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > --- > > > > > > .../fpga/altera-socfpga-a10-fpga-mgr.txt | 6 > > > > > > ++++++ > > > > > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > > > > > > > > > diff --git a/doc/device-tree-bindings/fpga/altera-socfpga- > > > > > > a10- > > > > > > fpga- > > > > > > mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10- > > > > > > fpga- > > > > > > mgr.txt > > > > > > index 2fd8e7a..010322a 100644 > > > > > > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10- > > > > > > fpga- > > > > > > mgr.txt > > > > > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10- > > > > > > fpga- > > > > > > mgr.txt > > > > > > @@ -7,6 +7,10 @@ Required properties: > > > > > > - The second index is for writing FPGA > > > > > > configuration data. > > > > > > - resets : Phandle and reset specifier for the > > > > > > device's > > > > > > reset. > > > > > > - clocks : Clocks used by the device. > > > > > > +- altr,bitstream_periph : File name for FPGA peripheral > > > > > > raw > > > > > > binary > > > > > > which is used > > > > > > + to initialize FPGA IOs, PLL, > > > > > > IO48 > > > > > > and > > > > > > DDR. > > > > > > +- altr,bitstream_core : File name for core raw binary > > > > > > which > > > > > > contains FPGA design > > > > > > + which is used to program FPGA CRAM > > > > > > and > > > > > > ERAM. > > > > > bitstream- instead of bitstream_ > > > > Noted. > > > > > > > > > > > > > > > > > > > > btw can we get something that works with full bitstream too ? > > > > This patchset actually support the full bitstream too, > > > > unfortunately it > > > > is blocked by hardware MPFE issue. The patchset for the MPFE > > > > workaround > > > > would come after this patchset. I would advice to use the early > > > > IO > > > > release method for the sake of performance. > > > > > > > > For details of issue, you can read the from the link https://gi > > > > thub > > > > .com > > > > /altera-opensource/u-boot- > > > > socfpga/commits/socfpga_v2014.10_arria10_brin > > > > gup > > > > FogBugz #410989-6: Masking hardware sequenced warm reset for > > > > logic > > > > in… … > > > Does that work on ES2 ? I don't think so ... > > Why you think it doesn't work, using early IO or full rbf? The > > bitstream limitation? What you see from the print out? > ES2 can only use full RBF, I don't think this is handled in this > patchset at all. i did testing the full rbf loading, but in the end i removed that portion of codes because it stuck in DDR calibration due to MPFE HW issue. So, i would put back that portion of codes after MPFE HW workaround. My plan is to let early IO release up 1st. Actually ES2 board also support early IO release, just you need ACDS and SOCEDS version 17.1 onward to rebuild your hardware, and choosing the early IO release setting inside the tool. We can discuss this more if you need our help for early IO release RBFs. >
On 11/27/2018 09:45 AM, Chee, Tien Fong wrote: > On Mon, 2018-11-26 at 12:15 +0100, Marek Vasut wrote: >> On 11/26/2018 10:44 AM, Chee, Tien Fong wrote: >>> >>> On Fri, 2018-11-23 at 13:23 +0100, Marek Vasut wrote: >>>> >>>> On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: >>>>> >>>>> >>>>> On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: >>>>>> >>>>>> >>>>>> On 11/21/2018 11:41 AM, tien.fong.chee@intel.com wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> From: Tien Fong Chee <tien.fong.chee@intel.com> >>>>>>> >>>>>>> This patch adds description on properties about file name >>>>>>> used >>>>>>> for >>>>>>> both >>>>>>> peripheral bitstream and core bitstream. >>>>>>> >>>>>>> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> >>>>>>> --- >>>>>>> .../fpga/altera-socfpga-a10-fpga-mgr.txt | 6 >>>>>>> ++++++ >>>>>>> 1 files changed, 6 insertions(+), 0 deletions(-) >>>>>>> >>>>>>> diff --git a/doc/device-tree-bindings/fpga/altera-socfpga- >>>>>>> a10- >>>>>>> fpga- >>>>>>> mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10- >>>>>>> fpga- >>>>>>> mgr.txt >>>>>>> index 2fd8e7a..010322a 100644 >>>>>>> --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10- >>>>>>> fpga- >>>>>>> mgr.txt >>>>>>> +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10- >>>>>>> fpga- >>>>>>> mgr.txt >>>>>>> @@ -7,6 +7,10 @@ Required properties: >>>>>>> - The second index is for writing FPGA >>>>>>> configuration data. >>>>>>> - resets : Phandle and reset specifier for the >>>>>>> device's >>>>>>> reset. >>>>>>> - clocks : Clocks used by the device. >>>>>>> +- altr,bitstream_periph : File name for FPGA peripheral >>>>>>> raw >>>>>>> binary >>>>>>> which is used >>>>>>> + to initialize FPGA IOs, PLL, >>>>>>> IO48 >>>>>>> and >>>>>>> DDR. >>>>>>> +- altr,bitstream_core : File name for core raw binary >>>>>>> which >>>>>>> contains FPGA design >>>>>>> + which is used to program FPGA CRAM >>>>>>> and >>>>>>> ERAM. >>>>>> bitstream- instead of bitstream_ >>>>> Noted. >>>>>> >>>>>> >>>>>> >>>>>> btw can we get something that works with full bitstream too ? >>>>> This patchset actually support the full bitstream too, >>>>> unfortunately it >>>>> is blocked by hardware MPFE issue. The patchset for the MPFE >>>>> workaround >>>>> would come after this patchset. I would advice to use the early >>>>> IO >>>>> release method for the sake of performance. >>>>> >>>>> For details of issue, you can read the from the link https://gi >>>>> thub >>>>> .com >>>>> /altera-opensource/u-boot- >>>>> socfpga/commits/socfpga_v2014.10_arria10_brin >>>>> gup >>>>> FogBugz #410989-6: Masking hardware sequenced warm reset for >>>>> logic >>>>> in… … >>>> Does that work on ES2 ? I don't think so ... >>> Why you think it doesn't work, using early IO or full rbf? The >>> bitstream limitation? What you see from the print out? >> ES2 can only use full RBF, I don't think this is handled in this >> patchset at all. > i did testing the full rbf loading, but in the end i removed that > portion of codes because it stuck in DDR calibration due to MPFE HW > issue. So, i would put back that portion of codes after MPFE HW > workaround. My plan is to let early IO release up 1st. Can you describe that workaround ? The code worked on the A10ES2 kit I have back around v2018.09, so what's the problem ? > Actually ES2 board also support early IO release, just you need ACDS > and SOCEDS version 17.1 onward to rebuild your hardware, and choosing > the early IO release setting inside the tool. We can discuss this more > if you need our help for early IO release RBFs. I do, otherwise I won't be able to test anything, so make sure this is supported.
On Tue, 2018-11-27 at 13:07 +0100, Marek Vasut wrote: > On 11/27/2018 09:45 AM, Chee, Tien Fong wrote: > > > > On Mon, 2018-11-26 at 12:15 +0100, Marek Vasut wrote: > > > > > > On 11/26/2018 10:44 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > On Fri, 2018-11-23 at 13:23 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/21/2018 11:41 AM, tien.fong.chee@intel.com wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > > > > > > > > > This patch adds description on properties about file > > > > > > > > name > > > > > > > > used > > > > > > > > for > > > > > > > > both > > > > > > > > peripheral bitstream and core bitstream. > > > > > > > > > > > > > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com > > > > > > > > > > > > > > > > > --- > > > > > > > > .../fpga/altera-socfpga-a10-fpga- > > > > > > > > mgr.txt | 6 > > > > > > > > ++++++ > > > > > > > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > > > > > > > > > > > > > diff --git a/doc/device-tree-bindings/fpga/altera- > > > > > > > > socfpga- > > > > > > > > a10- > > > > > > > > fpga- > > > > > > > > mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga- > > > > > > > > a10- > > > > > > > > fpga- > > > > > > > > mgr.txt > > > > > > > > index 2fd8e7a..010322a 100644 > > > > > > > > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10- > > > > > > > > fpga- > > > > > > > > mgr.txt > > > > > > > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10- > > > > > > > > fpga- > > > > > > > > mgr.txt > > > > > > > > @@ -7,6 +7,10 @@ Required properties: > > > > > > > > - The second index is for writing FPGA > > > > > > > > configuration data. > > > > > > > > - resets : Phandle and reset specifier for the > > > > > > > > device's > > > > > > > > reset. > > > > > > > > - clocks : Clocks used by the device. > > > > > > > > +- altr,bitstream_periph : File name for FPGA > > > > > > > > peripheral > > > > > > > > raw > > > > > > > > binary > > > > > > > > which is used > > > > > > > > + to initialize FPGA IOs, PLL, > > > > > > > > IO48 > > > > > > > > and > > > > > > > > DDR. > > > > > > > > +- altr,bitstream_core : File name for core raw binary > > > > > > > > which > > > > > > > > contains FPGA design > > > > > > > > + which is used to program FPGA > > > > > > > > CRAM > > > > > > > > and > > > > > > > > ERAM. > > > > > > > bitstream- instead of bitstream_ > > > > > > Noted. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > btw can we get something that works with full bitstream > > > > > > > too ? > > > > > > This patchset actually support the full bitstream too, > > > > > > unfortunately it > > > > > > is blocked by hardware MPFE issue. The patchset for the > > > > > > MPFE > > > > > > workaround > > > > > > would come after this patchset. I would advice to use the > > > > > > early > > > > > > IO > > > > > > release method for the sake of performance. > > > > > > > > > > > > For details of issue, you can read the from the link https: > > > > > > //gi > > > > > > thub > > > > > > .com > > > > > > /altera-opensource/u-boot- > > > > > > socfpga/commits/socfpga_v2014.10_arria10_brin > > > > > > gup > > > > > > FogBugz #410989-6: Masking hardware sequenced warm reset > > > > > > for > > > > > > logic > > > > > > in… … > > > > > Does that work on ES2 ? I don't think so ... > > > > Why you think it doesn't work, using early IO or full rbf? The > > > > bitstream limitation? What you see from the print out? > > > ES2 can only use full RBF, I don't think this is handled in this > > > patchset at all. > > i did testing the full rbf loading, but in the end i removed that > > portion of codes because it stuck in DDR calibration due to MPFE HW > > issue. So, i would put back that portion of codes after MPFE HW > > workaround. My plan is to let early IO release up 1st. > Can you describe that workaround ? The code worked on the A10ES2 kit > I > have back around v2018.09, so what's the problem ? > > > > > Actually ES2 board also support early IO release, just you need > > ACDS > > and SOCEDS version 17.1 onward to rebuild your hardware, and > > choosing > > the early IO release setting inside the tool. We can discuss this > > more > > if you need our help for early IO release RBFs. > I do, otherwise I won't be able to test anything, so make sure this > is > supported. Great, i would send out seprate email discussion with you, and inviting our aplication and hardware engineer into the pool. By the way, how you get the full rbf or you build it yourself? Do you have the hardware design? What are the tools you have? what version? >
On 11/28/2018 03:49 PM, Chee, Tien Fong wrote: > On Tue, 2018-11-27 at 13:07 +0100, Marek Vasut wrote: >> On 11/27/2018 09:45 AM, Chee, Tien Fong wrote: >>> >>> On Mon, 2018-11-26 at 12:15 +0100, Marek Vasut wrote: >>>> >>>> On 11/26/2018 10:44 AM, Chee, Tien Fong wrote: >>>>> >>>>> >>>>> On Fri, 2018-11-23 at 13:23 +0100, Marek Vasut wrote: >>>>>> >>>>>> >>>>>> On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On 11/21/2018 11:41 AM, tien.fong.chee@intel.com wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> From: Tien Fong Chee <tien.fong.chee@intel.com> >>>>>>>>> >>>>>>>>> This patch adds description on properties about file >>>>>>>>> name >>>>>>>>> used >>>>>>>>> for >>>>>>>>> both >>>>>>>>> peripheral bitstream and core bitstream. >>>>>>>>> >>>>>>>>> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com >>>>>>>>>> >>>>>>>>> --- >>>>>>>>> .../fpga/altera-socfpga-a10-fpga- >>>>>>>>> mgr.txt | 6 >>>>>>>>> ++++++ >>>>>>>>> 1 files changed, 6 insertions(+), 0 deletions(-) >>>>>>>>> >>>>>>>>> diff --git a/doc/device-tree-bindings/fpga/altera- >>>>>>>>> socfpga- >>>>>>>>> a10- >>>>>>>>> fpga- >>>>>>>>> mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga- >>>>>>>>> a10- >>>>>>>>> fpga- >>>>>>>>> mgr.txt >>>>>>>>> index 2fd8e7a..010322a 100644 >>>>>>>>> --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10- >>>>>>>>> fpga- >>>>>>>>> mgr.txt >>>>>>>>> +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10- >>>>>>>>> fpga- >>>>>>>>> mgr.txt >>>>>>>>> @@ -7,6 +7,10 @@ Required properties: >>>>>>>>> - The second index is for writing FPGA >>>>>>>>> configuration data. >>>>>>>>> - resets : Phandle and reset specifier for the >>>>>>>>> device's >>>>>>>>> reset. >>>>>>>>> - clocks : Clocks used by the device. >>>>>>>>> +- altr,bitstream_periph : File name for FPGA >>>>>>>>> peripheral >>>>>>>>> raw >>>>>>>>> binary >>>>>>>>> which is used >>>>>>>>> + to initialize FPGA IOs, PLL, >>>>>>>>> IO48 >>>>>>>>> and >>>>>>>>> DDR. >>>>>>>>> +- altr,bitstream_core : File name for core raw binary >>>>>>>>> which >>>>>>>>> contains FPGA design >>>>>>>>> + which is used to program FPGA >>>>>>>>> CRAM >>>>>>>>> and >>>>>>>>> ERAM. >>>>>>>> bitstream- instead of bitstream_ >>>>>>> Noted. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> btw can we get something that works with full bitstream >>>>>>>> too ? >>>>>>> This patchset actually support the full bitstream too, >>>>>>> unfortunately it >>>>>>> is blocked by hardware MPFE issue. The patchset for the >>>>>>> MPFE >>>>>>> workaround >>>>>>> would come after this patchset. I would advice to use the >>>>>>> early >>>>>>> IO >>>>>>> release method for the sake of performance. >>>>>>> >>>>>>> For details of issue, you can read the from the link https: >>>>>>> //gi >>>>>>> thub >>>>>>> .com >>>>>>> /altera-opensource/u-boot- >>>>>>> socfpga/commits/socfpga_v2014.10_arria10_brin >>>>>>> gup >>>>>>> FogBugz #410989-6: Masking hardware sequenced warm reset >>>>>>> for >>>>>>> logic >>>>>>> in… … >>>>>> Does that work on ES2 ? I don't think so ... >>>>> Why you think it doesn't work, using early IO or full rbf? The >>>>> bitstream limitation? What you see from the print out? >>>> ES2 can only use full RBF, I don't think this is handled in this >>>> patchset at all. >>> i did testing the full rbf loading, but in the end i removed that >>> portion of codes because it stuck in DDR calibration due to MPFE HW >>> issue. So, i would put back that portion of codes after MPFE HW >>> workaround. My plan is to let early IO release up 1st. >> Can you describe that workaround ? The code worked on the A10ES2 kit >> I >> have back around v2018.09, so what's the problem ? >> >>> >>> Actually ES2 board also support early IO release, just you need >>> ACDS >>> and SOCEDS version 17.1 onward to rebuild your hardware, and >>> choosing >>> the early IO release setting inside the tool. We can discuss this >>> more >>> if you need our help for early IO release RBFs. >> I do, otherwise I won't be able to test anything, so make sure this >> is >> supported. > Great, i would send out seprate email discussion with you, and inviting > our aplication and hardware engineer into the pool. > > By the way, how you get the full rbf or you build it yourself? Do you > have the hardware design? What are the tools you have? what version? I'm using the GHRD from altera wiki.
On Wed, 2018-11-28 at 16:10 +0100, Marek Vasut wrote: > On 11/28/2018 03:49 PM, Chee, Tien Fong wrote: > > > > On Tue, 2018-11-27 at 13:07 +0100, Marek Vasut wrote: > > > > > > On 11/27/2018 09:45 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > On Mon, 2018-11-26 at 12:15 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > On 11/26/2018 10:44 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 2018-11-23 at 13:23 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/21/2018 11:41 AM, tien.fong.chee@intel.com > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > > > > > > > > > > > > > This patch adds description on properties about > > > > > > > > > > file > > > > > > > > > > name > > > > > > > > > > used > > > > > > > > > > for > > > > > > > > > > both > > > > > > > > > > peripheral bitstream and core bitstream. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel > > > > > > > > > > .com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > .../fpga/altera-socfpga-a10-fpga- > > > > > > > > > > mgr.txt | 6 > > > > > > > > > > ++++++ > > > > > > > > > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > > > > > > > > > > > > > > > > > diff --git a/doc/device-tree-bindings/fpga/altera- > > > > > > > > > > socfpga- > > > > > > > > > > a10- > > > > > > > > > > fpga- > > > > > > > > > > mgr.txt b/doc/device-tree-bindings/fpga/altera- > > > > > > > > > > socfpga- > > > > > > > > > > a10- > > > > > > > > > > fpga- > > > > > > > > > > mgr.txt > > > > > > > > > > index 2fd8e7a..010322a 100644 > > > > > > > > > > --- a/doc/device-tree-bindings/fpga/altera-socfpga- > > > > > > > > > > a10- > > > > > > > > > > fpga- > > > > > > > > > > mgr.txt > > > > > > > > > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga- > > > > > > > > > > a10- > > > > > > > > > > fpga- > > > > > > > > > > mgr.txt > > > > > > > > > > @@ -7,6 +7,10 @@ Required properties: > > > > > > > > > > - The second index is for writing > > > > > > > > > > FPGA > > > > > > > > > > configuration data. > > > > > > > > > > - resets : Phandle and reset specifier for the > > > > > > > > > > device's > > > > > > > > > > reset. > > > > > > > > > > - clocks : Clocks used by the device. > > > > > > > > > > +- altr,bitstream_periph : File name for FPGA > > > > > > > > > > peripheral > > > > > > > > > > raw > > > > > > > > > > binary > > > > > > > > > > which is used > > > > > > > > > > + to initialize FPGA IOs, > > > > > > > > > > PLL, > > > > > > > > > > IO48 > > > > > > > > > > and > > > > > > > > > > DDR. > > > > > > > > > > +- altr,bitstream_core : File name for core raw > > > > > > > > > > binary > > > > > > > > > > which > > > > > > > > > > contains FPGA design > > > > > > > > > > + which is used to program > > > > > > > > > > FPGA > > > > > > > > > > CRAM > > > > > > > > > > and > > > > > > > > > > ERAM. > > > > > > > > > bitstream- instead of bitstream_ > > > > > > > > Noted. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > btw can we get something that works with full > > > > > > > > > bitstream > > > > > > > > > too ? > > > > > > > > This patchset actually support the full bitstream too, > > > > > > > > unfortunately it > > > > > > > > is blocked by hardware MPFE issue. The patchset for the > > > > > > > > MPFE > > > > > > > > workaround > > > > > > > > would come after this patchset. I would advice to use > > > > > > > > the > > > > > > > > early > > > > > > > > IO > > > > > > > > release method for the sake of performance. > > > > > > > > > > > > > > > > For details of issue, you can read the from the > > > > > > > > link https: > > > > > > > > //gi > > > > > > > > thub > > > > > > > > .com > > > > > > > > /altera-opensource/u-boot- > > > > > > > > socfpga/commits/socfpga_v2014.10_arria10_brin > > > > > > > > gup > > > > > > > > FogBugz #410989-6: Masking hardware sequenced warm > > > > > > > > reset > > > > > > > > for > > > > > > > > logic > > > > > > > > in… … > > > > > > > Does that work on ES2 ? I don't think so ... > > > > > > Why you think it doesn't work, using early IO or full rbf? > > > > > > The > > > > > > bitstream limitation? What you see from the print out? > > > > > ES2 can only use full RBF, I don't think this is handled in > > > > > this > > > > > patchset at all. > > > > i did testing the full rbf loading, but in the end i removed > > > > that > > > > portion of codes because it stuck in DDR calibration due to > > > > MPFE HW > > > > issue. So, i would put back that portion of codes after MPFE HW > > > > workaround. My plan is to let early IO release up 1st. > > > Can you describe that workaround ? The code worked on the A10ES2 > > > kit > > > I > > > have back around v2018.09, so what's the problem ? > > > > > > > > > > > > > > > Actually ES2 board also support early IO release, just you need > > > > ACDS > > > > and SOCEDS version 17.1 onward to rebuild your hardware, and > > > > choosing > > > > the early IO release setting inside the tool. We can discuss > > > > this > > > > more > > > > if you need our help for early IO release RBFs. > > > I do, otherwise I won't be able to test anything, so make sure > > > this > > > is > > > supported. > > Great, i would send out seprate email discussion with you, and > > inviting > > our aplication and hardware engineer into the pool. > > > > By the way, how you get the full rbf or you build it yourself? Do > > you > > have the hardware design? What are the tools you have? what > > version? > I'm using the GHRD from altera wiki. Do you have the link? >
On Wed, 2018-11-28 at 16:10 +0100, Marek Vasut wrote: > On 11/28/2018 03:49 PM, Chee, Tien Fong wrote: > > > > On Tue, 2018-11-27 at 13:07 +0100, Marek Vasut wrote: > > > > > > On 11/27/2018 09:45 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > On Mon, 2018-11-26 at 12:15 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > On 11/26/2018 10:44 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 2018-11-23 at 13:23 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/21/2018 11:41 AM, tien.fong.chee@intel.com > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > > > > > > > > > > > > > This patch adds description on properties about > > > > > > > > > > file > > > > > > > > > > name > > > > > > > > > > used > > > > > > > > > > for > > > > > > > > > > both > > > > > > > > > > peripheral bitstream and core bitstream. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel > > > > > > > > > > .com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > .../fpga/altera-socfpga-a10-fpga- > > > > > > > > > > mgr.txt | 6 > > > > > > > > > > ++++++ > > > > > > > > > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > > > > > > > > > > > > > > > > > diff --git a/doc/device-tree-bindings/fpga/altera- > > > > > > > > > > socfpga- > > > > > > > > > > a10- > > > > > > > > > > fpga- > > > > > > > > > > mgr.txt b/doc/device-tree-bindings/fpga/altera- > > > > > > > > > > socfpga- > > > > > > > > > > a10- > > > > > > > > > > fpga- > > > > > > > > > > mgr.txt > > > > > > > > > > index 2fd8e7a..010322a 100644 > > > > > > > > > > --- a/doc/device-tree-bindings/fpga/altera-socfpga- > > > > > > > > > > a10- > > > > > > > > > > fpga- > > > > > > > > > > mgr.txt > > > > > > > > > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga- > > > > > > > > > > a10- > > > > > > > > > > fpga- > > > > > > > > > > mgr.txt > > > > > > > > > > @@ -7,6 +7,10 @@ Required properties: > > > > > > > > > > - The second index is for writing > > > > > > > > > > FPGA > > > > > > > > > > configuration data. > > > > > > > > > > - resets : Phandle and reset specifier for the > > > > > > > > > > device's > > > > > > > > > > reset. > > > > > > > > > > - clocks : Clocks used by the device. > > > > > > > > > > +- altr,bitstream_periph : File name for FPGA > > > > > > > > > > peripheral > > > > > > > > > > raw > > > > > > > > > > binary > > > > > > > > > > which is used > > > > > > > > > > + to initialize FPGA IOs, > > > > > > > > > > PLL, > > > > > > > > > > IO48 > > > > > > > > > > and > > > > > > > > > > DDR. > > > > > > > > > > +- altr,bitstream_core : File name for core raw > > > > > > > > > > binary > > > > > > > > > > which > > > > > > > > > > contains FPGA design > > > > > > > > > > + which is used to program > > > > > > > > > > FPGA > > > > > > > > > > CRAM > > > > > > > > > > and > > > > > > > > > > ERAM. > > > > > > > > > bitstream- instead of bitstream_ > > > > > > > > Noted. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > btw can we get something that works with full > > > > > > > > > bitstream > > > > > > > > > too ? > > > > > > > > This patchset actually support the full bitstream too, > > > > > > > > unfortunately it > > > > > > > > is blocked by hardware MPFE issue. The patchset for the > > > > > > > > MPFE > > > > > > > > workaround > > > > > > > > would come after this patchset. I would advice to use > > > > > > > > the > > > > > > > > early > > > > > > > > IO > > > > > > > > release method for the sake of performance. > > > > > > > > > > > > > > > > For details of issue, you can read the from the > > > > > > > > link https: > > > > > > > > //gi > > > > > > > > thub > > > > > > > > .com > > > > > > > > /altera-opensource/u-boot- > > > > > > > > socfpga/commits/socfpga_v2014.10_arria10_brin > > > > > > > > gup > > > > > > > > FogBugz #410989-6: Masking hardware sequenced warm > > > > > > > > reset > > > > > > > > for > > > > > > > > logic > > > > > > > > in… … > > > > > > > Does that work on ES2 ? I don't think so ... > > > > > > Why you think it doesn't work, using early IO or full rbf? > > > > > > The > > > > > > bitstream limitation? What you see from the print out? > > > > > ES2 can only use full RBF, I don't think this is handled in > > > > > this > > > > > patchset at all. > > > > i did testing the full rbf loading, but in the end i removed > > > > that > > > > portion of codes because it stuck in DDR calibration due to > > > > MPFE HW > > > > issue. So, i would put back that portion of codes after MPFE HW > > > > workaround. My plan is to let early IO release up 1st. > > > Can you describe that workaround ? The code worked on the A10ES2 > > > kit > > > I > > > have back around v2018.09, so what's the problem ? There is a corruption to MPFE NoC(which function like ethernet QOS, but its main function for priotizing and controlling traffic to access DDR from MPU and FPGA) due to high fequency transient clock out from HPS EMIF IOPLL at VCO startup. The corruption happens intermittent on some boards. The workaround is to trigger warm reset to recover MPFE NoC from corruption after programing the periph rbf or full rbf. Once U- Boot reentrance after warm reset, only core rbf is allowed to configured FPGA. > > > > > > > > > > > > > > > Actually ES2 board also support early IO release, just you need > > > > ACDS > > > > and SOCEDS version 17.1 onward to rebuild your hardware, and > > > > choosing > > > > the early IO release setting inside the tool. We can discuss > > > > this > > > > more > > > > if you need our help for early IO release RBFs. > > > I do, otherwise I won't be able to test anything, so make sure > > > this > > > is > > > supported. > > Great, i would send out seprate email discussion with you, and > > inviting > > our aplication and hardware engineer into the pool. > > > > By the way, how you get the full rbf or you build it yourself? Do > > you > > have the hardware design? What are the tools you have? what > > version? > I'm using the GHRD from altera wiki. >
On 11/28/2018 05:17 PM, Chee, Tien Fong wrote: > On Wed, 2018-11-28 at 16:10 +0100, Marek Vasut wrote: >> On 11/28/2018 03:49 PM, Chee, Tien Fong wrote: >>> >>> On Tue, 2018-11-27 at 13:07 +0100, Marek Vasut wrote: >>>> >>>> On 11/27/2018 09:45 AM, Chee, Tien Fong wrote: >>>>> >>>>> >>>>> On Mon, 2018-11-26 at 12:15 +0100, Marek Vasut wrote: >>>>>> >>>>>> >>>>>> On 11/26/2018 10:44 AM, Chee, Tien Fong wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, 2018-11-23 at 13:23 +0100, Marek Vasut wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 11/21/2018 11:41 AM, tien.fong.chee@intel.com >>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> From: Tien Fong Chee <tien.fong.chee@intel.com> >>>>>>>>>>> >>>>>>>>>>> This patch adds description on properties about >>>>>>>>>>> file >>>>>>>>>>> name >>>>>>>>>>> used >>>>>>>>>>> for >>>>>>>>>>> both >>>>>>>>>>> peripheral bitstream and core bitstream. >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel >>>>>>>>>>> .com >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> --- >>>>>>>>>>> .../fpga/altera-socfpga-a10-fpga- >>>>>>>>>>> mgr.txt | 6 >>>>>>>>>>> ++++++ >>>>>>>>>>> 1 files changed, 6 insertions(+), 0 deletions(-) >>>>>>>>>>> >>>>>>>>>>> diff --git a/doc/device-tree-bindings/fpga/altera- >>>>>>>>>>> socfpga- >>>>>>>>>>> a10- >>>>>>>>>>> fpga- >>>>>>>>>>> mgr.txt b/doc/device-tree-bindings/fpga/altera- >>>>>>>>>>> socfpga- >>>>>>>>>>> a10- >>>>>>>>>>> fpga- >>>>>>>>>>> mgr.txt >>>>>>>>>>> index 2fd8e7a..010322a 100644 >>>>>>>>>>> --- a/doc/device-tree-bindings/fpga/altera-socfpga- >>>>>>>>>>> a10- >>>>>>>>>>> fpga- >>>>>>>>>>> mgr.txt >>>>>>>>>>> +++ b/doc/device-tree-bindings/fpga/altera-socfpga- >>>>>>>>>>> a10- >>>>>>>>>>> fpga- >>>>>>>>>>> mgr.txt >>>>>>>>>>> @@ -7,6 +7,10 @@ Required properties: >>>>>>>>>>> - The second index is for writing >>>>>>>>>>> FPGA >>>>>>>>>>> configuration data. >>>>>>>>>>> - resets : Phandle and reset specifier for the >>>>>>>>>>> device's >>>>>>>>>>> reset. >>>>>>>>>>> - clocks : Clocks used by the device. >>>>>>>>>>> +- altr,bitstream_periph : File name for FPGA >>>>>>>>>>> peripheral >>>>>>>>>>> raw >>>>>>>>>>> binary >>>>>>>>>>> which is used >>>>>>>>>>> + to initialize FPGA IOs, >>>>>>>>>>> PLL, >>>>>>>>>>> IO48 >>>>>>>>>>> and >>>>>>>>>>> DDR. >>>>>>>>>>> +- altr,bitstream_core : File name for core raw >>>>>>>>>>> binary >>>>>>>>>>> which >>>>>>>>>>> contains FPGA design >>>>>>>>>>> + which is used to program >>>>>>>>>>> FPGA >>>>>>>>>>> CRAM >>>>>>>>>>> and >>>>>>>>>>> ERAM. >>>>>>>>>> bitstream- instead of bitstream_ >>>>>>>>> Noted. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> btw can we get something that works with full >>>>>>>>>> bitstream >>>>>>>>>> too ? >>>>>>>>> This patchset actually support the full bitstream too, >>>>>>>>> unfortunately it >>>>>>>>> is blocked by hardware MPFE issue. The patchset for the >>>>>>>>> MPFE >>>>>>>>> workaround >>>>>>>>> would come after this patchset. I would advice to use >>>>>>>>> the >>>>>>>>> early >>>>>>>>> IO >>>>>>>>> release method for the sake of performance. >>>>>>>>> >>>>>>>>> For details of issue, you can read the from the >>>>>>>>> link https: >>>>>>>>> //gi >>>>>>>>> thub >>>>>>>>> .com >>>>>>>>> /altera-opensource/u-boot- >>>>>>>>> socfpga/commits/socfpga_v2014.10_arria10_brin >>>>>>>>> gup >>>>>>>>> FogBugz #410989-6: Masking hardware sequenced warm >>>>>>>>> reset >>>>>>>>> for >>>>>>>>> logic >>>>>>>>> in… … >>>>>>>> Does that work on ES2 ? I don't think so ... >>>>>>> Why you think it doesn't work, using early IO or full rbf? >>>>>>> The >>>>>>> bitstream limitation? What you see from the print out? >>>>>> ES2 can only use full RBF, I don't think this is handled in >>>>>> this >>>>>> patchset at all. >>>>> i did testing the full rbf loading, but in the end i removed >>>>> that >>>>> portion of codes because it stuck in DDR calibration due to >>>>> MPFE HW >>>>> issue. So, i would put back that portion of codes after MPFE HW >>>>> workaround. My plan is to let early IO release up 1st. >>>> Can you describe that workaround ? The code worked on the A10ES2 >>>> kit >>>> I >>>> have back around v2018.09, so what's the problem ? > There is a corruption to MPFE NoC(which function like ethernet QOS, but > its main function for priotizing and controlling traffic to access DDR > from MPU and FPGA) due to high fequency transient clock out from HPS > EMIF IOPLL at VCO startup. The corruption happens intermittent on some > boards. The workaround is to trigger warm reset to recover MPFE NoC > from corruption after programing the periph rbf or full rbf. Once U- > Boot reentrance after warm reset, only core rbf is allowed to > configured FPGA. And this is present in ES1 or ES2 ? Or is it also in PS ? I wonder whether we want to scrap the ES support afterall.
On Wed, 2018-11-28 at 18:55 +0100, Marek Vasut wrote: > On 11/28/2018 05:17 PM, Chee, Tien Fong wrote: > > > > On Wed, 2018-11-28 at 16:10 +0100, Marek Vasut wrote: > > > > > > On 11/28/2018 03:49 PM, Chee, Tien Fong wrote: > > > > > > > > > > > > On Tue, 2018-11-27 at 13:07 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > On 11/27/2018 09:45 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Mon, 2018-11-26 at 12:15 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/26/2018 10:44 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 2018-11-23 at 13:23 +0100, Marek Vasut wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/23/2018 10:19 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 2018-11-21 at 15:11 +0100, Marek Vasut > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/21/2018 11:41 AM, tien.fong.chee@intel.com > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > > > > > > > > > > > > > > > > > This patch adds description on properties about > > > > > > > > > > > > file > > > > > > > > > > > > name > > > > > > > > > > > > used > > > > > > > > > > > > for > > > > > > > > > > > > both > > > > > > > > > > > > peripheral bitstream and core bitstream. > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@i > > > > > > > > > > > > ntel > > > > > > > > > > > > .com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > > > .../fpga/altera-socfpga-a10-fpga- > > > > > > > > > > > > mgr.txt | 6 > > > > > > > > > > > > ++++++ > > > > > > > > > > > > 1 files changed, 6 insertions(+), 0 > > > > > > > > > > > > deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/doc/device-tree- > > > > > > > > > > > > bindings/fpga/altera- > > > > > > > > > > > > socfpga- > > > > > > > > > > > > a10- > > > > > > > > > > > > fpga- > > > > > > > > > > > > mgr.txt b/doc/device-tree-bindings/fpga/altera- > > > > > > > > > > > > socfpga- > > > > > > > > > > > > a10- > > > > > > > > > > > > fpga- > > > > > > > > > > > > mgr.txt > > > > > > > > > > > > index 2fd8e7a..010322a 100644 > > > > > > > > > > > > --- a/doc/device-tree-bindings/fpga/altera- > > > > > > > > > > > > socfpga- > > > > > > > > > > > > a10- > > > > > > > > > > > > fpga- > > > > > > > > > > > > mgr.txt > > > > > > > > > > > > +++ b/doc/device-tree-bindings/fpga/altera- > > > > > > > > > > > > socfpga- > > > > > > > > > > > > a10- > > > > > > > > > > > > fpga- > > > > > > > > > > > > mgr.txt > > > > > > > > > > > > @@ -7,6 +7,10 @@ Required properties: > > > > > > > > > > > > - The second index is for > > > > > > > > > > > > writing > > > > > > > > > > > > FPGA > > > > > > > > > > > > configuration data. > > > > > > > > > > > > - resets : Phandle and reset specifier for > > > > > > > > > > > > the > > > > > > > > > > > > device's > > > > > > > > > > > > reset. > > > > > > > > > > > > - clocks : Clocks used by the device. > > > > > > > > > > > > +- altr,bitstream_periph : File name for FPGA > > > > > > > > > > > > peripheral > > > > > > > > > > > > raw > > > > > > > > > > > > binary > > > > > > > > > > > > which is used > > > > > > > > > > > > + to initialize FPGA > > > > > > > > > > > > IOs, > > > > > > > > > > > > PLL, > > > > > > > > > > > > IO48 > > > > > > > > > > > > and > > > > > > > > > > > > DDR. > > > > > > > > > > > > +- altr,bitstream_core : File name for core raw > > > > > > > > > > > > binary > > > > > > > > > > > > which > > > > > > > > > > > > contains FPGA design > > > > > > > > > > > > + which is used to > > > > > > > > > > > > program > > > > > > > > > > > > FPGA > > > > > > > > > > > > CRAM > > > > > > > > > > > > and > > > > > > > > > > > > ERAM. > > > > > > > > > > > bitstream- instead of bitstream_ > > > > > > > > > > Noted. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > btw can we get something that works with full > > > > > > > > > > > bitstream > > > > > > > > > > > too ? > > > > > > > > > > This patchset actually support the full bitstream > > > > > > > > > > too, > > > > > > > > > > unfortunately it > > > > > > > > > > is blocked by hardware MPFE issue. The patchset for > > > > > > > > > > the > > > > > > > > > > MPFE > > > > > > > > > > workaround > > > > > > > > > > would come after this patchset. I would advice to > > > > > > > > > > use > > > > > > > > > > the > > > > > > > > > > early > > > > > > > > > > IO > > > > > > > > > > release method for the sake of performance. > > > > > > > > > > > > > > > > > > > > For details of issue, you can read the from the > > > > > > > > > > link https: > > > > > > > > > > //gi > > > > > > > > > > thub > > > > > > > > > > .com > > > > > > > > > > /altera-opensource/u-boot- > > > > > > > > > > socfpga/commits/socfpga_v2014.10_arria10_brin > > > > > > > > > > gup > > > > > > > > > > FogBugz #410989-6: Masking hardware sequenced warm > > > > > > > > > > reset > > > > > > > > > > for > > > > > > > > > > logic > > > > > > > > > > in… … > > > > > > > > > Does that work on ES2 ? I don't think so ... > > > > > > > > Why you think it doesn't work, using early IO or full > > > > > > > > rbf? > > > > > > > > The > > > > > > > > bitstream limitation? What you see from the print out? > > > > > > > ES2 can only use full RBF, I don't think this is handled > > > > > > > in > > > > > > > this > > > > > > > patchset at all. > > > > > > i did testing the full rbf loading, but in the end i > > > > > > removed > > > > > > that > > > > > > portion of codes because it stuck in DDR calibration due to > > > > > > MPFE HW > > > > > > issue. So, i would put back that portion of codes after > > > > > > MPFE HW > > > > > > workaround. My plan is to let early IO release up 1st. > > > > > Can you describe that workaround ? The code worked on the > > > > > A10ES2 > > > > > kit > > > > > I > > > > > have back around v2018.09, so what's the problem ? > > There is a corruption to MPFE NoC(which function like ethernet QOS, > > but > > its main function for priotizing and controlling traffic to access > > DDR > > from MPU and FPGA) due to high fequency transient clock out from > > HPS > > EMIF IOPLL at VCO startup. The corruption happens intermittent on > > some > > boards. The workaround is to trigger warm reset to recover MPFE NoC > > from corruption after programing the periph rbf or full rbf. Once > > U- > > Boot reentrance after warm reset, only core rbf is allowed to > > configured FPGA. > And this is present in ES1 or ES2 ? Or is it also in PS ? I have no idea would this present in ES1 or ES2, but this happened in some PS. > > I wonder whether we want to scrap the ES support afterall. We actually no longer support ES. >
diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt index 2fd8e7a..010322a 100644 --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt @@ -7,6 +7,10 @@ Required properties: - The second index is for writing FPGA configuration data. - resets : Phandle and reset specifier for the device's reset. - clocks : Clocks used by the device. +- altr,bitstream_periph : File name for FPGA peripheral raw binary which is used + to initialize FPGA IOs, PLL, IO48 and DDR. +- altr,bitstream_core : File name for core raw binary which contains FPGA design + which is used to program FPGA CRAM and ERAM. Example: @@ -16,4 +20,6 @@ Example: 0xffcfe400 0x20>; clocks = <&l4_mp_clk>; resets = <&rst FPGAMGR_RESET>; + altr,bitstream_periph = "ghrd_10as066n2.periph.rbf.mkimage"; + altr,bitstream_core = "ghrd_10as066n2.core.rbf.mkimage"; };