diff mbox series

[U-Boot] ARM: dts: am33xx: fix SLEWCTRL_FAST pinctrl binding

Message ID 1534863849-10930-1-git-send-email-Christian.Amann@de.bosch.com
State Accepted
Commit 73e4ba98689e53c0d5c5e1155c10b7a5ca6d2c29
Delegated to: Tom Rini
Headers show
Series [U-Boot] ARM: dts: am33xx: fix SLEWCTRL_FAST pinctrl binding | expand

Commit Message

Christian.Amann@de.bosch.com Aug. 21, 2018, 3:04 p.m. UTC 
From: Christian Amann <Christian.Amann@de.bosch.com>

Copy missing Kernel patch to make SLEWCTRL_SLOW available in device tree
and to correct the value of SLEWCTRL_FAST.
After this patch, the Kernel and U-boot device tree settings for
SLEWCTRL have the same effect.

Original Kernel patch message:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=424e0f039bfa8a51fb5c5178b6ece8baa4996469

"
According to AM335x TRM, Document spruh73l, Revised February 2015,
Section 9.2.2 Pad Control Registers, setting bit 6 of the pad control
registers actually sets the SLEWCTRL value to slow rather than fast as
the current macro indicates. Introduce a new macro, SLEWCTRL_SLOW, that
sets the bit, and modify SLEWCTRL_FAST to 0 but keep it for
completeness. Current users of the macro (i2c and mdio) are left
unmodified as SLEWCTRL_FAST was the macro used and actual desired state.
Tested on am335x-gp-evm with no difference in software performance seen.
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
"

Signed-off-by: Christian Amann <Christian.Amann@de.bosch.com>
---
 include/dt-bindings/pinctrl/am33xx.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Tom Rini Aug. 24, 2018, 8:10 p.m. UTC | #1 
On Tue, Aug 21, 2018 at 05:04:09PM +0200, Christian.Amann@de.bosch.com wrote:

> From: Christian Amann <Christian.Amann@de.bosch.com>
> 
> Copy missing Kernel patch to make SLEWCTRL_SLOW available in device tree
> and to correct the value of SLEWCTRL_FAST.
> After this patch, the Kernel and U-boot device tree settings for
> SLEWCTRL have the same effect.
> 
> Original Kernel patch message:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=424e0f039bfa8a51fb5c5178b6ece8baa4996469
> 
> "
> According to AM335x TRM, Document spruh73l, Revised February 2015,
> Section 9.2.2 Pad Control Registers, setting bit 6 of the pad control
> registers actually sets the SLEWCTRL value to slow rather than fast as
> the current macro indicates. Introduce a new macro, SLEWCTRL_SLOW, that
> sets the bit, and modify SLEWCTRL_FAST to 0 but keep it for
> completeness. Current users of the macro (i2c and mdio) are left
> unmodified as SLEWCTRL_FAST was the macro used and actual desired state.
> Tested on am335x-gp-evm with no difference in software performance seen.
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> "
> 
> Signed-off-by: Christian Amann <Christian.Amann@de.bosch.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/dt-bindings/pinctrl/am33xx.h b/include/dt-bindings/pinctrl/am33xx.h
index 2fbc804..226f772 100644
--- a/include/dt-bindings/pinctrl/am33xx.h
+++ b/include/dt-bindings/pinctrl/am33xx.h
@@ -13,7 +13,8 @@ 
 
 #define PULL_DISABLE		(1 << 3)
 #define INPUT_EN		(1 << 5)
-#define SLEWCTRL_FAST		(1 << 6)
+#define SLEWCTRL_SLOW		(1 << 6)
+#define SLEWCTRL_FAST		0
 
 /* update macro depending on INPUT_EN and PULL_ENA */
 #undef PIN_OUTPUT