From patchwork Thu Jun 14 09:48:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janine Hagemann X-Patchwork-Id: 929347 X-Patchwork-Delegate: philipp.tomsich@theobroma-systems.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=phytec.de Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 4161365zFtz9s2g for ; Thu, 14 Jun 2018 21:04:18 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 6E9A1C21DD3; Thu, 14 Jun 2018 11:02:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 6466BC21DD4; Thu, 14 Jun 2018 10:53:56 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 58467C21BE5; Thu, 14 Jun 2018 09:49:33 +0000 (UTC) Received: from root.phytec.de (mail.x-arc.co.uk [217.6.246.34]) by lists.denx.de (Postfix) with ESMTP id 0B340C21D74 for ; Thu, 14 Jun 2018 09:49:33 +0000 (UTC) Received: from idefix.phytec.de (idefix.phytec.de [172.16.0.10]) by root.phytec.de (Postfix) with ESMTP id 90417A00302; Thu, 14 Jun 2018 11:49:40 +0200 (CEST) Received: from augenblix.phytec.de ([172.16.0.56]) by idefix.phytec.de (IBM Domino Release 9.0.1FP7) with ESMTP id 2018061411493251-493670 ; Thu, 14 Jun 2018 11:49:32 +0200 From: Janine Hagemann To: albert.u.boot@aribaud.net, sjg@chromium.org, philipp.tomsich@theobroma-systems.com, w.egorov@phytec.de, joe.hershberger@ni.com, u-boot@lists.denx.de Date: Thu, 14 Jun 2018 11:48:47 +0200 Message-Id: <1528969736-44037-3-git-send-email-j.hagemann@phytec.de> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1528969736-44037-1-git-send-email-j.hagemann@phytec.de> References: <1528969736-44037-1-git-send-email-j.hagemann@phytec.de> X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 9.0.1FP7|August 17, 2016) at 14.06.2018 11:49:32, Serialize by Router on Idefix/Phytec(Release 9.0.1FP7|August 17, 2016) at 14.06.2018 11:49:32, Serialize complete at 14.06.2018 11:49:32 X-TNEFEvaluated: 1 X-Mailman-Approved-At: Thu, 14 Jun 2018 10:53:51 +0000 Subject: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() to enable the RX delay. The MASK was used in a wrong way. Signed-off-by: Janine Hagemann Acked-by: Joe Hershberger Reviewed-by: Philipp Tomsich --- drivers/net/gmac_rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/gmac_rockchip.c b/drivers/net/gmac_rockchip.c index 30a24d1..0f91731 100644 --- a/drivers/net/gmac_rockchip.c +++ b/drivers/net/gmac_rockchip.c @@ -350,7 +350,7 @@ static void rk3328_gmac_set_to_rgmii(struct gmac_rockchip_platdata *pdata) RK3328_RXCLK_DLY_ENA_GMAC_MASK | RK3328_TXCLK_DLY_ENA_GMAC_MASK, RK3328_GMAC_PHY_INTF_SEL_RGMII | - RK3328_RXCLK_DLY_ENA_GMAC_MASK | + RK3328_RXCLK_DLY_ENA_GMAC_ENABLE | RK3328_TXCLK_DLY_ENA_GMAC_ENABLE); rk_clrsetreg(&grf->mac_con[0],