diff mbox series

[U-Boot,v2,5/7] rockchip: rk3128: add evb-rk3128 support

Message ID 1511776284-2703-6-git-send-email-kever.yang@rock-chips.com
State Superseded
Delegated to: Philipp Tomsich
Headers show
Series rockchip: add new SoC support for RK3128 | expand

Commit Message

Kever Yang Nov. 27, 2017, 9:51 a.m. UTC 
evb-rk3128 is an evb from Rockchip based on rk3128 SoC:
- 2 USB2.0 Host port;
- 1 HDMI port;
- 2 10/100M eth port;
- 2GB ddr;
- 16GB eMMC;
- UART to USB debug port;

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

Changes in v2:
- enable usb nodes

 arch/arm/mach-rockchip/rk3128/Kconfig  | 24 ++++++++++++++++++++++++
 board/rockchip/evb_rk3128/Kconfig      | 15 +++++++++++++++
 board/rockchip/evb_rk3128/MAINTAINERS  |  6 ++++++
 board/rockchip/evb_rk3128/Makefile     |  7 +++++++
 board/rockchip/evb_rk3128/evb-rk3128.c |  9 +++++++++
 include/configs/evb_rk3128.h           | 15 +++++++++++++++
 6 files changed, 76 insertions(+)
 create mode 100644 board/rockchip/evb_rk3128/Kconfig
 create mode 100644 board/rockchip/evb_rk3128/MAINTAINERS
 create mode 100644 board/rockchip/evb_rk3128/Makefile
 create mode 100644 board/rockchip/evb_rk3128/evb-rk3128.c
 create mode 100644 include/configs/evb_rk3128.h

Comments

Philipp Tomsich Nov. 27, 2017, 7:17 p.m. UTC | #1 
> evb-rk3128 is an evb from Rockchip based on rk3128 SoC:
> - 2 USB2.0 Host port;
> - 1 HDMI port;
> - 2 10/100M eth port;
> - 2GB ddr;
> - 16GB eMMC;
> - UART to USB debug port;
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
> Changes in v2:
> - enable usb nodes
> 
>  arch/arm/mach-rockchip/rk3128/Kconfig  | 24 ++++++++++++++++++++++++
>  board/rockchip/evb_rk3128/Kconfig      | 15 +++++++++++++++
>  board/rockchip/evb_rk3128/MAINTAINERS  |  6 ++++++
>  board/rockchip/evb_rk3128/Makefile     |  7 +++++++
>  board/rockchip/evb_rk3128/evb-rk3128.c |  9 +++++++++
>  include/configs/evb_rk3128.h           | 15 +++++++++++++++
>  6 files changed, 76 insertions(+)
>  create mode 100644 board/rockchip/evb_rk3128/Kconfig
>  create mode 100644 board/rockchip/evb_rk3128/MAINTAINERS
>  create mode 100644 board/rockchip/evb_rk3128/Makefile
>  create mode 100644 board/rockchip/evb_rk3128/evb-rk3128.c
>  create mode 100644 include/configs/evb_rk3128.h
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich Nov. 27, 2017, 7:30 p.m. UTC | #2 
On Mon, 27 Nov 2017, Kever Yang wrote:

> evb-rk3128 is an evb from Rockchip based on rk3128 SoC:
> - 2 USB2.0 Host port;
> - 1 HDMI port;
> - 2 10/100M eth port;
> - 2GB ddr;
> - 16GB eMMC;
> - UART to USB debug port;
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

See below for requested changes.

> ---
>
> Changes in v2:
> - enable usb nodes
>
> arch/arm/mach-rockchip/rk3128/Kconfig  | 24 ++++++++++++++++++++++++
> board/rockchip/evb_rk3128/Kconfig      | 15 +++++++++++++++
> board/rockchip/evb_rk3128/MAINTAINERS  |  6 ++++++
> board/rockchip/evb_rk3128/Makefile     |  7 +++++++
> board/rockchip/evb_rk3128/evb-rk3128.c |  9 +++++++++
> include/configs/evb_rk3128.h           | 15 +++++++++++++++
> 6 files changed, 76 insertions(+)
> create mode 100644 board/rockchip/evb_rk3128/Kconfig
> create mode 100644 board/rockchip/evb_rk3128/MAINTAINERS
> create mode 100644 board/rockchip/evb_rk3128/Makefile
> create mode 100644 board/rockchip/evb_rk3128/evb-rk3128.c
> create mode 100644 include/configs/evb_rk3128.h
>
> diff --git a/arch/arm/mach-rockchip/rk3128/Kconfig b/arch/arm/mach-rockchip/rk3128/Kconfig
> index e69de29..40655a2 100644
> --- a/arch/arm/mach-rockchip/rk3128/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3128/Kconfig
> @@ -0,0 +1,24 @@
> +if ROCKCHIP_RK3128
> +
> +choice
> +	prompt "RK3128 board select"
> +
> +config TARGET_EVB_RK3128
> +	bool "RK3128 evaluation board"
> +	select BOARD_LATE_INIT
> +	help
> +	  RK3128evb is a evaluation board for Rockchip rk3128,
> +	  with full function and phisical connectors support like
> +	  usb2.0 host ports, LVDS, JTAG, MAC, SDcard, HDMI, USB-2-serial...
> +
> +endchoice
> +
> +config SYS_SOC
> +	default "rockchip"
> +
> +config SYS_MALLOC_F_LEN
> +	default 0x0800
> +
> +source "board/rockchip/evb_rk3128/Kconfig"
> +
> +endif
> diff --git a/board/rockchip/evb_rk3128/Kconfig b/board/rockchip/evb_rk3128/Kconfig
> new file mode 100644
> index 0000000..5b3095a
> --- /dev/null
> +++ b/board/rockchip/evb_rk3128/Kconfig
> @@ -0,0 +1,15 @@
> +if TARGET_EVB_RK3128
> +
> +config SYS_BOARD
> +	default "evb_rk3128"
> +
> +config SYS_VENDOR
> +	default "rockchip"
> +
> +config SYS_CONFIG_NAME
> +	default "evb_rk3128"
> +
> +config BOARD_SPECIFIC_OPTIONS # dummy
> +	def_bool y
> +
> +endif
> diff --git a/board/rockchip/evb_rk3128/MAINTAINERS b/board/rockchip/evb_rk3128/MAINTAINERS
> new file mode 100644
> index 0000000..f5145d1
> --- /dev/null
> +++ b/board/rockchip/evb_rk3128/MAINTAINERS
> @@ -0,0 +1,6 @@
> +EVB-RK3128
> +M:      Kever Yang <kever.yang@rock-chips.com>
> +S:      Maintained
> +F:      board/rockchip/evb_rk3128
> +F:      include/configs/evb_rk3128.h
> +F:      configs/evb-rk3128_defconfig
> diff --git a/board/rockchip/evb_rk3128/Makefile b/board/rockchip/evb_rk3128/Makefile
> new file mode 100644
> index 0000000..6040891
> --- /dev/null
> +++ b/board/rockchip/evb_rk3128/Makefile
> @@ -0,0 +1,7 @@
> +#
> +# (C) Copyright 2017 Rockchip Electronics Co., Ltd
> +#
> +# SPDX-License-Identifier:     GPL-2.0+
> +#
> +
> +obj-y	+= evb-rk3128.o
> diff --git a/board/rockchip/evb_rk3128/evb-rk3128.c b/board/rockchip/evb_rk3128/evb-rk3128.c
> new file mode 100644
> index 0000000..bf36e25
> --- /dev/null
> +++ b/board/rockchip/evb_rk3128/evb-rk3128.c
> @@ -0,0 +1,9 @@
> +/*
> + * (C) Copyright 2017 Rockchip Electronics Co., Ltd
> + *
> + * SPDX-License-Identifier:     GPL-2.0+
> + */
> +
> +#include <common.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;

If this file is (essentially) empty, there is no point in having it.
And once this one gets removed, the 'obj-y +=' in the Makefile should also 
be changed respectively.

> diff --git a/include/configs/evb_rk3128.h b/include/configs/evb_rk3128.h
> new file mode 100644
> index 0000000..a34153a
> --- /dev/null
> +++ b/include/configs/evb_rk3128.h
> @@ -0,0 +1,15 @@
> +/*
> + * (C) Copyright 2017 Rockchip Electronics Co., Ltd
> + *
> + * SPDX-License-Identifier:     GPL-2.0+
> + */
> +
> +#ifndef __EVB_RK3128_H
> +#define __EVB_RK3128_H
> +
> +#include <configs/rk3128_common.h>
> +
> +#define CONFIG_ENV_IS_IN_MMC

This has been migrated to Kconfig, please use the defconfig for this.

> +#define CONFIG_SYS_MMC_ENV_DEV 0
> +
> +#endif
>
diff mbox series

Patch

diff --git a/arch/arm/mach-rockchip/rk3128/Kconfig b/arch/arm/mach-rockchip/rk3128/Kconfig
index e69de29..40655a2 100644
--- a/arch/arm/mach-rockchip/rk3128/Kconfig
+++ b/arch/arm/mach-rockchip/rk3128/Kconfig
@@ -0,0 +1,24 @@ 
+if ROCKCHIP_RK3128
+
+choice
+	prompt "RK3128 board select"
+
+config TARGET_EVB_RK3128
+	bool "RK3128 evaluation board"
+	select BOARD_LATE_INIT
+	help
+	  RK3128evb is a evaluation board for Rockchip rk3128,
+	  with full function and phisical connectors support like
+	  usb2.0 host ports, LVDS, JTAG, MAC, SDcard, HDMI, USB-2-serial...
+
+endchoice
+
+config SYS_SOC
+	default "rockchip"
+
+config SYS_MALLOC_F_LEN
+	default 0x0800
+
+source "board/rockchip/evb_rk3128/Kconfig"
+
+endif
diff --git a/board/rockchip/evb_rk3128/Kconfig b/board/rockchip/evb_rk3128/Kconfig
new file mode 100644
index 0000000..5b3095a
--- /dev/null
+++ b/board/rockchip/evb_rk3128/Kconfig
@@ -0,0 +1,15 @@ 
+if TARGET_EVB_RK3128
+
+config SYS_BOARD
+	default "evb_rk3128"
+
+config SYS_VENDOR
+	default "rockchip"
+
+config SYS_CONFIG_NAME
+	default "evb_rk3128"
+
+config BOARD_SPECIFIC_OPTIONS # dummy
+	def_bool y
+
+endif
diff --git a/board/rockchip/evb_rk3128/MAINTAINERS b/board/rockchip/evb_rk3128/MAINTAINERS
new file mode 100644
index 0000000..f5145d1
--- /dev/null
+++ b/board/rockchip/evb_rk3128/MAINTAINERS
@@ -0,0 +1,6 @@ 
+EVB-RK3128
+M:      Kever Yang <kever.yang@rock-chips.com>
+S:      Maintained
+F:      board/rockchip/evb_rk3128
+F:      include/configs/evb_rk3128.h
+F:      configs/evb-rk3128_defconfig
diff --git a/board/rockchip/evb_rk3128/Makefile b/board/rockchip/evb_rk3128/Makefile
new file mode 100644
index 0000000..6040891
--- /dev/null
+++ b/board/rockchip/evb_rk3128/Makefile
@@ -0,0 +1,7 @@ 
+#
+# (C) Copyright 2017 Rockchip Electronics Co., Ltd
+#
+# SPDX-License-Identifier:     GPL-2.0+
+#
+
+obj-y	+= evb-rk3128.o
diff --git a/board/rockchip/evb_rk3128/evb-rk3128.c b/board/rockchip/evb_rk3128/evb-rk3128.c
new file mode 100644
index 0000000..bf36e25
--- /dev/null
+++ b/board/rockchip/evb_rk3128/evb-rk3128.c
@@ -0,0 +1,9 @@ 
+/*
+ * (C) Copyright 2017 Rockchip Electronics Co., Ltd
+ *
+ * SPDX-License-Identifier:     GPL-2.0+
+ */
+
+#include <common.h>
+
+DECLARE_GLOBAL_DATA_PTR;
diff --git a/include/configs/evb_rk3128.h b/include/configs/evb_rk3128.h
new file mode 100644
index 0000000..a34153a
--- /dev/null
+++ b/include/configs/evb_rk3128.h
@@ -0,0 +1,15 @@ 
+/*
+ * (C) Copyright 2017 Rockchip Electronics Co., Ltd
+ *
+ * SPDX-License-Identifier:     GPL-2.0+
+ */
+
+#ifndef __EVB_RK3128_H
+#define __EVB_RK3128_H
+
+#include <configs/rk3128_common.h>
+
+#define CONFIG_ENV_IS_IN_MMC
+#define CONFIG_SYS_MMC_ENV_DEV 0
+
+#endif