diff mbox series

[U-Boot,2/6] rockchip: dts: rk3399-evb: Change the tx/rx delay value for transmission quality

Message ID 1506003471-34551-3-git-send-email-david.wu@rock-chips.com
State Superseded
Delegated to: Philipp Tomsich
Headers show
Series Add gmac support for rk3399-evb and rv1108-evb | expand

Commit Message

David Wu Sept. 21, 2017, 2:17 p.m. UTC
Give the mac controller the correct tx-delay and rx-delay value
for the rgmii mode transmission. If they are not matched, there
would be Ethernet packets lost, the net feature may not work.

Signed-off-by: David Wu <david.wu@rock-chips.com>
---

 arch/arm/dts/rk3399-evb.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Philipp Tomsich Sept. 27, 2017, 9:55 a.m. UTC | #1
> Give the mac controller the correct tx-delay and rx-delay value
> for the rgmii mode transmission. If they are not matched, there
> would be Ethernet packets lost, the net feature may not work.
> 
> Signed-off-by: David Wu <david.wu@rock-chips.com>
> ---
> 
>  arch/arm/dts/rk3399-evb.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich Oct. 6, 2017, 9:45 a.m. UTC | #2
> Give the mac controller the correct tx-delay and rx-delay value
> for the rgmii mode transmission. If they are not matched, there
> would be Ethernet packets lost, the net feature may not work.
> 
> Signed-off-by: David Wu <david.wu@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  arch/arm/dts/rk3399-evb.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3399-evb.dts b/arch/arm/dts/rk3399-evb.dts
index be0c6d9..13958b8 100644
--- a/arch/arm/dts/rk3399-evb.dts
+++ b/arch/arm/dts/rk3399-evb.dts
@@ -272,7 +272,7 @@ 
 	assigned-clock-parents = <&clkin_gmac>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&rgmii_pins>;
-	tx_delay = <0x10>;
-	rx_delay = <0x10>;
+	tx_delay = <0x28>;
+	rx_delay = <0x11>;
 	status = "okay";
 };