diff mbox

[U-Boot,v2] QE: Set QE_IRAM_READY after uploading firmware

Message ID 1502677363-47345-1-git-send-email-qiang.zhao@nxp.com
State Accepted
Delegated to: York Sun
Headers show

Commit Message

Qiang Zhao Aug. 14, 2017, 2:22 a.m. UTC 
QE_IRAM_READY should be set only after successfully uploading the
firmware.

Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2:
	- modify commit msg to make it more understandable

 drivers/qe/qe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

York Sun Sept. 13, 2017, 2:17 a.m. UTC | #1 
On 08/13/2017 07:39 PM, Zhao Qiang wrote:
> QE_IRAM_READY should be set only after successfully uploading the
> firmware.
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2:
> 	- modify commit msg to make it more understandable

Applied to fsl-qoriq master. Thanks.

York
diff mbox

Patch

diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c
index 24e764d..8151068 100644
--- a/drivers/qe/qe.c
+++ b/drivers/qe/qe.c
@@ -225,8 +225,8 @@  void u_qe_init(void)
 		flush_cache((ulong)addr, cnt * 512);
 	}
 #endif
-	u_qe_upload_firmware(addr);
-	out_be32(&qe_immr->iram.iready, QE_IRAM_READY);
+	if (!u_qe_upload_firmware(addr))
+		out_be32(&qe_immr->iram.iready, QE_IRAM_READY);
 #ifdef CONFIG_SYS_QE_FMAN_FW_IN_MMC
 	free(addr);
 #endif