diff mbox

[U-Boot,03/60] mmc: tegra: move header file to driver directory

Message ID 1461099580-3866-4-git-send-email-swarren@wwwdotorg.org
State Rejected
Delegated to: Tom Warren
Headers show

Commit Message

Stephen Warren April 19, 2016, 8:58 p.m. UTC 
From: Stephen Warren <swarren@nvidia.com>

tegra_mmc.h only contains private definitions for use inside the MMC
driver. Move it out of the global include directory since nothing needs
to access it there.

tegra_mmc.h doesn't depend on anything from <fdtdec.h>, so move that
include to the C file.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 drivers/mmc/tegra_mmc.c                                            | 3 ++-
 .../asm/arch-tegra/tegra_mmc.h => drivers/mmc/tegra_mmc_priv.h     | 7 +++----
 2 files changed, 5 insertions(+), 5 deletions(-)
 rename arch/arm/include/asm/arch-tegra/tegra_mmc.h => drivers/mmc/tegra_mmc_priv.h (98%)

Comments

Simon Glass April 20, 2016, 7:25 p.m. UTC | #1 
On 19 April 2016 at 14:58, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> tegra_mmc.h only contains private definitions for use inside the MMC
> driver. Move it out of the global include directory since nothing needs
> to access it there.
>
> tegra_mmc.h doesn't depend on anything from <fdtdec.h>, so move that
> include to the C file.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  drivers/mmc/tegra_mmc.c                                            | 3 ++-
>  .../asm/arch-tegra/tegra_mmc.h => drivers/mmc/tegra_mmc_priv.h     | 7 +++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
>  rename arch/arm/include/asm/arch-tegra/tegra_mmc.h => drivers/mmc/tegra_mmc_priv.h (98%)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/drivers/mmc/tegra_mmc.c b/drivers/mmc/tegra_mmc.c
index 23c6c2cf4583..12b14fc35d08 100644
--- a/drivers/mmc/tegra_mmc.c
+++ b/drivers/mmc/tegra_mmc.c
@@ -9,13 +9,14 @@ 
 
 #include <bouncebuf.h>
 #include <common.h>
+#include <fdtdec.h>
 #include <asm/gpio.h>
 #include <asm/io.h>
 #include <asm/arch/clock.h>
 #include <asm/arch-tegra/clk_rst.h>
 #include <asm/arch-tegra/mmc.h>
-#include <asm/arch-tegra/tegra_mmc.h>
 #include <mmc.h>
+#include "tegra_mmc_priv.h"
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/arch/arm/include/asm/arch-tegra/tegra_mmc.h b/drivers/mmc/tegra_mmc_priv.h
similarity index 98%
rename from arch/arm/include/asm/arch-tegra/tegra_mmc.h
rename to drivers/mmc/tegra_mmc_priv.h
index adc9772a3c18..3d9bcb78187c 100644
--- a/arch/arm/include/asm/arch-tegra/tegra_mmc.h
+++ b/drivers/mmc/tegra_mmc_priv.h
@@ -6,10 +6,9 @@ 
  * SPDX-License-Identifier:	GPL-2.0+
  */
 
-#ifndef __TEGRA_MMC_H_
-#define __TEGRA_MMC_H_
+#ifndef __TEGRA_MMC_PRIV_H_
+#define __TEGRA_MMC_PRIV_H_
 
-#include <fdtdec.h>
 #include <asm/gpio.h>
 
 /* for mmc_config definition */
@@ -142,4 +141,4 @@  struct mmc_host {
 	struct mmc_config cfg;	/* mmc configuration */
 };
 
-#endif	/* __TEGRA_MMC_H_ */
+#endif