| Message ID | 1460394019-3393-7-git-send-email-eric@nelint.com |
|---|---|
| State | Accepted |
| Commit | f8353033884a25bedfef20e1fcc509db38a15218 |
| Delegated to: | Tom Rini |
| Headers | show |
On 12/04/16 02:00, Eric Nelson wrote: > With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass, > the Exynos/S5P gpio driver doesn't need a custom xlate routine. > > Signed-off-by: Eric Nelson <eric@nelint.com> > Acked-by: Simon Glass <sjg@chromium.org> > --- > V2 removes the include of <dt-bindings/gpio/gpio.h> > drivers/gpio/s5p_gpio.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpio/s5p_gpio.c b/drivers/gpio/s5p_gpio.c > index 0f22b23..377fed4 100644 > --- a/drivers/gpio/s5p_gpio.c > +++ b/drivers/gpio/s5p_gpio.c > @@ -13,7 +13,6 @@ > #include <asm/io.h> > #include <asm/gpio.h> > #include <dm/device-internal.h> > -#include <dt-bindings/gpio/gpio.h> > > DECLARE_GLOBAL_DATA_PTR; > > @@ -276,22 +275,12 @@ static int exynos_gpio_get_function(struct udevice *dev, unsigned offset) > return GPIOF_FUNC; > } > > -static int exynos_gpio_xlate(struct udevice *dev, struct gpio_desc *desc, > - struct fdtdec_phandle_args *args) > -{ > - desc->offset = args->args[0]; > - desc->flags = args->args[1] & GPIO_ACTIVE_LOW ? GPIOD_ACTIVE_LOW : 0; > - > - return 0; > -} > - > static const struct dm_gpio_ops gpio_exynos_ops = { > .direction_input = exynos_gpio_direction_input, > .direction_output = exynos_gpio_direction_output, > .get_value = exynos_gpio_get_value, > .set_value = exynos_gpio_set_value, > .get_function = exynos_gpio_get_function, > - .xlate = exynos_gpio_xlate, > }; > > static int gpio_exynos_probe(struct udevice *dev) > Acked-by: Minkyu Kang <mk7.kang@samsung.com> Thanks, Minkyu Kang.
diff --git a/drivers/gpio/s5p_gpio.c b/drivers/gpio/s5p_gpio.c index 0f22b23..377fed4 100644 --- a/drivers/gpio/s5p_gpio.c +++ b/drivers/gpio/s5p_gpio.c @@ -13,7 +13,6 @@ #include <asm/io.h> #include <asm/gpio.h> #include <dm/device-internal.h> -#include <dt-bindings/gpio/gpio.h> DECLARE_GLOBAL_DATA_PTR; @@ -276,22 +275,12 @@ static int exynos_gpio_get_function(struct udevice *dev, unsigned offset) return GPIOF_FUNC; } -static int exynos_gpio_xlate(struct udevice *dev, struct gpio_desc *desc, - struct fdtdec_phandle_args *args) -{ - desc->offset = args->args[0]; - desc->flags = args->args[1] & GPIO_ACTIVE_LOW ? GPIOD_ACTIVE_LOW : 0; - - return 0; -} - static const struct dm_gpio_ops gpio_exynos_ops = { .direction_input = exynos_gpio_direction_input, .direction_output = exynos_gpio_direction_output, .get_value = exynos_gpio_get_value, .set_value = exynos_gpio_set_value, .get_function = exynos_gpio_get_function, - .xlate = exynos_gpio_xlate, }; static int gpio_exynos_probe(struct udevice *dev)