| Message ID | 1460377108-19262-5-git-send-email-dmurphy@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Joe Hershberger |
| Headers | show |
On 11.4.2016 14:18, Dan Murphy wrote: > Move the phy_interface_is_rgmii to the phy.h > file for all phy's to be able to use the API. > > This now aligns with the Linux kernel based on > commit e463d88c36d42211aa72ed76d32fb8bf37820ef1 > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > > v5 - No change > > drivers/net/phy/ti.c | 11 ----------- > include/phy.h | 11 +++++++++++ > 2 files changed, 11 insertions(+), 11 deletions(-) > Any particular reason why you haven't added Reviewed-by: tags you have already got from me and someone else? Thanks, Michal
Adding Joe On 04/11/2016 07:18 AM, Dan Murphy wrote: > Move the phy_interface_is_rgmii to the phy.h > file for all phy's to be able to use the API. > > This now aligns with the Linux kernel based on > commit e463d88c36d42211aa72ed76d32fb8bf37820ef1 > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > > v5 - No change > > drivers/net/phy/ti.c | 11 ----------- > include/phy.h | 11 +++++++++++ > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c > index b8f3ebd..b1f1ec8 100644 > --- a/drivers/net/phy/ti.c > +++ b/drivers/net/phy/ti.c > @@ -156,17 +156,6 @@ void phy_write_mmd_indirect(struct phy_device *phydev, int prtad, > phy_write(phydev, addr, MII_MMD_DATA, data); > } > > -/** > - * phy_interface_is_rgmii - Convenience function for testing if a PHY interface > - * is RGMII (all variants) > - * @phydev: the phy_device struct > - */ > -static inline bool phy_interface_is_rgmii(struct phy_device *phydev) > -{ > - return phydev->interface >= PHY_INTERFACE_MODE_RGMII && > - phydev->interface <= PHY_INTERFACE_MODE_RGMII_TXID; > -} > - > #if defined(CONFIG_DM_ETH) > /** > * dp83867_data_init - Convenience function for setting PHY specific data > diff --git a/include/phy.h b/include/phy.h > index 21459a8..7b2d1ff 100644 > --- a/include/phy.h > +++ b/include/phy.h > @@ -277,6 +277,17 @@ int get_phy_id(struct mii_dev *bus, int addr, int devad, u32 *phy_id); > */ > int phy_get_interface_by_name(const char *str); > > +/** > + * phy_interface_is_rgmii - Convenience function for testing if a PHY interface > + * is RGMII (all variants) > + * @phydev: the phy_device struct > + */ > +static inline bool phy_interface_is_rgmii(struct phy_device *phydev) > +{ > + return phydev->interface >= PHY_INTERFACE_MODE_RGMII && > + phydev->interface <= PHY_INTERFACE_MODE_RGMII_TXID; > +} > + > /* PHY UIDs for various PHYs that are referenced in external code */ > #define PHY_UID_CS4340 0x13e51002 > #define PHY_UID_TN2020 0x00a19410
diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c index b8f3ebd..b1f1ec8 100644 --- a/drivers/net/phy/ti.c +++ b/drivers/net/phy/ti.c @@ -156,17 +156,6 @@ void phy_write_mmd_indirect(struct phy_device *phydev, int prtad, phy_write(phydev, addr, MII_MMD_DATA, data); } -/** - * phy_interface_is_rgmii - Convenience function for testing if a PHY interface - * is RGMII (all variants) - * @phydev: the phy_device struct - */ -static inline bool phy_interface_is_rgmii(struct phy_device *phydev) -{ - return phydev->interface >= PHY_INTERFACE_MODE_RGMII && - phydev->interface <= PHY_INTERFACE_MODE_RGMII_TXID; -} - #if defined(CONFIG_DM_ETH) /** * dp83867_data_init - Convenience function for setting PHY specific data diff --git a/include/phy.h b/include/phy.h index 21459a8..7b2d1ff 100644 --- a/include/phy.h +++ b/include/phy.h @@ -277,6 +277,17 @@ int get_phy_id(struct mii_dev *bus, int addr, int devad, u32 *phy_id); */ int phy_get_interface_by_name(const char *str); +/** + * phy_interface_is_rgmii - Convenience function for testing if a PHY interface + * is RGMII (all variants) + * @phydev: the phy_device struct + */ +static inline bool phy_interface_is_rgmii(struct phy_device *phydev) +{ + return phydev->interface >= PHY_INTERFACE_MODE_RGMII && + phydev->interface <= PHY_INTERFACE_MODE_RGMII_TXID; +} + /* PHY UIDs for various PHYs that are referenced in external code */ #define PHY_UID_CS4340 0x13e51002 #define PHY_UID_TN2020 0x00a19410
Move the phy_interface_is_rgmii to the phy.h file for all phy's to be able to use the API. This now aligns with the Linux kernel based on commit e463d88c36d42211aa72ed76d32fb8bf37820ef1 Signed-off-by: Dan Murphy <dmurphy@ti.com> --- v5 - No change drivers/net/phy/ti.c | 11 ----------- include/phy.h | 11 +++++++++++ 2 files changed, 11 insertions(+), 11 deletions(-)