From patchwork Thu Jan 28 07:55:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shaohui xie X-Patchwork-Id: 574632 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3EF1E140BB3 for ; Thu, 28 Jan 2016 21:39:45 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 87CAF39AF; Thu, 28 Jan 2016 11:39:28 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kt88eSvd0JnR; Thu, 28 Jan 2016 11:39:28 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 5237D6212A; Thu, 28 Jan 2016 11:39:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8B4AC4BD6D for ; Thu, 28 Jan 2016 09:04:17 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oTHLu0Mi7DOm for ; Thu, 28 Jan 2016 09:04:17 +0100 (CET) X-Greylist: delayed 1053 seconds by postgrey-1.34 at theia; Thu, 28 Jan 2016 09:04:13 CET X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0080.outbound.protection.outlook.com [157.56.110.80]) by theia.denx.de (Postfix) with ESMTPS id 1A2704BAEA for ; Thu, 28 Jan 2016 09:04:13 +0100 (CET) Received: from BN3PR0301CA0019.namprd03.prod.outlook.com (10.160.180.157) by BN1PR0301MB0691.namprd03.prod.outlook.com (10.160.171.28) with Microsoft SMTP Server (TLS) id 15.1.390.13; Thu, 28 Jan 2016 08:04:11 +0000 Received: from BN1AFFO11FD022.protection.gbl (2a01:111:f400:7c10::177) by BN3PR0301CA0019.outlook.office365.com (2a01:111:e400:4000::29) with Microsoft SMTP Server (TLS) id 15.1.396.15 via Frontend Transport; Thu, 28 Jan 2016 08:04:11 +0000 Authentication-Results: spf=softfail (sender IP is 192.88.168.50) smtp.mailfrom=gmail.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=gmail.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning gmail.com discourages use of 192.88.168.50 as permitted sender) Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD022.mail.protection.outlook.com (10.58.52.82) with Microsoft SMTP Server (TLS) id 15.1.355.15 via Frontend Transport; Thu, 28 Jan 2016 08:04:11 +0000 Received: from titan.ap.freescale.net ([10.192.208.233]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u0S847Dm026478; Thu, 28 Jan 2016 01:04:09 -0700 From: To: , Date: Thu, 28 Jan 2016 15:55:46 +0800 Message-ID: <1453967746-6404-1-git-send-email-shh.xie@gmail.com> X-Mailer: git-send-email 2.1.0.27.g96db324 X-EOPAttributedMessage: 0 X-Matching-Connectors: 130984418518334021; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD022; 1:hlSVX57k1L+rRH4XwTUpEOfRrHE1sTAnW5QR/B9Fv7cwbNiELPaxWYlLrzxIB7p4XuNXXZIqdHmWtp6n/fZD+srNlJuKMin3eYQZfEYvFGehG308selyJTdekvgkfMugaprkf1Wk3koxtU26GCXxpsCpze2RxBC9ZRVU1ve/9lSoyV8rHFE9uPx/Dy/JOUGOVS5AlXgX/mn+0+BKiJh0r4VdDImJ15Snn77xkGAwdd9JjAxpLKuSf4WfYwmcbFbaMe6SeKaWmkdtQC7fRXCigr1VoC53vyyJDk3EB+XtonKWqdCCFS2gZvpgKeVzyf4TR3TLl+pU/LdOHghP5oFoQPvVNt0YhzY5D1rNQqQbtxvPhUFgQSCZWuH2vpGTu9qifrflYoY63BkDAjBmwJ2PkwpMnBkCqutOcADp3U8k86/guE7Y2KqCuOpKEffH7wVgs2V7jS8n5dJK0MfJzZceLpM52EsY38T+k3vJIfDDuWk= X-Forefront-Antispam-Report: CIP:192.88.168.50; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(199003)(189002)(87936001)(81156007)(87572001)(97736004)(47776003)(61266001)(50466002)(19580395003)(19580405001)(50986999)(76482005)(5001770100001)(5001960100002)(6260500002)(105596002)(86152002)(5003940100001)(77096005)(73972006)(81442002)(106466001)(229853001)(189998001)(86362001)(73392002)(33646002)(5008740100001)(36756003)(50226001)(11100500001)(104016004)(6806005)(82202001)(4326007)(2876002)(2906002)(55446002)(1096002)(1220700001)(3470700001)(586003)(48376002)(83322999)(92566002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR0301MB0691; H:tx30smr01.am.freescale.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8d43ce35-3eb7-49fa-18e4-08d327b99b5a X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0691; 2:LFaHzjrXmbeq88NVHnYyb7Vqq3YXhsnHJ0wIe8kYTZFScEE+LBGzKJyc+RF1dXIdgG9nvscenZ7Sk67O0qzxWfI9Atu6eycBWjyQiVlbzZSZkebhrmdxh/P6pBk1Iv45EidLwTuZ1uUAEskBsU+tvqQaHd9OHuunrLmf9JBFxiVGCHeuSnpaQBdQWwsxEHvF; 3:ov3kgRIU93jBM1rssZOImhI0WbYHb5Ymy+YqgCpM0vXK4NXpek82aON/2hjN4SuHN/IxGndPOoBZbD22lGjfRqzCd7QF14OYV1gSp6ka+PGqdrH6tyZ1p1OdGiMLa8OJsWuI4WzoLwOZd0Ab4ay4xH69F8CjuNT5bqaYzRI/BYYmjMlvGFlU54EPpStiARBL+uL5v8z9tHLzB/2j2i3naFnXv29ZTtuzz2uTWXg++rE=; 25:j4OpcTr7uv/SJc9dG8608kOrgn+HO5yyCQlqyFHfqNFwe1EyV+PNLZ8pz+G2JNzUzIJLgMqfCUeP4kMh+Rcn1C/moiWDFDA+N7fKMH7cUexmhnPwxzpK0eYXfa6MNnkNap0k1zgMbNT07yAjcW7DcRmPmsWGdxCnZLQuP0MNhdnzhSzhy/Dryz35ErxVheqj+784WAOkRPeH8Ouvbqp1eKflBHBZnifBDK5vuvED7FpPL+WMaT/Vaeem2BhS8juZ X-Exchange-Antispam-Report-Test: UriScan:; BCL:0; PCL:0; RULEID:; SRVR:BN1PR0301MB0691; UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13015025)(13023025)(8121501046)(13018025)(13024025)(13017025)(5005006)(3002001)(10201501046); SRVR:BN1PR0301MB0691; BCL:0; PCL:0; RULEID:(400006); SRVR:BN1PR0301MB0691; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0691; 4:hC0sWHnZRNONemc0bChIQCIjHXVRpLZxZWtJuuxHBfyrTo8iaE2as5+OFJa8bSwsnpsT0i6q1rn+NBwyzQTae4pm3DYjtv6ahzvDs7Nxz5cr1EZotYzCbC9GvFTatvnFEnR3ZoJEjNFqSvx4bVKwoEQVs+XPzFdCM2KVhm4TpS07G9MbruZcOwqgyrp1vGS2oSrnx8Lk35pme9E/TpRuurf5QllCmBupf9+dWWvWY3+h/tCFFW3b+2CigqlCPPDFJNK/4aO6N6WUj+uiJpNuG46u3kSvx0Eg32CPungLUqevMs8BvRnD/e4+uA0MYuHNG6ql+R3uq00SzvArQiSpo/0KSrOjHHgq9M9XJZfBr52vrBOf3oYj/3ia0aWw6bpzdok2snCbHTJX70y4XJwP1fcEaQauNFmBkymqx7cYiM3JeOjlLFqDYg1h1bKNaI7sWiOTbOoiB3yp2hbjg2qVfXxE7ScHSujhsshAkS5JOrgP53MaMShsR9b6d2ZR3XBQ X-Forefront-PRVS: 083526BF8A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1PR0301MB0691; 23:JQCV+oB50Ev6yJGTJoEh/VGrzfGpW19aM7xqqCO?= =?us-ascii?Q?tN71t77LkZDQA6gQfK+J0jrzcG+H3N9BlM1Xr0Rcr2Ai9GYxC5KInGivVea6?= =?us-ascii?Q?RnlhxJLluYItYCMXT/rwlh0X8gnEqXDl4N4HPTTJHhAs59VOALQpz0Loc4Xh?= =?us-ascii?Q?XSwh67H/0QUIdhyBg3We29SF2aDIpk7bTpknsw6oWH0GwO3wIxZp+JUL5aOl?= =?us-ascii?Q?kk/em++zXvNd2UM1G1IjsR/518OmCnMlQE5ywDXqNTpIyEPBUNK0ZWHxnmZi?= =?us-ascii?Q?Rf8p5zPrz0Byd3IbF9H3yvHo3WQOVhX5+pBziLd5cX8n1LOW7fOhuaXJ+HgM?= =?us-ascii?Q?wQjHwu1cqTVICCruqufgQ55mbJnP2lI8vAmpTGWCG3HPKjtLSPiaANeQIDcB?= =?us-ascii?Q?s5m2RZFJIqtv+VBKqSWKjx94k81CVneHxn7LLn4DaefpVvEe0SMk4FqhdCyw?= =?us-ascii?Q?p7qv8m9LHimOSB7xgLwPIcYkRHXnceK3cBfvwfDYkVNR0hAv8G6UcZVyneNn?= =?us-ascii?Q?Vz6Bo6v6lV2GJG1MYnHNkXJib+dMAVIS5p+XGUHYxrLDRnVXs8DkALf6UhKn?= =?us-ascii?Q?nKNgI92bI7+pI6xWyJY13uMLy8C9o9V7qZ804jU/Gg1JwHH4Km4VJ0Pr/GEA?= =?us-ascii?Q?X9rXG8W3oF/ZzJa0waatS07LDf0ro62znL2BlIC4U0xzhpUgFZ/zMKMyjPF6?= =?us-ascii?Q?HjSRANwHzPxmZXn5H4JagvzMx+1zzHC7sZGF/pWseqe/jjq1XwUOOwvkuarj?= =?us-ascii?Q?OQ39NzmYd5NPXHT4QtepHbIXEkFTpMl7VFAU//NcRT0Kktg3ZDvet3iLqYjl?= =?us-ascii?Q?jspKmfHiV90itxAJWyZK2DTOSzteR1hf2Fj7DYJByspYDDDqI5Xd1xRsnZ1p?= =?us-ascii?Q?XCHsGQuAtLdoGCwBcOIuewnoyXa/3paU9ME9gXU5LG4AGSNLYX/adPJ/U8s/?= =?us-ascii?Q?HY7S/L62UOc69r+AFf3HNuvR2uKni4J27YAuUC4Qd9GZ26hYY7/V0054Ug1I?= =?us-ascii?Q?5JhKPS2PC+IFFDZA/VQteRpyupjs54EOXn8m426K8+mi25imlomfFejhF1eS?= =?us-ascii?Q?/1rB1TvL8EJnbSmCR8vigL9C5sBvFEndTELedLa8HP1txGwFIBnC+u9MnbSI?= =?us-ascii?Q?9nh4QGC56a8/bO3PqVLMWd/pWylZMyhnJoN8XhQCCDIsjYNiJfpBDxbIHUXu?= =?us-ascii?Q?eRmTgCzQkPOJyAQkJ8FexXKNMzUs9LlHKNMP9wpn05tJNxfUrkh3uPnZJrrF?= =?us-ascii?Q?dUbwUas5QZt7eIf8AscTuOPTmTWXpmiTfTabfotHR?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0691; 5:UzPn2MNYaebA+VRVncEuJsQWWYpT0SX0QXghMuaUDzT/3n3nmvL7qwSichQbdUpz09Ya/TWIjrsdXfWrcXqVAGPukB0/mGSnvKpnsnncSkTs7Lzxp9BrwDV7aMwkfNxXxx/vfhnryh966Krb99rCpHzJhskVS0AFwRI0OUANCN4=; 24:RWJiumzKruNYKyrRgVUlohcBiR0lCyklqbXp1NbwrlZ9qhy9PQtlk/6e9UhFnUfp8X8yZRoaAiny0sXDxl6UpUExY0gzpkf7D9xgvAY0LBw= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2016 08:04:11.6618 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0691 X-Mailman-Approved-At: Thu, 28 Jan 2016 11:38:43 +0100 Subject: [U-Boot] [PATCH 1/2][v2] net: phy: introduce a quirk PHY_FLAG_BROKEN_RESET X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Shaohui Xie Current driver always performs a phy soft reset when connecting the phy device, but soft reset is not always supported by a phy device, so introduce a quirk PHY_FLAG_BROKEN_RESET to let such a phy device to skip soft reset. This commit uses 'flags' of phy device structure to store the quirk. Signed-off-by: Shaohui Xie Acked-by: Joe Hershberger --- changes in v2: 1. use PHY_FLAG_BROKEN_RESET instead of PHY_BROKEN_RESET 2. use '&' to check the phydev->flags instead of '==' drivers/net/phy/phy.c | 3 +++ include/phy.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 9bf231c..9126d5d 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -741,6 +741,9 @@ int phy_reset(struct phy_device *phydev) int timeout = 500; int devad = MDIO_DEVAD_NONE; + if (phydev->flags & PHY_FLAG_BROKEN_RESET) + return 0; + #ifdef CONFIG_PHYLIB_10G /* If it's 10G, we need to issue reset through one of the MMDs */ if (is_10g_interface(phydev->interface)) { diff --git a/include/phy.h b/include/phy.h index e030c9f..09bbe48 100644 --- a/include/phy.h +++ b/include/phy.h @@ -17,6 +17,8 @@ #define PHY_MAX_ADDR 32 +#define PHY_FLAG_BROKEN_RESET (1 << 0) /* soft reset not supported */ + #define PHY_DEFAULT_FEATURES (SUPPORTED_Autoneg | \ SUPPORTED_TP | \ SUPPORTED_MII)