| Message ID | 1453740480-1558-1-git-send-email-swarren@wwwdotorg.org |
|---|---|
| State | Deferred |
| Delegated to: | Tom Rini |
| Headers | show |
On Monday, January 25, 2016 at 05:48:00 PM, Stephen Warren wrote: > From: Stephen Warren <swarren@nvidia.com> > > The Linux kernel, from which checkpatch originates, contains function > ether_addr_copy() to copy Ethernet MAC addresses, and checkpatch warns > that it should be used in preference to memcpy() where appropriate. > U-Boot doesn't contain ether_addr_copy(), so tell checkpatch not to issue > this warning. > > Signed-off-by: Stephen Warren <swarren@nvidia.com> > Reviewed-by: Marek Vasut <marex@denx.de> > Acked-by: Joe Hershberger <joe.hershberger@ni.com> +CC Tom, Simon > --- > .checkpatch.conf | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/.checkpatch.conf b/.checkpatch.conf > index 35167e12015b..d1d32fac9db5 100644 > --- a/.checkpatch.conf > +++ b/.checkpatch.conf > @@ -21,3 +21,7 @@ > > # Ignore networking block comment style > --ignore NETWORKING_BLOCK_COMMENT_STYLE > + > +# Ignore "WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet > +# addresses are __aligned(2)". > +--ignore PREFER_ETHER_ADDR_COPY Best regards, Marek Vasut
On 01/25/2016 01:43 PM, Marek Vasut wrote: > On Monday, January 25, 2016 at 05:48:00 PM, Stephen Warren wrote: >> From: Stephen Warren <swarren@nvidia.com> >> >> The Linux kernel, from which checkpatch originates, contains function >> ether_addr_copy() to copy Ethernet MAC addresses, and checkpatch warns >> that it should be used in preference to memcpy() where appropriate. >> U-Boot doesn't contain ether_addr_copy(), so tell checkpatch not to issue >> this warning. >> >> Signed-off-by: Stephen Warren <swarren@nvidia.com> >> Reviewed-by: Marek Vasut <marex@denx.de> >> Acked-by: Joe Hershberger <joe.hershberger@ni.com> > > +CC Tom, Simon I believe Tom just applied the original posting of this: http://lists.denx.de/pipermail/u-boot/2016-January/243151.html checkpatch: ignore request to use ether_addr_copy()
On Monday, January 25, 2016 at 10:34:40 PM, Stephen Warren wrote: > On 01/25/2016 01:43 PM, Marek Vasut wrote: > > On Monday, January 25, 2016 at 05:48:00 PM, Stephen Warren wrote: > >> From: Stephen Warren <swarren@nvidia.com> > >> > >> The Linux kernel, from which checkpatch originates, contains function > >> ether_addr_copy() to copy Ethernet MAC addresses, and checkpatch warns > >> that it should be used in preference to memcpy() where appropriate. > >> U-Boot doesn't contain ether_addr_copy(), so tell checkpatch not to > >> issue this warning. > >> > >> Signed-off-by: Stephen Warren <swarren@nvidia.com> > >> Reviewed-by: Marek Vasut <marex@denx.de> > >> Acked-by: Joe Hershberger <joe.hershberger@ni.com> > > > > +CC Tom, Simon > > I believe Tom just applied the original posting of this: > > http://lists.denx.de/pipermail/u-boot/2016-January/243151.html > checkpatch: ignore request to use ether_addr_copy() Well then, that's fine. Thanks! Best regards, Marek Vasut
diff --git a/.checkpatch.conf b/.checkpatch.conf index 35167e12015b..d1d32fac9db5 100644 --- a/.checkpatch.conf +++ b/.checkpatch.conf @@ -21,3 +21,7 @@ # Ignore networking block comment style --ignore NETWORKING_BLOCK_COMMENT_STYLE + +# Ignore "WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet +# addresses are __aligned(2)". +--ignore PREFER_ETHER_ADDR_COPY