diff mbox

[U-Boot,v2,31/55] x86: ivybridge: Drop the unused bd82x6x_init_extra()

Message ID 1453072320-24298-32-git-send-email-sjg@chromium.org
State Accepted
Commit 82935b751b435cd1b6b7f38967121fc830717dd1
Delegated to: Bin Meng
Headers show

Commit Message

Simon Glass Jan. 17, 2016, 11:11 p.m. UTC 
This function does nothing now so can be dropped.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v2: None

 arch/x86/cpu/ivybridge/bd82x6x.c              | 16 ----------------
 arch/x86/cpu/ivybridge/pci.c                  |  1 -
 arch/x86/include/asm/arch-ivybridge/bd82x6x.h |  1 -
 3 files changed, 18 deletions(-)

Comments

Bin Meng Jan. 21, 2016, 8:01 a.m. UTC | #1 
On Mon, Jan 18, 2016 at 7:11 AM, Simon Glass <sjg@chromium.org> wrote:
> This function does nothing now so can be dropped.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/x86/cpu/ivybridge/bd82x6x.c              | 16 ----------------
>  arch/x86/cpu/ivybridge/pci.c                  |  1 -
>  arch/x86/include/asm/arch-ivybridge/bd82x6x.h |  1 -
>  3 files changed, 18 deletions(-)
>

applied to u-boot-x86/master, thanks!
diff mbox

Patch

diff --git a/arch/x86/cpu/ivybridge/bd82x6x.c b/arch/x86/cpu/ivybridge/bd82x6x.c
index 8e98fa2..1fe2ce1 100644
--- a/arch/x86/cpu/ivybridge/bd82x6x.c
+++ b/arch/x86/cpu/ivybridge/bd82x6x.c
@@ -56,22 +56,6 @@  static int bd82x6x_probe(struct udevice *dev)
 	return 0;
 }
 
-/* TODO(sjg@chromium.org): Move this to the PCH init() method */
-int bd82x6x_init_extra(void)
-{
-	const void *blob = gd->fdt_blob;
-	int sata_node;
-
-	sata_node = fdtdec_next_compatible(blob, 0,
-					   COMPAT_INTEL_PANTHERPOINT_AHCI);
-	if (sata_node < 0) {
-		debug("%s: Cannot find SATA node\n", __func__);
-		return -EINVAL;
-	}
-
-	return 0;
-}
-
 static int bd82x6x_pch_get_sbase(struct udevice *dev, ulong *sbasep)
 {
 	u32 rcba;
diff --git a/arch/x86/cpu/ivybridge/pci.c b/arch/x86/cpu/ivybridge/pci.c
index b081469..5195002 100644
--- a/arch/x86/cpu/ivybridge/pci.c
+++ b/arch/x86/cpu/ivybridge/pci.c
@@ -22,7 +22,6 @@  static int pci_ivybridge_probe(struct udevice *bus)
 	if (!(gd->flags & GD_FLG_RELOC))
 		return 0;
 	post_code(0x50);
-	bd82x6x_init_extra();
 	post_code(0x51);
 
 	return 0;
diff --git a/arch/x86/include/asm/arch-ivybridge/bd82x6x.h b/arch/x86/include/asm/arch-ivybridge/bd82x6x.h
index faae5ff..7a05c7e 100644
--- a/arch/x86/include/asm/arch-ivybridge/bd82x6x.h
+++ b/arch/x86/include/asm/arch-ivybridge/bd82x6x.h
@@ -11,6 +11,5 @@  void bd82x6x_sata_init(pci_dev_t dev, const void *blob, int node);
 void bd82x6x_usb_ehci_init(pci_dev_t dev);
 void bd82x6x_usb_xhci_init(pci_dev_t dev);
 int gma_func0_init(struct udevice *dev, const void *blob, int node);
-int bd82x6x_init_extra(void);
 
 #endif