From patchwork Wed Dec 30 06:19:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangbo Lu X-Patchwork-Id: 561712 X-Patchwork-Delegate: yorksun@freescale.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 387AE140BF7 for ; Wed, 30 Dec 2015 18:23:38 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6C8664BA62; Wed, 30 Dec 2015 08:23:33 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id clyBe3_PuzM6; Wed, 30 Dec 2015 08:23:33 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B0B2F4BA4C; Wed, 30 Dec 2015 08:23:32 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id BAF894B9D7 for ; Wed, 30 Dec 2015 07:41:52 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zDLR0aRI9qxR for ; Wed, 30 Dec 2015 07:41:52 +0100 (CET) X-Greylist: delayed 862 seconds by postgrey-1.34 at theia; Wed, 30 Dec 2015 07:41:47 CET X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0078.outbound.protection.outlook.com [157.56.111.78]) by theia.denx.de (Postfix) with ESMTPS id 119E54B9B9 for ; Wed, 30 Dec 2015 07:41:47 +0100 (CET) Received: from BY2PR03CA048.namprd03.prod.outlook.com (10.141.249.21) by BY2PR0301MB2117.namprd03.prod.outlook.com (10.163.197.146) with Microsoft SMTP Server (TLS) id 15.1.361.13; Wed, 30 Dec 2015 06:27:23 +0000 Received: from BN1BFFO11OLC001.protection.gbl (2a01:111:f400:7c10::1:168) by BY2PR03CA048.outlook.office365.com (2a01:111:e400:2c5d::21) with Microsoft SMTP Server (TLS) id 15.1.361.13 via Frontend Transport; Wed, 30 Dec 2015 06:27:23 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11OLC001.mail.protection.outlook.com (10.58.145.12) with Microsoft SMTP Server (TLS) id 15.1.355.15 via Frontend Transport; Wed, 30 Dec 2015 06:27:20 +0000 Received: from titan.ap.freescale.net ([10.192.208.233]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id tBU6RHkP000786; Tue, 29 Dec 2015 23:27:18 -0700 From: Yangbo Lu To: Date: Wed, 30 Dec 2015 14:19:30 +0800 Message-ID: <1451456370-14206-1-git-send-email-yangbo.lu@nxp.com> X-Mailer: git-send-email 2.1.0.27.g96db324 X-EOPAttributedMessage: 0 X-Matching-Connectors: 130959304424840644; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11OLC001; 1:mPqE6s9c4uwlD8MaIEeL629cfCZSgq8A9An0axtpRVydALCrIL3U9V8tyCVUyJu4AQHFZPXFPaUkKgHaItZNRrRZCqfctAjhstfxUpQJOFuHS39olKHCxZRX17TRNeunkWzkUft3ErUMV1s9BFKRdLjDLuk2bZBldFqg3KnJDTTMQHOgCg0CaS6krvlimRbwTqB9Ml4ZP1oGr/cAkwv2cBEKa+FKmlNx97Yw9U/z4DiKGT3Y/wTokeTCH6eUfSMfjfico8FJaQlEM9FEEghdXmwLp1CqOuXJacAdPQ/OTStTMwMMA8YEW4ilCSYZmIqVdGO5T6NtK1MZLFxe5OsESL/0ukCGK0joH7DCC/pfOw/YMuPQM/4asS0FkbJjJEc5808QrS6BOQ8Y9HpArt6025+eQ/XnEwVg6eFrFSRJwJLHcqXcGp4xfYgrlegF4ewmBGdBAtyszAAfsWT1J9GB1A== X-Forefront-Antispam-Report: CIP:192.88.168.50; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(36756003)(81156007)(47776003)(48376002)(229853001)(19580395003)(86362001)(87936001)(85426001)(19580405001)(105606002)(50466002)(106466001)(50986999)(92566002)(33646002)(2351001)(50226001)(77096005)(5001960100002)(6806005)(5008740100001)(110136002)(1220700001)(189998001)(97736004)(5003940100001)(104016004)(586003)(1096002)(11100500001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB2117; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2117; 2:KI5wbnzxX0q6zNC5GdI1Gwnd+34sRgkMe+Q0/OJRRjFK+YK2wH8+/zcFBrNNvqBNeaO3BMO4A/kFwAzUe+myGZUsWUkgGT5phGahgrKLgVEG3zBGAAo28J26S5iMKmoQbZKHZHX90CzfF27GPtmORQ==; 3:hZAyaIT8/4beIIQvMMYHql7lme0pxn10XAVIRdH2Gtp9x+0h9RPbpdzBxDg4RGpMRF+n3HqIzuGwJem+XUz5AYLqn+wUc9sRU0y2NQdMwXvaCeKUdNDNJZeJPcNVRAmThZ8MhqjeUwnoQaudBHvDEgphsOUNXz+W0OohGw9Do8BXffq/AWqqS2idjXk7QcpUOLjzAtO6DwwIYto85HbXaD2FguOt5uDMsxWSYePbuak=; 25:YPBuFySacW8/WBcG5G3RysENbCB1hyqpwoy17P1hjiUMWVB1jIwg1OL66CW2xMyfGI3D2dnDkUdDuj4hrdspjk0MPSrk0LTleUWhSloa8lY8VkvxrH0+G9JACuhxpVXX3Pq54pplGES5uGZ8kSOc0jG7m/0nv5/74wLeLM5a/uAqiOA08kgSR3Oyf2kXTipcFO2+Ypdjs0Oqe8f0yJglZOI8lNSIX9AHwc6YGH8Opw5Ss7wPgmrtw5QXe1ZGrQ3MPIRYc8/h4Pb/OONffXGrpg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB2117; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046); SRVR:BY2PR0301MB2117; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB2117; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2117; 4:+P5RDKBWWSY0WLtc9V6jtAAY5LeSP6yObXdCL6AeAvp842qs2VHvu3a0GQe7uHzbWfpzOf+nFw6vy46P54q0DweYJCYTw/n9BEry9JhsUjkGE/qTnBmde/I09+73qWJ3wck8AQYniCkhiNZAiBd2W9C3QraF6j5N4Pb1NhMxfjG/12La0/+en1TlHgsyx8VIVwTnqTyjcLhxfBbC362aWBbBkxyaVSGF+06AlqWDkPAsUz+pS6EzyslfE9I7vWWON6THRo66qY9kmTM1bpsu7DGBX1Fe8kNXmow/xotT1AO8n2l7nq+x5jRqmAfoleIfhOCmgB4eSk/BjyC31uarDGYp2NOvBtiN/fuLEItGOAx9nViJuLJIGGKr4BfuUu80e5LJIw0wcNGib6Girg8sWOJpFQPHJVYkh7GAMAZ3RY3uSLnTwyzOIigSoCKATJBZ X-Forefront-PRVS: 08062C429B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0301MB2117; 23:G7c/TxTJBjUrmc7sbg4QaX3m6EitlOPIxmszssU?= =?us-ascii?Q?09nm0GHc/l0gT/tVPTM4bsVtDxZelx28VVl1d9vwfpMiXxMEoJONVXszxiXH?= =?us-ascii?Q?vIyxtDyG6NaNyeu+NxipXSf5XOayJZ36/H0H8Iv87R6378VRjz2GoxcHEqdz?= =?us-ascii?Q?UEA97z3VAYdXUs8gXvnPCuacyO0zBWAyWwPVPw/34lIs70WimoWac8ITzxj0?= =?us-ascii?Q?set8gfbQtWe3b1tHDbvzJDYSmCFR+clkk11bgSpt/hlUd3f3tnznWDkkVTLD?= =?us-ascii?Q?h567P9XR+f8vQbRxgmPLdBn0nEuEqQTahWF/i8wJRjG87U6f1ft6TpcdUr4p?= =?us-ascii?Q?pNtlRmmKw56E2EFWQiiJ18F3FI/cDGO93hItgEAiw0/V7nl6gbHy/Ys6ntb5?= =?us-ascii?Q?SKs68s6X9QCaqRU4oFUpFq1AVSUXcQOQWlyTYKh+1+AkJQWou/i7rUGG+onZ?= =?us-ascii?Q?zhb3FKTlMdG8OQ7dD+y9Dd6buubVTC7qp4y9i957CedMFtngyMoMZn4MOOmE?= =?us-ascii?Q?FUKGR0F280k2UD/HLCulNiu8EoBrQrgcIg4gAsoJp8YE6YpWnfgg/pRe5FAx?= =?us-ascii?Q?X3n59gwskGTJ6yZGs+JZZ9+RAUHvwgkaFLJclVLpZswcm3p4PoAdCQ2rJHQe?= =?us-ascii?Q?qMstV9JmXz/669b7u+2EirBT43eqpm75PHNFUB1xy33JEJr/mp9ERhrQNdAF?= =?us-ascii?Q?m8xyQXOa6ZnFoy5/5dnBPfBH5fWB6h+aybOhdgIFn3wqH60jFn/MsG7C2QuG?= =?us-ascii?Q?QCg0Tq7nuEYOMb90cdG5HXjnRe/5mtVBCalC+SQiDZhY0DHmiiAMFH4U/eTd?= =?us-ascii?Q?GZGydhlmRsAvOKsE9RarZPvekcub9/CNjOsdTmia/VqkaUVWk1JkhOYaxovI?= =?us-ascii?Q?jGfrmstZwQGDClT//uNVBLcZvbKj8O8epfcgr+jVB49f7/nwLCPBCeQWbjqD?= =?us-ascii?Q?bfHHMnW0yjcndH3huVKSTn7pstn1qX0LletZJmxzCTf2kA0wfEcUFixG+DJI?= =?us-ascii?Q?4sRU14Snw1ybbQUBOb3wqN+40c44Hoash9HDI4uoZ/jDWwA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2117; 5:wyXKWU0l5EUptdFChjtwYo5IcurAoGFHI8O6ov31P9mBkPILbI0kK/nNfaPEvSCE38Hb3VAMJfvi5HghTluW5BoM5alK/RGEqwfBIDiWn8PjrglBDv9fSzC7ebSlyhKYLDBC3hOenpKeBzY9DWpVIJnW1dObU0xz8oy3yBWkZgQ=; 24:FnmdwSSuvZ+TbUdhIgN19fGajw2lKucFYSYWp4mwFoVL+3T9JQj+1yIGdy16oRIzDglItxwAkB8oQN6BW2QF6abLb0Nc6yjjQF9LBBhXyV4= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2015 06:27:20.8772 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB2117 X-Mailman-Approved-At: Wed, 30 Dec 2015 08:23:29 +0100 Cc: yorksun@freescale.com, Yangbo Lu Subject: [U-Boot] [PATCH] mmc: fsl_esdhc: increase data transaction timeout to 500ms X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The MMC spec says "It is strongly recommended for hosts to implement more than 500ms timeout value even if the card indicates the 250ms maximum busy length." Even the previous value of 300ms is known to be insufficient for some cards. So, increase the timeout to 500ms. Signed-off-by: Yangbo Lu --- drivers/mmc/fsl_esdhc.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index c5054d6..12820cf 100644 --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -252,8 +252,15 @@ static int esdhc_setup_data(struct mmc *mmc, struct mmc_data *data) * Rounding up to next power of 2 * => timeout + 13 = log2(mmc->clock/4) + 1 * => timeout + 13 = fls(mmc->clock/4) + * + * However, the MMC spec "It is strongly recommended for hosts to + * implement more than 500ms timeout value even if the card + * indicates the 250ms maximum busy length." Even the previous + * value of 300ms is known to be insufficient for some cards. + * So, we use + * => timeout + 13 = fls(mmc->clock/2) */ - timeout = fls(mmc->clock/4); + timeout = fls(mmc->clock/2); timeout -= 13; if (timeout > 14)