diff mbox

[U-Boot,v3,02/13] pci: Use a separate variable for the bus number

Message ID 1448592690-14911-3-git-send-email-sjg@chromium.org
State Accepted
Headers show

Commit Message

Simon Glass Nov. 27, 2015, 2:51 a.m. UTC 
At present in do_pci(), bdf can either mean a bus number or a PCI bus number.
Use separate variables instead to reduce confusion.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v3: None
Changes in v2: None

 common/cmd_pci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Simon Glass Nov. 28, 2015, 4:55 p.m. UTC | #1 
On 26 November 2015 at 18:51, Simon Glass <sjg@chromium.org> wrote:
> At present in do_pci(), bdf can either mean a bus number or a PCI bus number.
> Use separate variables instead to reduce confusion.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
>  common/cmd_pci.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied to u-boot-dm.
diff mbox

Patch

diff --git a/common/cmd_pci.c b/common/cmd_pci.c
index f3148a3..bed880c 100644
--- a/common/cmd_pci.c
+++ b/common/cmd_pci.c
@@ -408,6 +408,7 @@  pci_cfg_modify (pci_dev_t bdf, ulong addr, ulong size, ulong value, int incrflag
 static int do_pci(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	ulong addr = 0, value = 0, size = 0;
+	int busnum = 0;
 	pci_dev_t bdf = 0;
 	char cmd = 's';
 	int ret = 0;
@@ -438,16 +439,15 @@  static int do_pci(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 #endif
 	default:		/* scan bus */
 		value = 1; /* short listing */
-		bdf = 0;   /* bus number  */
 		if (argc > 1) {
 			if (argv[argc-1][0] == 'l') {
 				value = 0;
 				argc--;
 			}
 			if (argc > 1)
-				bdf = simple_strtoul(argv[1], NULL, 16);
+				busnum = simple_strtoul(argv[1], NULL, 16);
 		}
-		pciinfo(bdf, value);
+		pciinfo(busnum, value);
 		return 0;
 	}