| Message ID | 1448355263-545-4-git-send-email-Peng.Fan@freescale.com |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
On 24/11/2015 09:54, Peng Fan wrote: > Simplify if/else code, since if channel equals to MEM_BG_SYNC or > MEM_FG_SYNC, we have value 5 for 'dc_chan'. > > Signed-off-by: Peng Fan <Peng.Fan@freescale.com> > Cc: Anatolij Gustschin <agust@denx.de> > Cc: Stefano Babic <sbabic@denx.de> > --- > drivers/video/ipu_disp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c > index 4faeafb..7a87478 100644 > --- a/drivers/video/ipu_disp.c > +++ b/drivers/video/ipu_disp.c > @@ -611,11 +611,9 @@ void ipu_dp_dc_enable(ipu_channel_t channel) > uint32_t reg; > uint32_t dc_chan; > > - if (channel == MEM_FG_SYNC) > - dc_chan = 5; > if (channel == MEM_DC_SYNC) > dc_chan = 1; > - else if (channel == MEM_BG_SYNC) > + else if ((channel == MEM_BG_SYNC) || (channel == MEM_FG_SYNC)) > dc_chan = 5; > else > return; > Reviewed-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic
diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c index 4faeafb..7a87478 100644 --- a/drivers/video/ipu_disp.c +++ b/drivers/video/ipu_disp.c @@ -611,11 +611,9 @@ void ipu_dp_dc_enable(ipu_channel_t channel) uint32_t reg; uint32_t dc_chan; - if (channel == MEM_FG_SYNC) - dc_chan = 5; if (channel == MEM_DC_SYNC) dc_chan = 1; - else if (channel == MEM_BG_SYNC) + else if ((channel == MEM_BG_SYNC) || (channel == MEM_FG_SYNC)) dc_chan = 5; else return;
Simplify if/else code, since if channel equals to MEM_BG_SYNC or MEM_FG_SYNC, we have value 5 for 'dc_chan'. Signed-off-by: Peng Fan <Peng.Fan@freescale.com> Cc: Anatolij Gustschin <agust@denx.de> Cc: Stefano Babic <sbabic@denx.de> --- drivers/video/ipu_disp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)