diff mbox

[U-Boot,4/4] atmel_nand: use the definition: PMECC_OOB_RESERVED_BYTES instead magic number

Message ID 1448353614-26398-5-git-send-email-josh.wu@atmel.com
State Accepted, archived
Commit 422b49e2895ef61a1cc454aca6dd79a8e2279eff
Delegated to: Andreas Bießmann
Headers show

Commit Message

Josh Wu Nov. 24, 2015, 8:26 a.m. UTC 
As atmel_nand_ecc.h is sync with v4.1 kernel, which adds the
PMECC_OOB_RESERVED_BYTES. So use it in the driver.

Signed-off-by: Josh Wu <josh.wu@atmel.com>
---

 drivers/mtd/nand/atmel_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Bießmann Jan. 24, 2016, 9:37 p.m. UTC | #1 
On 24.11.15 09:26, Josh Wu wrote:
> As atmel_nand_ecc.h is sync with v4.1 kernel, which adds the
> PMECC_OOB_RESERVED_BYTES. So use it in the driver.
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>

Reviewed-by: Andreas Bießmann <andreas.devel@googlemail.com>

> ---
> 
>  drivers/mtd/nand/atmel_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 266dfd9..2967eee 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -901,7 +901,7 @@ static int atmel_pmecc_nand_init_params(struct nand_chip *nand,
>  			return -EINVAL;
>  		}
>  
> -		if (nand->ecc.bytes > mtd->oobsize - 2) {
> +		if (nand->ecc.bytes > mtd->oobsize - PMECC_OOB_RESERVED_BYTES) {
>  			dev_err(host->dev, "No room for ECC bytes\n");
>  			return -EINVAL;
>  		}
>
diff mbox

Patch

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 266dfd9..2967eee 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -901,7 +901,7 @@  static int atmel_pmecc_nand_init_params(struct nand_chip *nand,
 			return -EINVAL;
 		}
 
-		if (nand->ecc.bytes > mtd->oobsize - 2) {
+		if (nand->ecc.bytes > mtd->oobsize - PMECC_OOB_RESERVED_BYTES) {
 			dev_err(host->dev, "No room for ECC bytes\n");
 			return -EINVAL;
 		}