From patchwork Fri Oct 16 10:13:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chin Liang See X-Patchwork-Id: 531190 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 96DBF14012C for ; Fri, 16 Oct 2015 21:13:43 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4197C4B62B; Fri, 16 Oct 2015 12:13:42 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wyw9IkeD9uM4; Fri, 16 Oct 2015 12:13:42 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 71AEA4A03A; Fri, 16 Oct 2015 12:13:41 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id CD0574A03A for ; Fri, 16 Oct 2015 12:13:37 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xDCtuAyFOtKK for ; Fri, 16 Oct 2015 12:13:37 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0096.outbound.protection.outlook.com [157.56.111.96]) by theia.denx.de (Postfix) with ESMTPS id 126C84A033 for ; Fri, 16 Oct 2015 12:13:33 +0200 (CEST) Received: from DM2PR03CA0049.namprd03.prod.outlook.com (10.141.96.48) by BN3PR03MB1496.namprd03.prod.outlook.com (10.163.35.147) with Microsoft SMTP Server (TLS) id 15.1.300.14; Fri, 16 Oct 2015 10:13:31 +0000 Received: from BN1BFFO11FD055.protection.gbl (2a01:111:f400:7c10::1:110) by DM2PR03CA0049.outlook.office365.com (2a01:111:e400:2428::48) with Microsoft SMTP Server (TLS) id 15.1.300.14 via Frontend Transport; Fri, 16 Oct 2015 10:13:31 +0000 Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; denx.de; dkim=none (message not signed) header.d=none; denx.de; dmarc=none action=none header.from=altera.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning altera.com discourages use of 66.35.236.227 as permitted sender) Received: from sj-itexedge03.altera.priv.altera.com (66.35.236.227) by BN1BFFO11FD055.mail.protection.outlook.com (10.58.145.10) with Microsoft SMTP Server (TLS) id 15.1.293.9 via Frontend Transport; Fri, 16 Oct 2015 10:13:30 +0000 Received: from sj-mail01.altera.com (137.57.1.6) by webmail.altera.com (66.35.236.227) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 16 Oct 2015 03:13:04 -0700 Received: from [10.0.2.15] (tx-clsee-530.altera.priv.altera.com [137.57.103.31]) by sj-mail01.altera.com (8.13.7+Sun/8.13.7) with ESMTP id t9GADOLn018888; Fri, 16 Oct 2015 03:13:25 -0700 (PDT) Message-ID: <1444990404.2436.2.camel@clsee-VirtualBox> From: Chin Liang See To: ZY - u-boot Date: Fri, 16 Oct 2015 05:13:24 -0500 In-Reply-To: <1444987199-2728-1-git-send-email-clsee@altera.com> References: <1444987199-2728-1-git-send-email-clsee@altera.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD055; 1:L7jNUZGNLGV7SFJwdK+P+qOvLpnDjkzQUEfL2y64HoUBwNXcqK4s7gpZu4ZZ4ltspl2hlaaKSWZHeXn9vUvEOkzk0p/JBKDx5pCCg43BrXw5pue1YXuV8km7OXxFMW1i5kEU9ecNil4AOezSxmYe64jF7kI7Ta64U0wqvSrW1IPTzFh1IYDpN4uOaH0CyRT/j7zzdvPqNyGn+K5xn4o5UgGlN9lHj3gosmQGIXNdqvVcgTdJaghwr/b6DQ5O2H356YHvoLAKORrqbQpkOasOpGYVpO/mFdSgcL5SPb+SGfx2Y0MbMiQFg9zLB6s7LXvsp6nLRll999hLMAFVaGC+RPpYbQtt6Z2LHQUxjwN4g1JFrqH8PbsuirQgDXlPKoJsayZ2HkzBzopxXh/zmJFcuw== X-Forefront-Antispam-Report: CIP:66.35.236.227; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(199003)(189002)(87936001)(23676002)(77096005)(47776003)(46102003)(64706001)(50226001)(103116003)(92566002)(16796002)(189998001)(5001960100002)(19580395003)(81156007)(105596002)(230783001)(86362001)(229853001)(19580405001)(97736004)(110136002)(5007970100001)(11100500001)(5008740100001)(50986999)(50466002)(106466001)(76176999)(5820100001)(6806005)(2950100001)(33716001)(33646002)(7099028)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB1496; H:sj-itexedge03.altera.priv.altera.com; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB1496; 2:eav9QKzniPkWg3bxct5LBD4pZPyTMJRHdRJNGoyCEMm6/sSbC9TZuh7Sp3zNcdyhAAs08feVTpXfn6S4YoSGZfHoOmcYQPj8vFvoeHPln+e3iHfVWtsW2rJn3f0qnmrq+e12WEwzRzGC/ErbITx8E6pkvXexgDZyJ41HXQSwTVk=; 3:rfGVZDU4bOTYcHsLd1Z5lecVKxwpOn639Dt8ueqyyeFsXVillK1fbhS92+QKyGwJJe59vQa4O4gowiyqDgnJHR5kbjLrDrPYMmiUxahZctSwj0L+kJcmeyXPUQvEtM8C4tU9rrKYc5v/jIh4ZxhBCKthlTcbDnGtATwzMLTWQ28ET3RcbDlDEntwbfqwl/iaBUhHkgiJqgDWU+g8bzY6icIWWs8inzg5gh71flAOCLc=; 25:YCSm0h463zlYVZkPiVuN3CD31+bgfCKIGEkuYFjy9K2yVKj9CFWIgpYcl7QGZx4onE4G7hTqJ1kSMZCYTvzDEXwBWzpgr706FpoZKPzDVjGjsL03pJyD3PMYRXF4fPEv8N5vcfFIXCeU2HJj2kk55aaHrq7U3G93GR03VrCTXqmzJAePH4dnUYmJuZSk/a01ADPuJOB3chL+KQ6Yi7azid0ljxhdIgKNrjKSEPMfz0r0lqlPDGUTq9JGxO/daH/z; 20:cI6+a2Rfxl5F1hJAd8TgdOn+N3ye7HT8mvi2/XzkP1r+BQvE3m655q+oyrJgAZ5pPBfJmyGRfE2NSYpmbOMC3iWFrpr6ZR70meNW4rri0Omx2UmQlV8SrafAex5m+MT9t2DGD0Dc2R5bC0cLCEI87TVmsKeRVy6Z9yLvyUOkznM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1496; X-LD-Processed: fbd72e03-d4a5-4110-adce-614d51f2077a,ExtAddr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757)(204874498639787)(202767206196957); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001); SRVR:BN3PR03MB1496; BCL:0; PCL:0; RULEID:; SRVR:BN3PR03MB1496; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB1496; 4:yiUCkyNjvAkSe+sWWzXc5QCXziOsyU1UzsDvb1DQrVnF4jVg+4XBrFMttuX5aIevtrJwLz1siME3Qzd5dK4UJBdMttaCH/04oxI2ka21vJDiwjdXpjKZNs52pp1//FhWwQwBnHyCkOHh+5OmqhuExfp6h8w/QCqcZ3LYznByzT2aXBGZge5SzlZ8HWCgrByaYFWY9spsGWF54uvdJ9/BMsPYcq3WogAccgQtD3U/IAPIt6+Bpr+S7rjrFspvbWdaiFD92ttRD7gGkyObyN5FiJRFkJe/dGEQuyU7vMXqbo08O4MVpxD6oTD8MFMOQMt33ORs2tdM9A8LsZX+lm6R/LFjVScqKPlVVCCc1p+qUC8= X-Forefront-PRVS: 0731AA2DE6 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzTUIxNDk2OzIzOklWcmhpbkZhOFRYL1hVUW91cUxwenRIVkU5?= =?utf-8?B?aS9SSHEyajU2QlpScERQQ2xOcE5ucnYvcXlCVEJ1WmdHUmQ3TVV3bmpoc0Rm?= =?utf-8?B?bCtUbzNwTlM5bWVwa3dBWWR1ZHZJUWppbld4YWpoUllqRzRVWnBFZHpwbzZn?= =?utf-8?B?REgvOGNwb01CRCt3UENkR3grYjBUMml6QVh0bzBtUmtqdURkMHFvUVRlb1R3?= =?utf-8?B?N0RIbURuQlFOa1JTeENPNnNNaHRnb1ZFQUxKc1lieFhpRThoc0wrYzVUWkhC?= =?utf-8?B?L3JyTm4vc3NpSGVVQzZTVm5pcFpZU2VmdzZYaVBJOVU3bEIxdGk3eEcvMzcx?= =?utf-8?B?REZMZnFPZzhlcHZMYzlGdHpxQ0k1aFVVekNKRDNyNnhlOGVpUGo2M3BkdjND?= =?utf-8?B?M3lxY2V6MlJsejF5b2dnSis0UVIyQ0dQdlVZRWhqYWNwQUlmSnlsUjBKZVRa?= =?utf-8?B?WWYvbjNqT3BJUXhyUFY3TlFPYXBDRWthdmlETlNBVjRyT3NnUW9FaDBBN3Vn?= =?utf-8?B?Tnp6eXNSM1RKMHozaGU5VkZrRUtXTVRYbkZ2REdKRUpkemlCT0F6S1UvSVJ2?= =?utf-8?B?ZnJxYVlLN0lxMVRUUUdCbFBMQ08zSUI2am1ZNHpSa05GTWFnVlZJT2xnMFM5?= =?utf-8?B?UzFDTWl0MHYyUHdlSE4vc0drb3Q2dWpKRmNuU3pweEc0R0N5MFFBNHlnUXlq?= =?utf-8?B?aXJ4ZCtKY1VERndqTmpYRXJRR1JtSlIvU0ZZT09EWndkaUxzMk0vZ0ZEZTY1?= =?utf-8?B?N21nV3E4QWUrZUhEMUhobFd2UXRscUlhN0FaRndLb0U1VmRQU3VWc1Y1TSs2?= =?utf-8?B?eDlab0FVRVZMUGlqbmEyT01pb0EyRmZOaThvT2NsYlRTUGs3WXdrNEE3eGRx?= =?utf-8?B?eHVlekw1NjNLZ0doblRHbXRBckU2SjJ6alFhVHlhUWo1UVFZcmRROTRLTHRj?= =?utf-8?B?MlFYTktveVl6dElwRmdZZlFZT3hmVEUyQ1FpS3J4dlVONmx3a3RvL2hYQVVO?= =?utf-8?B?WldmNDVBWm5XZkQ4bGhkYlhRbW5rMW0wZGdac1REQjhzTDQxSHBGKzNtL1lh?= =?utf-8?B?U0MzWTFVM2pwMUVWL3pmOGF1ekxmWnB2NmVjcWEzU09MVTk2c08ya2FRWnNH?= =?utf-8?B?SytDQUdPNG5XTkFYWWRxWGw3aW1TeEdRMVNQb3R3ZFlHdGJBRXVuQVhnRkIv?= =?utf-8?B?R0Q0d2tFbkFnMzYrenl0akQzWVl1Sm1Td3JNZTNyZktNYjl0Y3VYL3ZGQjZW?= =?utf-8?B?Rmx2YUY3TmlodHBKNVJhd2ozY0FubU96YnlsRnVDc1gyQ3hvTmZkNktKN2o3?= =?utf-8?B?YzY5Q3pPdjFjYWdpZTRUcDlSK05vS1MwTGdlOVN2TEJ0d25UMlRaYXByVndr?= =?utf-8?B?WmtwanBqVVoyeHRPdVRWVTFqNGxGNUNxT3R3ekVxUzlmQ1g5c3ZxYkJBY1lh?= =?utf-8?Q?1eu5bY=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB1496; 5:zuIjoUMxcxQkT+myrugC94tgXprlw0J4G6OkqrpziHVgxKQc7AM0u8LUSLNi6kl81wQk4WYDPCQZ0MzGDfd9Dld5Q6RoY7aXtcbLYehsC3HBPTNXYId25Ioo3E7A2TrLSV50YbrZxYeV1wRuQP+UZw==; 24:SiYV+1jZ1w/I6J0ax/Fxs11GXx4yr6+nU9ATsnpeKGeTuf6LVHyWX+BfudnkVJjOIb5Cfvpkumq3rry34m+7vGhdHGPR9/uYYAxzEDH7kF0=; 20:DuJUfab7wVJNtzk4jaJOPuBH7rZyB46DFJ4TLiXbdUin5fQCB2wXmvVmaTugTLlY4zvHAkIaDlZOsQCzmFk5K8y2a0AKPpj+ccLzoNug0C5pqoQqg8gJlIXfWStn3DY2jYWZVFrx2Fa6Dhp5NkacklhLU6p+UrRJAtQHHWrure8= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2015 10:13:30.2286 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a; Ip=[66.35.236.227]; Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1496 Cc: Marek Vasut , Pavel Machek , Jagannadh Teki , Stefan Roese Subject: [U-Boot] [PATCH v4 2/5] spi: cadence_qspi: Fix fdt read of spi-max-frequency X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From 4a91b5a380e7d3178d4378df79224442c79278bb Mon Sep 17 00:00:00 2001 From: Chin Liang See Date: Fri, 16 Oct 2015 16:35:10 +0800 Subject: [PATCH v4 2/5] spi: cadence_qspi: Fix fdt read of spi-max-frequency Fix the fdt read for spi-max-frequency as it's contained in the child node. Current state of code is always returning default value. Signed-off-by: Chin Liang See Cc: Dinh Nguyen Cc: Dinh Nguyen Cc: Marek Vasut Cc: Stefan Roese Cc: Vikas Manocha Cc: Jagannadh Teki Cc: Pavel Machek Acked-by: Marek Vasut Acked-by: Pavel Machek --- Changes for v4 - use the newly created fdtdec_get_uint Changes for v3 - Use of fdt_getprop_u32_default_node instead casting Changes for v2 - Add unsigned casting for plat->max_hz --- drivers/spi/cadence_qspi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) if (subnode < 0) { @@ -306,6 +302,10 @@ static int cadence_spi_ofdata_to_platdata(struct udevice *bus) return -ENODEV; } + /* Use 500 KHz as a suitable default */ + plat->max_hz = fdtdec_get_uint(blob, subnode, "spi-max-frequency", + 500000); + /* Read other parameters from DT */ plat->page_size = fdtdec_get_int(blob, subnode, "page-size", 256); plat->block_size = fdtdec_get_int(blob, subnode, "block-size", 16); diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c index c5a4276..5756178 100644 --- a/drivers/spi/cadence_qspi.c +++ b/drivers/spi/cadence_qspi.c @@ -295,10 +295,6 @@ static int cadence_spi_ofdata_to_platdata(struct udevice *bus) plat->regbase = (void *)data[0]; plat->ahbbase = (void *)data[2]; - /* Use 500KHz as a suitable default */ - plat->max_hz = fdtdec_get_int(blob, node, "spi-max-frequency", - 500000); - /* All other paramters are embedded in the child node */ subnode = fdt_first_subnode(blob, node);