From patchwork Sat Aug 22 21:58:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 509741 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 7E19B140775 for ; Sun, 23 Aug 2015 08:00:32 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=B9eVUiMK; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 83FAA4B6A1; Sun, 23 Aug 2015 00:00:29 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6brh4944u6Df; Sun, 23 Aug 2015 00:00:29 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 934E54B662; Sat, 22 Aug 2015 23:59:41 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D417A4B65F for ; Sat, 22 Aug 2015 23:59:22 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ECzU18C2Pw_a for ; Sat, 22 Aug 2015 23:59:22 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-io0-f172.google.com (mail-io0-f172.google.com [209.85.223.172]) by theia.denx.de (Postfix) with ESMTPS id 222EB4B666 for ; Sat, 22 Aug 2015 23:59:15 +0200 (CEST) Received: by iodt126 with SMTP id t126so114825440iod.2 for ; Sat, 22 Aug 2015 14:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=yifhromsWRuJxo0lSkVZTx2TUPDImhniO9UN42KziG8=; b=B9eVUiMKlKUkjbdS9ziuxIigEoLVpnufk0XAyzf06wGqTFAcs/GXc++HeBprlEzJk6 tuizww6lnFSZDB2tBezJ1ZXJHitsvj2wTxl1Eess47+X4yjKH6Ywza0c7Oem6D18cHq8 tbjyRlkFqO8GPGdxhVh4Y9QdLIYImKrvct4ptMmpxttlEb4VH9+AciqvTbhEuL0xn0l5 V+42azS0DvgqgF3I3TmgM3e+YJIPgCDyQupgeVnOGXAq2FXEmyRjmjO3YrcwAeBW3omM h2tGVQd15QZQBIF98YhF+nZ9GiNWE/APLq3FvcKANjh4QB3bOc3+iGmFYPj6gD5shiFn I77g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=yifhromsWRuJxo0lSkVZTx2TUPDImhniO9UN42KziG8=; b=Fxnf9eZyiHyDLEizZb9f6zwSg2xGZQj2HzXUu2T2aqrqXClKyC3MigWpWouPTl91Ep MzEbAQ/ZNcv8/oG+42X7nuabQi/+6Nlpd/blh7rmwIOEOYhQ/K6Kw5pmXgI9CP6pWHrs wzeaBFJuUwXgAEBEYAs+1MaqQHJkN3iUAGsSoz8pojxstySLoaQuIgqpuBL5xFH4spmk 6zx1hCzDjlSqwbgG27PNYupui1ka0acFxaHfDX94l+9CGpaoLufmpKaBT4mEwSdidLbf WGzz0GGGjFX8RpxEXooHloNi+zXaPDOk0K1MFUWqBU75IcrqqEYQR9t/msMIgDhbume2 3VLg== X-Gm-Message-State: ALoCoQk0j+4QodXFWYgOL0Zo1bnG2gN//8zlf5Kj+wN80w3/XGwYY2rZ7ZQNv4ZViNncwwUPLjy6 X-Received: by 10.107.152.148 with SMTP id a142mr13218194ioe.149.1440280754645; Sat, 22 Aug 2015 14:59:14 -0700 (PDT) Received: from kaki.bld.corp.google.com ([172.29.216.32]) by smtp.gmail.com with ESMTPSA id pl8sm5210251igb.8.2015.08.22.14.59.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Aug 2015 14:59:14 -0700 (PDT) Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id 6EBB2221696; Sat, 22 Aug 2015 15:59:11 -0600 (MDT) From: Simon Glass To: U-Boot Mailing List Date: Sat, 22 Aug 2015 15:58:58 -0600 Message-Id: <1440280741-16169-7-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 2.5.0.457.gab17608 In-Reply-To: <1440280741-16169-1-git-send-email-sjg@chromium.org> References: <1440280741-16169-1-git-send-email-sjg@chromium.org> Cc: Graeme Russ , Andrew Bradford Subject: [U-Boot] [PATCH v2 6/9] x86: gpio: Correct calls to _ich6_gpio_set_direction() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" These calls seem to be incorrect. The function expects an I/O address but the existing callers pass the value at an I/O address. Fix it. Signed-off-by: Simon Glass --- Changes in v2: None drivers/gpio/intel_ich6_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/intel_ich6_gpio.c b/drivers/gpio/intel_ich6_gpio.c index cb408a4..fd1f287 100644 --- a/drivers/gpio/intel_ich6_gpio.c +++ b/drivers/gpio/intel_ich6_gpio.c @@ -410,7 +410,7 @@ static int ich6_gpio_direction_input(struct udevice *dev, unsigned offset) { struct ich6_bank_priv *bank = dev_get_priv(dev); - return _ich6_gpio_set_direction(inl(bank->io_sel), offset, 0); + return _ich6_gpio_set_direction(bank->io_sel, offset, 0); } static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset, @@ -419,7 +419,7 @@ static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset, int ret; struct ich6_bank_priv *bank = dev_get_priv(dev); - ret = _ich6_gpio_set_direction(inl(bank->io_sel), offset, 1); + ret = _ich6_gpio_set_direction(bank->io_sel, offset, 1); if (ret) return ret;