| Message ID | 1439434863-18108-2-git-send-email-saket.sinha89@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Saket, The patch/commit title is: x86: Added ACPI support as a configuration option. Please use simple tense in the title. So it's 'Add', not 'Added'. Also please do not add any ending period. On Thu, Aug 13, 2015 at 11:01 AM, Saket Sinha <saket.sinha89@gmail.com> wrote: Please add some commit message to describe what this commit is for. > Signed-off-by: Saket Sinha <saket.sinha89@gmail.com> > --- > > arch/x86/Kconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 01ed760..36eae6d 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -346,6 +346,12 @@ config GENERATE_MP_TABLE > > endmenu > > +config GENERATE_ACPI_TABLE Please move this Kconfig option into the "System tables" menu. > + bool "Generate ACPI(Advanced Configuration and Power Interface) table" Please add 'an' before ACPI, and one space after ACPI. > + default y Default should be n. > + help > + The Advanced Configuration and Power Interface (ACPI) specification provides an open standard for device configuration and management by the operating system. It defines platform-independent interfaces for configuration, power management monitoring. Please rewrite this paragraph, make sure they do not exceed 80 cols. > + > config MAX_PIRQ_LINKS > int > default 8 > -- Regards, Bin
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 01ed760..36eae6d 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -346,6 +346,12 @@ config GENERATE_MP_TABLE endmenu +config GENERATE_ACPI_TABLE + bool "Generate ACPI(Advanced Configuration and Power Interface) table" + default y + help + The Advanced Configuration and Power Interface (ACPI) specification provides an open standard for device configuration and management by the operating system. It defines platform-independent interfaces for configuration, power management monitoring. + config MAX_PIRQ_LINKS int default 8
Signed-off-by: Saket Sinha <saket.sinha89@gmail.com> --- arch/x86/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+)