From patchwork Thu Aug 13 02:09:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 506814 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 915AA1402C3 for ; Thu, 13 Aug 2015 12:10:58 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=ouP7jX3V; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7EB204B6CE; Thu, 13 Aug 2015 04:10:48 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7002e2u-i7x6; Thu, 13 Aug 2015 04:10:48 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 159DB4B6D4; Thu, 13 Aug 2015 04:10:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E219F4B660 for ; Thu, 13 Aug 2015 04:10:11 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gncza935FYz1 for ; Thu, 13 Aug 2015 04:10:11 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-io0-f169.google.com (mail-io0-f169.google.com [209.85.223.169]) by theia.denx.de (Postfix) with ESMTPS id 18E8C4B668 for ; Thu, 13 Aug 2015 04:10:09 +0200 (CEST) Received: by iodt126 with SMTP id t126so38957284iod.2 for ; Wed, 12 Aug 2015 19:10:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=dsHc9UI71ekAy0ONz8SFXy1b7ue51nBZ97tLh+A9TbQ=; b=ouP7jX3VqwwrvZNGXXJOCJu34ut9TyqI3FoMf3+wb142VDVanRBwQ9jVPUV/6fZvyu TPNvisoh1DkynWZseoMdcAn5eFCd/bBhw4Nd0vLq16hhiemG2xuC49GbOy5TcowxMFbB nejcT6aViD/vqsQ/j503BlVQQNl6nTR5u+5B14iW0gzxnRkQgrjfOjcw9xcy//Nwmt+0 raE9MamAfiAqyibdQgprLttYgd8JW7CCF/YnOSj8MCERLhaJvarwNmGT94aFt4dJ1woQ rKLvj4hRfqEmif349mciDxtLZ2awUN/8kWRKvFi06L2XutgdGhTU86wUVmdm0ASnDvPy iTcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=dsHc9UI71ekAy0ONz8SFXy1b7ue51nBZ97tLh+A9TbQ=; b=ZQLX78xt0yrsYBKRgHwK/WVX77GnbujunyQo0ZKxppshdZq5V8yUKaXqZbuWKIJ4Hk Y8NvNxqnJZNHO0fmHCoYJrwDbrRVhx/zTn80nIfjTSC4zoX7Fs6+CywwtYwKez+YIhFe RnRaWoEA8kS2OFFcc7qJBt1NLbH9lJj0iJ2x9qCFIA5yDuQ9IiMBADQZyQZ9c16TDUl4 f/71RnjCDxe5YKnPZJ2QP55bR6d0lm/m5FlSAT1V6HdNVYZYf/qFhdD1x+2VOtOlfT/b eFp5Bvsq0ge9ZYpdOqBTCKsG1rN7s9A2yubVXX7s7ZBt1cK4vgAPAsTJK0pyWtUB1oHT ou2A== X-Gm-Message-State: ALoCoQmuY7WAnPikTlZNwmDOGA9/k4tHEnsmxImr1lTPNXpPF2avcrgkLbQPMNDzEC5ai/+8bjCl X-Received: by 10.107.38.212 with SMTP id m203mr41475267iom.98.1439431807659; Wed, 12 Aug 2015 19:10:07 -0700 (PDT) Received: from kaki.bld.corp.google.com ([2620:0:1005:1100:e47a:d5f8:400:26d0]) by smtp.gmail.com with ESMTPSA id o140sm556039ioe.27.2015.08.12.19.10.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Aug 2015 19:10:06 -0700 (PDT) Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id BF2BA2211B5; Wed, 12 Aug 2015 20:10:03 -0600 (MDT) From: Simon Glass To: U-Boot Mailing List Date: Wed, 12 Aug 2015 20:09:36 -0600 Message-Id: <1439431779-16857-8-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 2.5.0.276.gf5e568e In-Reply-To: <1439431779-16857-1-git-send-email-sjg@chromium.org> References: <1439431779-16857-1-git-send-email-sjg@chromium.org> Cc: Tom Rini , Axel Lin , Graeme Russ , Gabriel Huau , Andrew Bradford Subject: [U-Boot] [PATCH 07/10] x86: gpio: Correct calls to _ich6_gpio_set_direction() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" These calls seem to be incorrect. The function expects an I/O address but the existing callers pass the value at an I/O address. Fix it. Signed-off-by: Simon Glass --- drivers/gpio/intel_ich6_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/intel_ich6_gpio.c b/drivers/gpio/intel_ich6_gpio.c index cb408a4..fd1f287 100644 --- a/drivers/gpio/intel_ich6_gpio.c +++ b/drivers/gpio/intel_ich6_gpio.c @@ -410,7 +410,7 @@ static int ich6_gpio_direction_input(struct udevice *dev, unsigned offset) { struct ich6_bank_priv *bank = dev_get_priv(dev); - return _ich6_gpio_set_direction(inl(bank->io_sel), offset, 0); + return _ich6_gpio_set_direction(bank->io_sel, offset, 0); } static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset, @@ -419,7 +419,7 @@ static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset, int ret; struct ich6_bank_priv *bank = dev_get_priv(dev); - ret = _ich6_gpio_set_direction(inl(bank->io_sel), offset, 1); + ret = _ich6_gpio_set_direction(bank->io_sel, offset, 1); if (ret) return ret;