| Message ID | 1438414794-11730-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Superseded |
| Delegated to: | Michal Simek |
| Headers | show |
Hi, On 08/01/2015 09:39 AM, Masahiro Yamada wrote: > One disadvantage of commit a26cd04920dc (arch: Make board selection > choices optional) is that Kconfig could create such an insane > .config file that no board is selected. > > Rip off the "optional" again in favor of Zedboard as the default > target. Patch is fine but I would rather to see default option zc702 instead. Thanks, Michal
Hi Michal, 2015-08-03 23:01 GMT+09:00 Michal Simek <monstr@monstr.eu>: > Hi, > > On 08/01/2015 09:39 AM, Masahiro Yamada wrote: >> One disadvantage of commit a26cd04920dc (arch: Make board selection >> choices optional) is that Kconfig could create such an insane >> .config file that no board is selected. >> >> Rip off the "optional" again in favor of Zedboard as the default >> target. > > Patch is fine but I would rather to see default option zc702 instead. > No problem. The maintainer from the chip vendor should have the best judge about which board is suitable for the default. I am happy to take this patch back, so could you send a patch, please?
diff --git a/arch/arm/mach-zynq/Kconfig b/arch/arm/mach-zynq/Kconfig index 1de5b07..6c98195 100644 --- a/arch/arm/mach-zynq/Kconfig +++ b/arch/arm/mach-zynq/Kconfig @@ -10,7 +10,7 @@ config ZYNQ_CUSTOM_INIT choice prompt "Xilinx Zynq board select" - optional + default TARGET_ZYNQ_ZED config TARGET_ZYNQ_ZED bool "Zynq ZedBoard" diff --git a/configs/zynq_zed_defconfig b/configs/zynq_zed_defconfig index f3c63f9..6469d9e 100644 --- a/configs/zynq_zed_defconfig +++ b/configs/zynq_zed_defconfig @@ -1,6 +1,5 @@ CONFIG_ARM=y CONFIG_ARCH_ZYNQ=y -CONFIG_TARGET_ZYNQ_ZED=y CONFIG_DEFAULT_DEVICE_TREE="zynq-zed" # CONFIG_SYS_MALLOC_F is not set CONFIG_SPL=y
One disadvantage of commit a26cd04920dc (arch: Make board selection choices optional) is that Kconfig could create such an insane .config file that no board is selected. Rip off the "optional" again in favor of Zedboard as the default target. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/arm/mach-zynq/Kconfig | 2 +- configs/zynq_zed_defconfig | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)