From patchwork Fri Jul 3 00:16:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 490853 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id C7EC61402A9 for ; Fri, 3 Jul 2015 10:20:38 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b=NniFmxSb; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 496B74B6AD; Fri, 3 Jul 2015 02:20:30 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CF6zLYNqeaqA; Fri, 3 Jul 2015 02:20:30 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9D4534B6FD; Fri, 3 Jul 2015 02:19:12 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2FBFB4B616 for ; Fri, 3 Jul 2015 02:17:10 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RvcRDgTO5es0 for ; Fri, 3 Jul 2015 02:17:10 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-ig0-f170.google.com (mail-ig0-f170.google.com [209.85.213.170]) by theia.denx.de (Postfix) with ESMTPS id 296584B69E for ; Fri, 3 Jul 2015 02:17:06 +0200 (CEST) Received: by igblr2 with SMTP id lr2so131041484igb.0 for ; Thu, 02 Jul 2015 17:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ggF9EvtpzY+JD6nv6wSVwX83lketyLD/TW8RRcmG0kw=; b=NniFmxSbqOskwe9/wL+KlKOTtNZcM0geyJjhkvrpZqSRkfivbIUGRPJkVpX7npWLX0 /EDDCzrxyoQuFNjoLAuEgcDblwYGJCpEovI3LM5r3BYoJD3A/AAhkkVYg923i+csc8Bb EUA/yPa7OHvrRJUAxK2sNet/HZRdzbFTIBDlLgW5G2PukrQuQQ223LURF2Hw/g/TQS0d 6ycIk1TNtio8v+A6FM3v4M8gQEV4MDfVcAGlzDfN/i1zZp0OKcDfsvwUGYcZODWUYzoF i/JSw7M3+lFAQrTXki5NrKg9spluBS2whK4qwNc7bKDvtQ+TypsfIL+nzmHqreOqz9VX DHAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ggF9EvtpzY+JD6nv6wSVwX83lketyLD/TW8RRcmG0kw=; b=D485JfDKFQOjoRzETwYd79OJKpsG/wtAGsM8WCzuFiHpS6EB1eVufN2ACc9pA4hyoN eZ77yM+jJjzM710y6eZh+wui5OPmSPXv9fTbE471LIvx+OKeILKaQurx/AbLRuRxStSb LGc+gTizJILICSuf6bk6AGHLNbiCGEEUKianQC+0fxTc9eFJCsgj1p4mCxapYSMTvjk5 b94nUJvFpNpXR8Ua2crN1o/SuoXQjUEGj+jkkmXH/BtwHEeUP8Gxmz0MBg3yBVdlAtzL 2GhRB3x6ZajAUAxYrhioaXaCuozgpiepYuJ3s6VB+l+Y9UBtKoBZlGUM1RJAo21fIlm6 z9Uw== X-Gm-Message-State: ALoCoQnzjoSQ7EIEaYR5jULqEWVJLc4Z7O2zloK11YsXev8VjI8egz23yrJ2QJiiURXoMl9m3CuI X-Received: by 10.107.30.69 with SMTP id e66mr19111452ioe.76.1435882625325; Thu, 02 Jul 2015 17:17:05 -0700 (PDT) Received: from kaki.bld.corp.google.com ([172.29.216.32]) by smtp.gmail.com with ESMTPSA id lr1sm2328643igb.10.2015.07.02.17.16.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jul 2015 17:17:04 -0700 (PDT) Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id 65ACB220B98; Thu, 2 Jul 2015 18:16:54 -0600 (MDT) From: Simon Glass To: U-Boot Mailing List Date: Thu, 2 Jul 2015 18:16:03 -0600 Message-Id: <1435882592-487-27-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 2.4.3.573.g4eafbef In-Reply-To: <1435882592-487-1-git-send-email-sjg@chromium.org> References: <1435882592-487-1-git-send-email-sjg@chromium.org> Cc: Przemyslaw Marczak , Tom Rini Subject: [U-Boot] [PATCH 26/55] dm: pmic: Correct the pmic_reg_write() implementation X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This should write the register, not read it. Fix this bug. Signed-off-by: Simon Glass Acked-by: Przemyslaw Marczak --- drivers/power/pmic/pmic-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/pmic/pmic-uclass.c b/drivers/power/pmic/pmic-uclass.c index d99cb9a..49709f3 100644 --- a/drivers/power/pmic/pmic-uclass.c +++ b/drivers/power/pmic/pmic-uclass.c @@ -142,7 +142,7 @@ int pmic_reg_write(struct udevice *dev, uint reg, uint value) u8 byte = value; debug("%s: reg=%x, value=%x\n", __func__, reg, value); - return pmic_read(dev, reg, &byte, 1); + return pmic_write(dev, reg, &byte, 1); } int pmic_clrsetbits(struct udevice *dev, uint reg, uint clr, uint set)