| Message ID | 1435789225-7466-1-git-send-email-contact@paulk.fr |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Le jeudi 02 juillet 2015 à 00:20 +0200, Paul Kocialkowski a écrit : > Palmas power support is required for OMAP5 devices such as the OMAP5 uEVM, that > need to e.g. enable MMC power at SPL stage. > > This is especially important when booting from a peripheral (such as USB, UART), > where the bootrom will not enable power for the MMC device that will hold the > main U-Boot. I sent this a while back and it hasn't been picked up yet. Anything holding it back in particular? > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > --- > include/configs/ti_armv7_common.h | 1 + > include/configs/ti_omap5_common.h | 2 -- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h > index 0aea7d1..34756de 100644 > --- a/include/configs/ti_armv7_common.h > +++ b/include/configs/ti_armv7_common.h > @@ -261,6 +261,7 @@ > #define CONFIG_SPL_LIBCOMMON_SUPPORT > #define CONFIG_SPL_LIBGENERIC_SUPPORT > #define CONFIG_SPL_SERIAL_SUPPORT > +#define CONFIG_SPL_POWER_SUPPORT > #define CONFIG_SPL_GPIO_SUPPORT > #define CONFIG_SPL_BOARD_INIT > > diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h > index 4179a57..b33feb6 100644 > --- a/include/configs/ti_omap5_common.h > +++ b/include/configs/ti_omap5_common.h > @@ -40,9 +40,7 @@ > #define CONFIG_SYS_DEFAULT_LPDDR2_TIMINGS > #endif > > -#ifndef CONFIG_SPL_BUILD > #define CONFIG_PALMAS_POWER > -#endif > > #include <asm/arch/cpu.h> > #include <asm/arch/omap.h>
On Wed, Jul 15, 2015 at 02:56:23PM +0200, Paul Kocialkowski wrote: > Le jeudi 02 juillet 2015 à 00:20 +0200, Paul Kocialkowski a écrit : > > Palmas power support is required for OMAP5 devices such as the OMAP5 uEVM, that > > need to e.g. enable MMC power at SPL stage. > > > > This is especially important when booting from a peripheral (such as USB, UART), > > where the bootrom will not enable power for the MMC device that will hold the > > main U-Boot. > > I sent this a while back and it hasn't been picked up yet. Anything > holding it back in particular? > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > --- > > include/configs/ti_armv7_common.h | 1 + > > include/configs/ti_omap5_common.h | 2 -- > > 2 files changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h > > index 0aea7d1..34756de 100644 > > --- a/include/configs/ti_armv7_common.h > > +++ b/include/configs/ti_armv7_common.h > > @@ -261,6 +261,7 @@ > > #define CONFIG_SPL_LIBCOMMON_SUPPORT > > #define CONFIG_SPL_LIBGENERIC_SUPPORT > > #define CONFIG_SPL_SERIAL_SUPPORT > > +#define CONFIG_SPL_POWER_SUPPORT > > #define CONFIG_SPL_GPIO_SUPPORT > > #define CONFIG_SPL_BOARD_INIT > > > > diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h > > index 4179a57..b33feb6 100644 > > --- a/include/configs/ti_omap5_common.h > > +++ b/include/configs/ti_omap5_common.h > > @@ -40,9 +40,7 @@ > > #define CONFIG_SYS_DEFAULT_LPDDR2_TIMINGS > > #endif > > > > -#ifndef CONFIG_SPL_BUILD > > #define CONFIG_PALMAS_POWER > > -#endif > > > > #include <asm/arch/cpu.h> > > #include <asm/arch/omap.h> Reviewed-by: Tom Rini <trini@konsulko.com>
Le jeudi 16 juillet 2015 à 09:21 -0400, Tom Rini a écrit : > On Wed, Jul 15, 2015 at 02:56:23PM +0200, Paul Kocialkowski wrote: > > Le jeudi 02 juillet 2015 à 00:20 +0200, Paul Kocialkowski a écrit : > > > Palmas power support is required for OMAP5 devices such as the OMAP5 uEVM, that > > > need to e.g. enable MMC power at SPL stage. > > > > > > This is especially important when booting from a peripheral (such as USB, UART), > > > where the bootrom will not enable power for the MMC device that will hold the > > > main U-Boot. > > > > I sent this a while back and it hasn't been picked up yet. Anything > > holding it back in particular? > > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > > --- > > > include/configs/ti_armv7_common.h | 1 + > > > include/configs/ti_omap5_common.h | 2 -- > > > 2 files changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h > > > index 0aea7d1..34756de 100644 > > > --- a/include/configs/ti_armv7_common.h > > > +++ b/include/configs/ti_armv7_common.h > > > @@ -261,6 +261,7 @@ > > > #define CONFIG_SPL_LIBCOMMON_SUPPORT > > > #define CONFIG_SPL_LIBGENERIC_SUPPORT > > > #define CONFIG_SPL_SERIAL_SUPPORT > > > +#define CONFIG_SPL_POWER_SUPPORT > > > #define CONFIG_SPL_GPIO_SUPPORT > > > #define CONFIG_SPL_BOARD_INIT > > > > > > diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h > > > index 4179a57..b33feb6 100644 > > > --- a/include/configs/ti_omap5_common.h > > > +++ b/include/configs/ti_omap5_common.h > > > @@ -40,9 +40,7 @@ > > > #define CONFIG_SYS_DEFAULT_LPDDR2_TIMINGS > > > #endif > > > > > > -#ifndef CONFIG_SPL_BUILD > > > #define CONFIG_PALMAS_POWER > > > -#endif > > > > > > #include <asm/arch/cpu.h> > > > #include <asm/arch/omap.h> > > Reviewed-by: Tom Rini <trini@konsulko.com> Now that the merge window is open, I think we could merge that one. What do you think? Thanks!
On Thu, Jul 02, 2015 at 12:20:25AM +0200, Paul Kocialkowski wrote: > Palmas power support is required for OMAP5 devices such as the OMAP5 uEVM, that > need to e.g. enable MMC power at SPL stage. > > This is especially important when booting from a peripheral (such as USB, UART), > where the bootrom will not enable power for the MMC device that will hold the > main U-Boot. > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h index 0aea7d1..34756de 100644 --- a/include/configs/ti_armv7_common.h +++ b/include/configs/ti_armv7_common.h @@ -261,6 +261,7 @@ #define CONFIG_SPL_LIBCOMMON_SUPPORT #define CONFIG_SPL_LIBGENERIC_SUPPORT #define CONFIG_SPL_SERIAL_SUPPORT +#define CONFIG_SPL_POWER_SUPPORT #define CONFIG_SPL_GPIO_SUPPORT #define CONFIG_SPL_BOARD_INIT diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h index 4179a57..b33feb6 100644 --- a/include/configs/ti_omap5_common.h +++ b/include/configs/ti_omap5_common.h @@ -40,9 +40,7 @@ #define CONFIG_SYS_DEFAULT_LPDDR2_TIMINGS #endif -#ifndef CONFIG_SPL_BUILD #define CONFIG_PALMAS_POWER -#endif #include <asm/arch/cpu.h> #include <asm/arch/omap.h>
Palmas power support is required for OMAP5 devices such as the OMAP5 uEVM, that need to e.g. enable MMC power at SPL stage. This is especially important when booting from a peripheral (such as USB, UART), where the bootrom will not enable power for the MMC device that will hold the main U-Boot. Signed-off-by: Paul Kocialkowski <contact@paulk.fr> --- include/configs/ti_armv7_common.h | 1 + include/configs/ti_omap5_common.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-)