Message ID | 1434000106-5993-2-git-send-email-josh.wu@atmel.com |
---|---|
State | Superseded |
Delegated to: | Albert ARIBAUD |
Headers | show |
Hello Josh, Sorry this series somehow dropped off my radar completely. Is it still needed now? If it does, then it would require rework as some of the functions removed are not empty anymore. On Thu, 11 Jun 2015 13:21:45 +0800, Josh Wu <josh.wu@atmel.com> wrote: > As there are empty function invalidate_dcache_range(), flush_dcache_range() > in arch/arm/lib/cache.c. So we can reuse it by just drop them in arch/arm/cpu/. > > Signed-off-by: Josh Wu <josh.wu@atmel.com> > --- > > arch/arm/cpu/arm1136/cpu.c | 8 -------- > arch/arm/cpu/arm926ejs/cache.c | 8 -------- > arch/arm/cpu/armv7/cache_v7.c | 8 -------- > arch/arm/cpu/armv8/cache_v8.c | 8 -------- > 4 files changed, 32 deletions(-) > > diff --git a/arch/arm/cpu/arm1136/cpu.c b/arch/arm/cpu/arm1136/cpu.c > index a7aed4b..b4d1d54 100644 > --- a/arch/arm/cpu/arm1136/cpu.c > +++ b/arch/arm/cpu/arm1136/cpu.c > @@ -134,14 +134,6 @@ void flush_dcache_all(void) > { > } > > -void invalidate_dcache_range(unsigned long start, unsigned long stop) > -{ > -} > - > -void flush_dcache_range(unsigned long start, unsigned long stop) > -{ > -} > - > void flush_cache(unsigned long start, unsigned long size) > { > } > diff --git a/arch/arm/cpu/arm926ejs/cache.c b/arch/arm/cpu/arm926ejs/cache.c > index 8d7873c..99d1a13 100644 > --- a/arch/arm/cpu/arm926ejs/cache.c > +++ b/arch/arm/cpu/arm926ejs/cache.c > @@ -83,14 +83,6 @@ void flush_dcache_all(void) > { > } > > -void invalidate_dcache_range(unsigned long start, unsigned long stop) > -{ > -} > - > -void flush_dcache_range(unsigned long start, unsigned long stop) > -{ > -} > - > void flush_cache(unsigned long start, unsigned long size) > { > } > diff --git a/arch/arm/cpu/armv7/cache_v7.c b/arch/arm/cpu/armv7/cache_v7.c > index e8ee875..4f0e406 100644 > --- a/arch/arm/cpu/armv7/cache_v7.c > +++ b/arch/arm/cpu/armv7/cache_v7.c > @@ -304,14 +304,6 @@ void flush_dcache_all(void) > { > } > > -void invalidate_dcache_range(unsigned long start, unsigned long stop) > -{ > -} > - > -void flush_dcache_range(unsigned long start, unsigned long stop) > -{ > -} > - > void arm_init_before_mmu(void) > { > } > diff --git a/arch/arm/cpu/armv8/cache_v8.c b/arch/arm/cpu/armv8/cache_v8.c > index c5ec529..f8c17cc 100644 > --- a/arch/arm/cpu/armv8/cache_v8.c > +++ b/arch/arm/cpu/armv8/cache_v8.c > @@ -149,14 +149,6 @@ void flush_dcache_all(void) > { > } > > -void invalidate_dcache_range(unsigned long start, unsigned long stop) > -{ > -} > - > -void flush_dcache_range(unsigned long start, unsigned long stop) > -{ > -} > - > void dcache_enable(void) > { > } > -- > 1.9.1 > Amicalement,
On Sat, Sep 12, 2015 at 11:14:18AM +0200, Albert ARIBAUD wrote: > Hello Josh, > > Sorry this series somehow dropped off my radar completely. Is it still > needed now? If it does, then it would require rework as some of the > functions removed are not empty anymore. An updated version of this series which handled other arches has been applied now.
diff --git a/arch/arm/cpu/arm1136/cpu.c b/arch/arm/cpu/arm1136/cpu.c index a7aed4b..b4d1d54 100644 --- a/arch/arm/cpu/arm1136/cpu.c +++ b/arch/arm/cpu/arm1136/cpu.c @@ -134,14 +134,6 @@ void flush_dcache_all(void) { } -void invalidate_dcache_range(unsigned long start, unsigned long stop) -{ -} - -void flush_dcache_range(unsigned long start, unsigned long stop) -{ -} - void flush_cache(unsigned long start, unsigned long size) { } diff --git a/arch/arm/cpu/arm926ejs/cache.c b/arch/arm/cpu/arm926ejs/cache.c index 8d7873c..99d1a13 100644 --- a/arch/arm/cpu/arm926ejs/cache.c +++ b/arch/arm/cpu/arm926ejs/cache.c @@ -83,14 +83,6 @@ void flush_dcache_all(void) { } -void invalidate_dcache_range(unsigned long start, unsigned long stop) -{ -} - -void flush_dcache_range(unsigned long start, unsigned long stop) -{ -} - void flush_cache(unsigned long start, unsigned long size) { } diff --git a/arch/arm/cpu/armv7/cache_v7.c b/arch/arm/cpu/armv7/cache_v7.c index e8ee875..4f0e406 100644 --- a/arch/arm/cpu/armv7/cache_v7.c +++ b/arch/arm/cpu/armv7/cache_v7.c @@ -304,14 +304,6 @@ void flush_dcache_all(void) { } -void invalidate_dcache_range(unsigned long start, unsigned long stop) -{ -} - -void flush_dcache_range(unsigned long start, unsigned long stop) -{ -} - void arm_init_before_mmu(void) { } diff --git a/arch/arm/cpu/armv8/cache_v8.c b/arch/arm/cpu/armv8/cache_v8.c index c5ec529..f8c17cc 100644 --- a/arch/arm/cpu/armv8/cache_v8.c +++ b/arch/arm/cpu/armv8/cache_v8.c @@ -149,14 +149,6 @@ void flush_dcache_all(void) { } -void invalidate_dcache_range(unsigned long start, unsigned long stop) -{ -} - -void flush_dcache_range(unsigned long start, unsigned long stop) -{ -} - void dcache_enable(void) { }
As there are empty function invalidate_dcache_range(), flush_dcache_range() in arch/arm/lib/cache.c. So we can reuse it by just drop them in arch/arm/cpu/. Signed-off-by: Josh Wu <josh.wu@atmel.com> --- arch/arm/cpu/arm1136/cpu.c | 8 -------- arch/arm/cpu/arm926ejs/cache.c | 8 -------- arch/arm/cpu/armv7/cache_v7.c | 8 -------- arch/arm/cpu/armv8/cache_v8.c | 8 -------- 4 files changed, 32 deletions(-)