| Message ID | 1431422908-1024-1-git-send-email-nikhil.badola@freescale.com |
|---|---|
| State | Superseded |
| Delegated to: | Marek Vasut |
| Headers | show |
> -----Original Message----- > From: Nikhil Badola [mailto:nikhil.badola@freescale.com] > Sent: Tuesday, May 12, 2015 2:58 PM > To: u-boot@lists.denx.de > Cc: Badola Nikhil-B46172 > Subject: [PATCH] drivers:usb:fsl: Return if USB_MAX_CONTROLLER_COUNT > is incorrect > > Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller > to be initialised is incorrect > > Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com> > --- > drivers/usb/host/ehci-fsl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index > ed83eb4..1973e0b 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init, > break; > default: > printf("ERROR: wrong controller index!!\n"); > - break; > + return -1; > }; > > *hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength); > -- > 1.7.11.7 > CCing Marek Vasut..
On Friday, June 05, 2015 at 06:19:16 AM, Badola Nikhil wrote: > > -----Original Message----- > > From: Nikhil Badola [mailto:nikhil.badola@freescale.com] > > Sent: Tuesday, May 12, 2015 2:58 PM > > To: u-boot@lists.denx.de > > Cc: Badola Nikhil-B46172 > > Subject: [PATCH] drivers:usb:fsl: Return if USB_MAX_CONTROLLER_COUNT Hi, please do me a favor next time -- insert a space after each tag, ie. drivers: usb: fsl: .... > > is incorrect > > > > Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller > > to be initialised is incorrect > > > > Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com> > > --- > > > > drivers/usb/host/ehci-fsl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > > index ed83eb4..1973e0b 100644 > > --- a/drivers/usb/host/ehci-fsl.c > > +++ b/drivers/usb/host/ehci-fsl.c > > @@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init, > > > > break; > > > > default: > > printf("ERROR: wrong controller index!!\n"); > > > > - break; > > + return -1; Can you please use value from errno.h here , like -EINVAL ? Thanks! Best regards, Marek Vasut
> -----Original Message----- > From: Marek Vasut [mailto:marex@denx.de] > Sent: Friday, June 05, 2015 7:38 PM > To: Badola Nikhil-B46172 > Cc: u-boot@lists.denx.de > Subject: Re: [PATCH] drivers:usb:fsl: Return if > USB_MAX_CONTROLLER_COUNT is incorrect > > On Friday, June 05, 2015 at 06:19:16 AM, Badola Nikhil wrote: > > > -----Original Message----- > > > From: Nikhil Badola [mailto:nikhil.badola@freescale.com] > > > Sent: Tuesday, May 12, 2015 2:58 PM > > > To: u-boot@lists.denx.de > > > Cc: Badola Nikhil-B46172 > > > Subject: [PATCH] drivers:usb:fsl: Return if > USB_MAX_CONTROLLER_COUNT > > Hi, > > please do me a favor next time -- insert a space after each tag, ie. drivers: > usb: fsl: .... > Will take of this from next time. > > > is incorrect > > > > > > Return if USB_MAX_CONTROLLER_COUNT hence the index of the > controller > > > to be initialised is incorrect > > > > > > Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com> > > > --- > > > > > > drivers/usb/host/ehci-fsl.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/usb/host/ehci-fsl.c > > > b/drivers/usb/host/ehci-fsl.c index ed83eb4..1973e0b 100644 > > > --- a/drivers/usb/host/ehci-fsl.c > > > +++ b/drivers/usb/host/ehci-fsl.c > > > @@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type > > > init, > > > > > > break; > > > > > > default: > > > printf("ERROR: wrong controller index!!\n"); > > > > > > - break; > > > + return -1; > > Can you please use value from errno.h here , like -EINVAL ? > Will replace -1 with -EINVAL in next patch version
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index ed83eb4..1973e0b 100644 --- a/drivers/usb/host/ehci-fsl.c +++ b/drivers/usb/host/ehci-fsl.c @@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init, break; default: printf("ERROR: wrong controller index!!\n"); - break; + return -1; }; *hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller to be initialised is incorrect Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com> --- drivers/usb/host/ehci-fsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)