diff mbox

[U-Boot] serial: ns16550: Remove hard-coded baud_divisor setting

Message ID 1429930394.4708.1.camel@ingics.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Axel Lin April 25, 2015, 2:53 a.m. UTC 
This was accidentally added by commit dd0b0122bacc
"serial: ns16550: Add an option to specify the debug UART register shift".
Remove it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/serial/ns16550.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Simon Glass April 25, 2015, 3:05 a.m. UTC | #1 
On Apr 24, 2015 8:53 PM, "Axel Lin" <axel.lin@ingics.com> wrote:
>
> This was accidentally added by commit dd0b0122bacc
> "serial: ns16550: Add an option to specify the debug UART register shift".
> Remove it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/serial/ns16550.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index fd110b3..3d376d7 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -255,7 +255,6 @@ void debug_uart_init(void)
>          */
>         baud_divisor = calc_divisor(com_port, CONFIG_DEBUG_UART_CLOCK,
>                                     CONFIG_BAUDRATE);
> -       baud_divisor = 13;
>         serial_out_shift(&com_port->ier, CONFIG_DEBUG_UART_SHIFT,
>                          CONFIG_SYS_NS16550_IER);
>         serial_out_shift(&com_port->mcr, CONFIG_DEBUG_UART_SHIFT,
UART_MCRVAL);
> --
> 2.1.0
>
>
>

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass April 25, 2015, 2:22 p.m. UTC | #2 
On 24 April 2015 at 21:05, Simon Glass <sjg@chromium.org> wrote:
>
> On Apr 24, 2015 8:53 PM, "Axel Lin" <axel.lin@ingics.com> wrote:
>>
>> This was accidentally added by commit dd0b0122bacc
>> "serial: ns16550: Add an option to specify the debug UART register shift".
>> Remove it.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>>  drivers/serial/ns16550.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
>> index fd110b3..3d376d7 100644
>> --- a/drivers/serial/ns16550.c
>> +++ b/drivers/serial/ns16550.c
>> @@ -255,7 +255,6 @@ void debug_uart_init(void)
>>          */
>>         baud_divisor = calc_divisor(com_port, CONFIG_DEBUG_UART_CLOCK,
>>                                     CONFIG_BAUDRATE);
>> -       baud_divisor = 13;
>>         serial_out_shift(&com_port->ier, CONFIG_DEBUG_UART_SHIFT,
>>                          CONFIG_SYS_NS16550_IER);
>>         serial_out_shift(&com_port->mcr, CONFIG_DEBUG_UART_SHIFT,
>> UART_MCRVAL);
>> --
>> 2.1.0
>>
>>
>>
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!
diff mbox

Patch

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index fd110b3..3d376d7 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -255,7 +255,6 @@  void debug_uart_init(void)
 	 */
 	baud_divisor = calc_divisor(com_port, CONFIG_DEBUG_UART_CLOCK,
 				    CONFIG_BAUDRATE);
-	baud_divisor = 13;
 	serial_out_shift(&com_port->ier, CONFIG_DEBUG_UART_SHIFT,
 			 CONFIG_SYS_NS16550_IER);
 	serial_out_shift(&com_port->mcr, CONFIG_DEBUG_UART_SHIFT, UART_MCRVAL);