diff mbox

[U-Boot,v2] ARM: tegra: update colibri_t20 configuration

Message ID 1427332647-13415-1-git-send-email-marcel@ziswiler.com
State Accepted
Delegated to: Tom Warren
Headers show

Commit Message

Marcel Ziswiler March 26, 2015, 1:17 a.m. UTC
Bring the Colibri T20 configuration in-line with Apalis/Colibri T30.

Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
---
Changes in v2:
- added my previously missing signed-off-by

 include/configs/colibri_t20.h | 31 +++++++++++++++++++++++++++----
 1 file changed, 27 insertions(+), 4 deletions(-)

Comments

Stephen Warren March 26, 2015, 2:18 p.m. UTC | #1
On 03/25/2015 07:17 PM, Marcel Ziswiler wrote:
> Bring the Colibri T20 configuration in-line with Apalis/Colibri T30.

I assume all the white-space and line reordering changes are so that a 
diff of colibri_t20.h and colibri_t30.h shows minimal differences?

> diff --git a/include/configs/colibri_t20.h b/include/configs/colibri_t20.h

> +/* General networking support */
>   #define CONFIG_CMD_NET
>   #define CONFIG_CMD_DHCP
> -#define CONFIG_CMD_NFS
> -#define CONFIG_CMD_PING

It might warrant some explanation why those appear to be removed. Are 
they enabled by default anyway?

> +/* Miscellaneous commands */
> +#define CONFIG_CMD_SETEXPR
> +#define CONFIG_FAT_WRITE
> +
> +/* Increase console I/O buffer size */
> +#undef CONFIG_SYS_CBSIZE
> +#define CONFIG_SYS_CBSIZE		1024
> +
> +/* Increase arguments buffer size */
> +#undef CONFIG_SYS_BARGSIZE
> +#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
> +
> +/* Increase print buffer size */
> +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
> +
> +/* Increase maximum number of arguments */
> +#undef CONFIG_SYS_MAXARGS
> +#define CONFIG_SYS_MAXARGS		32

Is any of that generally useful to other boards; do we want to add those 
lines to tegra*-common*.h instead?

(IIRC some of the command-line size related variables enable the 
ridiculously long kernel command-lines required to boot our downstream 
kernel, so would be useful on at least some other boards. Hence, 
enabling everywhere might be simplest).
Marcel Ziswiler March 26, 2015, 5:33 p.m. UTC | #2
On 26 March 2015 15:18:56 CET, Stephen Warren <swarren@wwwdotorg.org> wrote:
>I assume all the white-space and line reordering changes are so that a 
>diff of colibri_t20.h and colibri_t30.h shows minimal differences?

Exactly.

>> -#define CONFIG_CMD_NFS
>> -#define CONFIG_CMD_PING
>
>It might warrant some explanation why those appear to be removed. Are 
>they enabled by default anyway?

NFS is actually explicitly undefined in tegra-common and we never ever used from within U-Boot before.

And PING gets already pulled in by the distro_defaults.


>Is any of that generally useful to other boards; do we want to add
>those 
>lines to tegra*-common*.h instead?
>
>(IIRC some of the command-line size related variables enable the 
>ridiculously long kernel command-lines required to boot our downstream 
>kernel, so would be useful on at least some other boards. Hence, 
>enabling everywhere might be simplest).

Remember I already got those added to our Apalis and Colibri T30 configurations. We require it for our update scripts as well as to boot downstream L4T. So if you deem that useful in general sure, I can as well cook up a patch for that.
diff mbox

Patch

diff --git a/include/configs/colibri_t20.h b/include/configs/colibri_t20.h
index e80e9ed..c17f245 100644
--- a/include/configs/colibri_t20.h
+++ b/include/configs/colibri_t20.h
@@ -14,9 +14,12 @@ 
 #define CONFIG_TEGRA_BOARD_STRING	"Toradex Colibri T20"
 
 /* Board-specific serial config */
+#define CONFIG_SERIAL_MULTI
 #define CONFIG_TEGRA_ENABLE_UARTA
 #define CONFIG_TEGRA_UARTA_SDIO1
-#define CONFIG_SYS_NS16550_COM1    NV_PA_APB_UARTA_BASE
+#define CONFIG_SYS_NS16550_COM1		NV_PA_APB_UARTA_BASE
+
+#define CONFIG_MACH_TYPE		MACH_TYPE_COLIBRI_T20
 
 /* SD/MMC support */
 #define CONFIG_MMC
@@ -29,17 +32,17 @@ 
 #define CONFIG_USB_EHCI_TEGRA
 #define CONFIG_USB_ULPI
 #define CONFIG_USB_ULPI_VIEWPORT
-#define CONFIG_USB_STORAGE
 #define CONFIG_USB_MAX_CONTROLLER_COUNT 3
+#define CONFIG_USB_STORAGE
 #define CONFIG_CMD_USB
 
 /* USB networking support */
 #define CONFIG_USB_HOST_ETHER
 #define CONFIG_USB_ETHER_ASIX
+
+/* General networking support */
 #define CONFIG_CMD_NET
 #define CONFIG_CMD_DHCP
-#define CONFIG_CMD_NFS
-#define CONFIG_CMD_PING
 
 /* NAND support */
 #define CONFIG_CMD_NAND
@@ -56,6 +59,26 @@ 
 #define CONFIG_CMD_BDI
 #define CONFIG_CMD_CACHE
 
+/* Miscellaneous commands */
+#define CONFIG_CMD_SETEXPR
+#define CONFIG_FAT_WRITE
+
+/* Increase console I/O buffer size */
+#undef CONFIG_SYS_CBSIZE
+#define CONFIG_SYS_CBSIZE		1024
+
+/* Increase arguments buffer size */
+#undef CONFIG_SYS_BARGSIZE
+#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
+
+/* Increase print buffer size */
+#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* Increase maximum number of arguments */
+#undef CONFIG_SYS_MAXARGS
+#define CONFIG_SYS_MAXARGS		32
+
+#include "tegra-common-usb-gadget.h"
 #include "tegra-common-post.h"
 
 #endif /* __CONFIG_H */