From patchwork Wed Mar 11 12:57:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Schmelzer X-Patchwork-Id: 448988 X-Patchwork-Delegate: agust@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 70B68140187 for ; Thu, 12 Mar 2015 00:18:17 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id F058BA7439; Wed, 11 Mar 2015 14:18:09 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NI8CS2FlWtf0; Wed, 11 Mar 2015 14:18:09 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 09685A743B; Wed, 11 Mar 2015 14:18:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4E795A742E for ; Wed, 11 Mar 2015 14:18:00 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5BR_6ewRf3Ff for ; Wed, 11 Mar 2015 14:18:00 +0100 (CET) X-Greylist: delayed 1215 seconds by postgrey-1.34 at theia; Wed, 11 Mar 2015 14:17:56 CET X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from s15287728.onlinehome-server.info (hamspirit.at [87.106.47.214]) by theia.denx.de (Postfix) with ESMTP id 13F05A741D for ; Wed, 11 Mar 2015 14:17:56 +0100 (CET) Received: from localhost (s15287728.onlinehome-server.info [127.0.0.1]) by s15287728.onlinehome-server.info (Postfix) with ESMTP id 164618F480C7; Wed, 11 Mar 2015 12:57:48 +0000 (UTC) Received: from s15287728.onlinehome-server.info ([127.0.0.1]) by localhost (s15287728.onlinehome-server.info [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5Ub-9Gi1EPW3; Wed, 11 Mar 2015 12:57:45 +0000 (UTC) Received: from hannes-werkstatt.scm.lan (93-82-76-197.adsl.highway.telekom.at [93.82.76.197]) by s15287728.onlinehome-server.info (Postfix) with ESMTP id 101838F480C9; Wed, 11 Mar 2015 12:57:38 +0000 (UTC) From: Hannes Petermaier To: u-boot@lists.denx.de Date: Wed, 11 Mar 2015 13:57:23 +0100 Message-Id: <1426078645-4901-3-git-send-email-oe5hpm@oevsv.at> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1426078645-4901-1-git-send-email-oe5hpm@oevsv.at> References: <1426078645-4901-1-git-send-email-oe5hpm@oevsv.at> Cc: Tom Rini , sjg@google.com Subject: [U-Boot] [PATCH 2/4] common/lcd_console: ask only one-time for bg/fg-color per call X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Hannes Petermaier Don't call the lcd_getfgcolor and lcd_getbgcolor within the "draw-loop", this only wastes time. Signed-off-by: Hannes Petermaier Signed-off-by: Hannes Petermaier Acked-by: Nikita Kiryanov --- common/lcd_console.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/common/lcd_console.c b/common/lcd_console.c index 243b7c5..b7dda7a 100644 --- a/common/lcd_console.c +++ b/common/lcd_console.c @@ -59,7 +59,8 @@ static void lcd_putc_xy(ushort x, ushort y, char c) { uchar *dest; ushort row; - int fg_color, bg_color; + int fg_color = lcd_getfgcolor(); + int bg_color = lcd_getbgcolor(); int i; dest = (uchar *)(lcd_console_address + @@ -73,10 +74,6 @@ static void lcd_putc_xy(ushort x, ushort y, char c) #else uchar *d = dest; #endif - - fg_color = lcd_getfgcolor(); - bg_color = lcd_getbgcolor(); - uchar bits; bits = video_fontdata[c * VIDEO_FONT_HEIGHT + row];