| Message ID | 1424693349-12252-2-git-send-email-fabio.estevam@freescale.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
Hi Fabio, On 23/02/2015 13:09, Fabio Estevam wrote: > Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx35 > does not boot anymore. > > Add a specific relocate_vectors macro that skips the vector relocation, as the > i.MX35 SoC does not provide RAM at the high vectors address (0xFFFF0000), and > (0x00000000) maps to ROM. > > This allows mx35 to boot again. > > Cc: Sebastian Priebe <sebastian.priebe@cadcon.de> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > Sebastian, > > I don't have access to a mx35 board. > > Could you please test this patch? > > Thanks > Thanks for the patch ! I have found again a mx35pdk and I could test your patch. 2015.04-rc1 is running on that. Tested-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic
diff --git a/arch/arm/cpu/arm1136/mx35/Makefile b/arch/arm/cpu/arm1136/mx35/Makefile index c533215..796db9c 100644 --- a/arch/arm/cpu/arm1136/mx35/Makefile +++ b/arch/arm/cpu/arm1136/mx35/Makefile @@ -10,3 +10,7 @@ obj-y += generic.o obj-y += timer.o obj-y += mx35_sdram.o + +ifndef CONFIG_SPL_BUILD +obj-y += relocate.o +endif diff --git a/arch/arm/cpu/arm1136/mx35/relocate.S b/arch/arm/cpu/arm1136/mx35/relocate.S new file mode 100644 index 0000000..43003f8 --- /dev/null +++ b/arch/arm/cpu/arm1136/mx35/relocate.S @@ -0,0 +1,23 @@ +/* + * relocate - i.MX35-specific vector relocation + * + * Copyright (c) 2013 Albert ARIBAUD <albert.u.boot@aribaud.net> + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#include <linux/linkage.h> + +/* + * The i.MX35 SoC is very specific with respect to exceptions: it + * does not provide RAM at the high vectors address (0xFFFF0000), + * thus only the low address (0x00000000) is useable; but that is + * in ROM, so let's avoid relocating the vectors. + */ + .section .text.relocate_vectors,"ax",%progbits + +ENTRY(relocate_vectors) + + bx lr + +ENDPROC(relocate_vectors)
Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx35 does not boot anymore. Add a specific relocate_vectors macro that skips the vector relocation, as the i.MX35 SoC does not provide RAM at the high vectors address (0xFFFF0000), and (0x00000000) maps to ROM. This allows mx35 to boot again. Cc: Sebastian Priebe <sebastian.priebe@cadcon.de> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- Sebastian, I don't have access to a mx35 board. Could you please test this patch? Thanks arch/arm/cpu/arm1136/mx35/Makefile | 4 ++++ arch/arm/cpu/arm1136/mx35/relocate.S | 23 +++++++++++++++++++++++ 2 files changed, 27 insertions(+) create mode 100644 arch/arm/cpu/arm1136/mx35/relocate.S