| Message ID | 1423838830-23758-1-git-send-email-samuel.egli@siemens.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Fri, Feb 13, 2015 at 03:47:10PM +0100, Egli, Samuel wrote: > The patch c316f577b4b72d1a1aeb559e9b3fad20808f1ffd breaks > siemens boards because prefetch mode is not enabled. > I assume it breaks other boards as well that don't use > prefetch. > > This patch sets read_buf to nand_read_buf if > NAND_OMAP_GPMC_PREFETCH is not defined. > > Signed-off-by: Samuel Egli <samuel.egli@siemens.com> > CC: Daniel Mack <zonque@gmail.com> > CC: Guido MartÃnez <guido@vanguardiasur.com.ar> > CC: Tom Rini <trini@ti.com> > CC: Heiko Schocher <hs@denx.de> Applied to u-boot/master, thanks!
diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c index fc64f48..24123fc 100644 --- a/drivers/mtd/nand/omap_gpmc.c +++ b/drivers/mtd/nand/omap_gpmc.c @@ -989,12 +989,15 @@ int board_nand_init(struct nand_chip *nand) if (err) return err; -#ifdef CONFIG_NAND_OMAP_GPMC_PREFETCH /* TODO: Implement for 16-bit bus width */ if (nand->options & NAND_BUSWIDTH_16) nand->read_buf = nand_read_buf16; +#ifdef CONFIG_NAND_OMAP_GPMC_PREFETCH else nand->read_buf = omap_nand_read_prefetch8; +#else + else + nand->read_buf = nand_read_buf; #endif nand->dev_ready = omap_dev_ready;
The patch c316f577b4b72d1a1aeb559e9b3fad20808f1ffd breaks siemens boards because prefetch mode is not enabled. I assume it breaks other boards as well that don't use prefetch. This patch sets read_buf to nand_read_buf if NAND_OMAP_GPMC_PREFETCH is not defined. Signed-off-by: Samuel Egli <samuel.egli@siemens.com> CC: Daniel Mack <zonque@gmail.com> CC: Guido MartÃnez <guido@vanguardiasur.com.ar> CC: Tom Rini <trini@ti.com> CC: Heiko Schocher <hs@denx.de> --- drivers/mtd/nand/omap_gpmc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)