diff mbox

[U-Boot,3/8] dm: core: remove unnecessary return condition in driver lookup

Message ID 1416212385-23800-4-git-send-email-yamada.m@jp.panasonic.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Masahiro Yamada Nov. 17, 2014, 8:19 a.m. UTC 
The variable "drv" never becomes NULL because ll_entry_start()
always returns a valid pointer even if there are no entries.

The case "n_ents == 0" is covered by the following "for" loop.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 drivers/core/lists.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Simon Glass Nov. 17, 2014, 9:14 a.m. UTC | #1 
On 17 November 2014 08:19, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> The variable "drv" never becomes NULL because ll_entry_start()
> always returns a valid pointer even if there are no entries.
>
> The case "n_ents == 0" is covered by the following "for" loop.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass Nov. 23, 2014, 1 p.m. UTC | #2 
On 17 November 2014 at 02:14, Simon Glass <sjg@chromium.org> wrote:
> On 17 November 2014 08:19, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
>> The variable "drv" never becomes NULL because ll_entry_start()
>> always returns a valid pointer even if there are no entries.
>>
>> The case "n_ents == 0" is covered by the following "for" loop.
>>
>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm.
diff mbox

Patch

diff --git a/drivers/core/lists.c b/drivers/core/lists.c
index 0aad56d..0c58ec4 100644
--- a/drivers/core/lists.c
+++ b/drivers/core/lists.c
@@ -25,9 +25,6 @@  struct driver *lists_driver_lookup_name(const char *name)
 	const int n_ents = ll_entry_count(struct driver, driver);
 	struct driver *entry;
 
-	if (!drv || !n_ents)
-		return NULL;
-
 	for (entry = drv; entry != drv + n_ents; entry++) {
 		if (!strcmp(name, entry->name))
 			return entry;