diff mbox

[U-Boot] usb: ehci: fix Interrupt on Doorbell flag of USBCMD

Message ID 1415196670-11107-1-git-send-email-yamada.m@jp.panasonic.com
State Accepted
Delegated to: Marek Vasut
Headers show

Commit Message

Masahiro Yamada Nov. 5, 2014, 2:11 p.m. UTC 
CMD_IAAD (Interrupt on Async Advance Doorbell) is bit 6, not bit 5.
While we are here, sort the flags.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 drivers/usb/host/ehci.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Marek Vasut Nov. 6, 2014, 8:09 p.m. UTC | #1 
On Wednesday, November 05, 2014 at 03:11:10 PM, Masahiro Yamada wrote:
> CMD_IAAD (Interrupt on Async Advance Doorbell) is bit 6, not bit 5.
> While we are here, sort the flags.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Nice catch, applied, thanks!

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index 433e703..79aecd4 100644
--- a/drivers/usb/host/ehci.h
+++ b/drivers/usb/host/ehci.h
@@ -47,9 +47,9 @@  struct ehci_hcor {
 	uint32_t or_usbcmd;
 #define CMD_PARK	(1 << 11)		/* enable "park" */
 #define CMD_PARK_CNT(c)	(((c) >> 8) & 3)	/* how many transfers to park */
-#define CMD_ASE		(1 << 5)		/* async schedule enable */
 #define CMD_LRESET	(1 << 7)		/* partial reset */
-#define CMD_IAAD	(1 << 5)		/* "doorbell" interrupt */
+#define CMD_IAAD	(1 << 6)		/* "doorbell" interrupt */
+#define CMD_ASE		(1 << 5)		/* async schedule enable */
 #define CMD_PSE		(1 << 4)		/* periodic schedule enable */
 #define CMD_RESET	(1 << 1)		/* reset HC not bus */
 #define CMD_RUN		(1 << 0)		/* start/stop HC */