From patchwork Thu Oct 16 07:05:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 400149 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id B81F41400D2 for ; Thu, 16 Oct 2014 18:06:25 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 19A3EA7431; Thu, 16 Oct 2014 09:06:17 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aX7b1zmNssZD; Thu, 16 Oct 2014 09:06:16 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id DA33CA741C; Thu, 16 Oct 2014 09:06:14 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C14EEA73F9 for ; Thu, 16 Oct 2014 09:06:07 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B5v2J1vrosH1 for ; Thu, 16 Oct 2014 09:06:07 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-qa0-f73.google.com (mail-qa0-f73.google.com [209.85.216.73]) by theia.denx.de (Postfix) with ESMTPS id 69FA5A73F5 for ; Thu, 16 Oct 2014 09:06:03 +0200 (CEST) Received: by mail-qa0-f73.google.com with SMTP id cm18so222229qab.4 for ; Thu, 16 Oct 2014 00:06:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=q7W4W3aPy8h3gfRpoMUmSNIAbXamu7gPcD4ktXlIXmQ=; b=TD351rh0bAKWURD7lr7g3+0U/OSvAsHhWJah6sUJR9pBxaWngs86tTmMWZ+6FnA6PE Bp2JNmVicgMA/8bxR8ln2esbxrjLiasCGdJqQNngEjGaCaHDTGzsKwkbJWjtZ6PokOFG 2YhjGQu84k1s1AbqIDjhlCYloq/zf1DfDQWWEtkFJieYGbckOlrFMuWSmWznXfutrC7c 1ziuTIRgHfocJ5tBlOMVnKDZ+o8gqFABnl2RCm6PUXbr5f7BwqfTx9hRAXuYS7iAVfZh T+a7TjeQC9xnCzpHg1kkovuS8OUkUCmt37Hf3k95mapLNCJc/qzJflboWLlnXxWKbTQR lsbg== X-Gm-Message-State: ALoCoQlLEssp2L6874xLt6wrF8YbLJbGiTG9yITuX7CzRiG38Q8ZqO7K+BBw0TDmOThlPMZ1CPNP X-Received: by 10.236.223.69 with SMTP id u65mr12018515yhp.43.1413443162574; Thu, 16 Oct 2014 00:06:02 -0700 (PDT) Received: from corpmail-nozzle1-2.hot.corp.google.com ([100.108.1.103]) by gmr-mx.google.com with ESMTPS id k66si1071920yho.7.2014.10.16.00.06.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Oct 2014 00:06:02 -0700 (PDT) Received: from kaki.bld.corp.google.com ([172.29.216.32]) by corpmail-nozzle1-2.hot.corp.google.com with ESMTP id b7Y85iB7.1; Thu, 16 Oct 2014 00:06:02 -0700 Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id EB95B221078; Thu, 16 Oct 2014 01:06:01 -0600 (MDT) From: Simon Glass To: U-Boot Mailing List Date: Thu, 16 Oct 2014 01:05:56 -0600 Message-Id: <1413443156-28396-2-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 2.1.0.rc2.206.gedb03e5 In-Reply-To: <1413443156-28396-1-git-send-email-sjg@chromium.org> References: <1413443156-28396-1-git-send-email-sjg@chromium.org> Subject: [U-Boot] [PATCH 2/2] buildman: Don't default to -e when building current source X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.13 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de We probably don't need to enable this option by default. It is useful to display only failure boards (not errors) and it is easy to add -e if it is required. Also update the docs. Signed-off-by: Simon Glass Reported-by: Albert Aribaud --- tools/buildman/README | 25 ++++++++++++------------- tools/buildman/control.py | 1 - 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/tools/buildman/README b/tools/buildman/README index 8ba19ec..bfb2f18 100644 --- a/tools/buildman/README +++ b/tools/buildman/README @@ -85,10 +85,10 @@ branch. Put all your commits in a branch, set the branch's upstream to a valid value, and all will be well. Otherwise buildman will perform random actions. Use -n to check what the random actions might be. -If you just want to build the current source tree, leave off the -b flag. -This will display results and errors as they happen. You can still look -at them later using -s. Note that buildman will assume that the source -has changed, and will build all specified boards in this case. +If you just want to build the current source tree, leave off the -b flag +and add -e. This will display results and errors as they happen. You can +still look at them later using -se. Note that buildman will assume that the +source has changed, and will build all specified boards in this case. Buildman is optimised for building many commits at once, for many boards. On multi-core machines, Buildman is fast because it uses most of the @@ -693,9 +693,9 @@ Quick Sanity Check ================== If you have made changes and want to do a quick sanity check of the -currently-checked-out source, run buildman without the -b flag. This will -build the selected boards and display build status and errors as it runs -(i.e. -v amd -e are enabled automatically). +currently checked-out source, run buildman without the -b flag. This will +build the selected boards and display build status as it runs (i.e. -v is +enabled automatically). Use -e to see errors/warnings as well. Other options @@ -752,7 +752,7 @@ an error and green indicating that a commit fixed an error. Use the -e flag to see the full errors and -l to see which boards caused which errors. If you really want to see build results as they happen, use -v when doing a -build (-e will be enabled automatically). +build (and -e to see the errors/warnings too). You don't need to stick around on that branch while buildman is running. It checks out its own copy of the source code, so you can change branches, @@ -816,11 +816,10 @@ TODO This has mostly be written in my spare time as a response to my difficulties in testing large series of patches. Apart from tidying up there is quite a -bit of scope for improvement. Things like better error diffs, easier access -to log files, error display while building. Also it would be nice it buildman -could 'hunt' for problems, perhaps by building a few boards for each arch, -or checking commits for changed files and building only boards which use -those files. +bit of scope for improvement. Things like better error diffs and easier +access to log files. Also it would be nice it buildman could 'hunt' for +problems, perhaps by building a few boards for each arch, or checking +commits for changed files and building only boards which use those files. Credits diff --git a/tools/buildman/control.py b/tools/buildman/control.py index 8b8c826..c8dc217 100644 --- a/tools/buildman/control.py +++ b/tools/buildman/control.py @@ -188,7 +188,6 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None, else: series = None options.verbose = True - options.show_errors = True # By default we have one thread per CPU. But if there are not enough jobs # we can have fewer threads and use a high '-j' value for make.