Message ID | 1412801889-14400-26-git-send-email-jeroen@myspectrum.nl |
---|---|
State | Rejected |
Delegated to: | Tom Rini |
Headers | show |
On Wed, Oct 08, 2014 at 10:57:45PM +0200, Jeroen Hofstee wrote: > Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl> > --- > drivers/power/power_spi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/power_spi.c b/drivers/power/power_spi.c > index fb455a0..0560ea5 100644 > --- a/drivers/power/power_spi.c > +++ b/drivers/power/power_spi.c > @@ -17,13 +17,13 @@ > > static struct spi_slave *slave; > > -void pmic_spi_free(struct spi_slave *slave) > +static void pmic_spi_free(struct spi_slave *slave) > { > if (slave) > spi_free_slave(slave); > } > > -struct spi_slave *pmic_spi_probe(struct pmic *p) > +static struct spi_slave *pmic_spi_probe(struct pmic *p) > { > return spi_setup_slave(p->bus, > p->hw.spi.cs, So, this exposes some problems with the driver. pmic_spi_free isn't ever used, and shouldn't be. I'm going to take a stab at fixing things.
diff --git a/drivers/power/power_spi.c b/drivers/power/power_spi.c index fb455a0..0560ea5 100644 --- a/drivers/power/power_spi.c +++ b/drivers/power/power_spi.c @@ -17,13 +17,13 @@ static struct spi_slave *slave; -void pmic_spi_free(struct spi_slave *slave) +static void pmic_spi_free(struct spi_slave *slave) { if (slave) spi_free_slave(slave); } -struct spi_slave *pmic_spi_probe(struct pmic *p) +static struct spi_slave *pmic_spi_probe(struct pmic *p) { return spi_setup_slave(p->bus, p->hw.spi.cs,
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl> --- drivers/power/power_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)