Message ID | 1408327396-19630-1-git-send-email-yangbo.lu@freescale.com |
---|---|
State | Superseded, archived |
Delegated to: | York Sun |
Headers | show |
Yangbo, On 8/17/14 7:03 PM, "Yangbo Lu" <yangbo.lu@freescale.com> wrote: >Enable these boards mtdparts for nor flash: >p1020rdb-pd, p1021rdb-pc, p1022ds, p1025twr, and p2020rdb-pc. > >Signed-off-by: Xie Xiaobo <X.Xie@freescale.com> >Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com> >Cc: York Sun <yorksun@freescale.com> >Cc: Scott Wood <scottwood@freescale.com> >--- >Changes for v2: > - changed commit message > - fixed max line length problem in code >Changes for v3: > - added a Cc to York Sun >--- > include/configs/P1022DS.h | 12 ++++++++++++ > include/configs/p1_p2_rdb_pc.h | 31 +++++++++++++++++++++++++++++++ > include/configs/p1_twr.h | 12 ++++++++++++ > 3 files changed, 55 insertions(+) > >diff --git a/include/configs/P1022DS.h b/include/configs/P1022DS.h >index 139d4fe..4480270 100644 >--- a/include/configs/P1022DS.h >+++ b/include/configs/P1022DS.h >@@ -620,6 +620,18 @@ > #endif > > /* >+ * Dynamic MTD Partition support with mtdparts >+ */ >+#define CONFIG_MTD_DEVICE >+#define CONFIG_MTD_PARTITIONS >+#define CONFIG_CMD_MTDPARTS >+#define CONFIG_FLASH_CFI_MTD >+#define MTDIDS_DEFAULT "nor0=e8000000.nor" >+#define MTDPARTS_DEFAULT "mtdparts=e8000000.nor:48m(ramdisk)," \ >+ "14m(diagnostic),2m(dink),6m(kernel),58112k(fs)," \ >+ "512k(dtb),768k(u-boot)" >+ Don't you need to consider both 32- and 36-bit physical address for the flash base here? The same comment applies to p1_p2_rdb_pc.h as well. York >
On 08/17/2014 07:43 PM, York Sun wrote: > Yangbo, > > On 8/17/14 7:03 PM, "Yangbo Lu" <yangbo.lu@freescale.com> wrote: > >> Enable these boards mtdparts for nor flash: >> p1020rdb-pd, p1021rdb-pc, p1022ds, p1025twr, and p2020rdb-pc. >> >> Signed-off-by: Xie Xiaobo <X.Xie@freescale.com> >> Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com> >> Cc: York Sun <yorksun@freescale.com> >> Cc: Scott Wood <scottwood@freescale.com> >> --- >> Changes for v2: >> - changed commit message >> - fixed max line length problem in code >> Changes for v3: >> - added a Cc to York Sun >> --- >> include/configs/P1022DS.h | 12 ++++++++++++ >> include/configs/p1_p2_rdb_pc.h | 31 +++++++++++++++++++++++++++++++ >> include/configs/p1_twr.h | 12 ++++++++++++ >> 3 files changed, 55 insertions(+) >> >> diff --git a/include/configs/P1022DS.h b/include/configs/P1022DS.h >> index 139d4fe..4480270 100644 >> --- a/include/configs/P1022DS.h >> +++ b/include/configs/P1022DS.h >> @@ -620,6 +620,18 @@ >> #endif >> >> /* >> + * Dynamic MTD Partition support with mtdparts >> + */ >> +#define CONFIG_MTD_DEVICE >> +#define CONFIG_MTD_PARTITIONS >> +#define CONFIG_CMD_MTDPARTS >> +#define CONFIG_FLASH_CFI_MTD >> +#define MTDIDS_DEFAULT "nor0=e8000000.nor" >> +#define MTDPARTS_DEFAULT "mtdparts=e8000000.nor:48m(ramdisk)," \ >> + "14m(diagnostic),2m(dink),6m(kernel),58112k(fs)," \ >> + "512k(dtb),768k(u-boot)" >> + > > Don't you need to consider both 32- and 36-bit physical address for the > flash base here? The same comment applies to p1_p2_rdb_pc.h as well. > Please respond. York
diff --git a/include/configs/P1022DS.h b/include/configs/P1022DS.h index 139d4fe..4480270 100644 --- a/include/configs/P1022DS.h +++ b/include/configs/P1022DS.h @@ -620,6 +620,18 @@ #endif /* + * Dynamic MTD Partition support with mtdparts + */ +#define CONFIG_MTD_DEVICE +#define CONFIG_MTD_PARTITIONS +#define CONFIG_CMD_MTDPARTS +#define CONFIG_FLASH_CFI_MTD +#define MTDIDS_DEFAULT "nor0=e8000000.nor" +#define MTDPARTS_DEFAULT "mtdparts=e8000000.nor:48m(ramdisk)," \ + "14m(diagnostic),2m(dink),6m(kernel),58112k(fs)," \ + "512k(dtb),768k(u-boot)" + +/* * Environment */ #ifdef CONFIG_SPIFLASH diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_pc.h index 07b6179..1ed8838 100644 --- a/include/configs/p1_p2_rdb_pc.h +++ b/include/configs/p1_p2_rdb_pc.h @@ -77,6 +77,16 @@ #define __SW_BOOT_NAND 0x44 #define __SW_BOOT_PCIE 0x74 #define CONFIG_SYS_L2_SIZE (256 << 10) +/* + * Dynamic MTD Partition support with mtdparts + */ +#define CONFIG_MTD_DEVICE +#define CONFIG_MTD_PARTITIONS +#define CONFIG_CMD_MTDPARTS +#define CONFIG_FLASH_CFI_MTD +#define MTDIDS_DEFAULT "nor0=ec000000.nor" +#define MTDPARTS_DEFAULT "mtdparts=ec000000.nor:128k(dtb),6016k(kernel)," \ + "57088k(fs),1m(vsc7385-firmware),1280k(u-boot)" #endif #if defined(CONFIG_P1021RDB) @@ -95,6 +105,17 @@ #define __SW_BOOT_NAND 0xec #define __SW_BOOT_PCIE 0x6c #define CONFIG_SYS_L2_SIZE (256 << 10) +/* + * Dynamic MTD Partition support with mtdparts + */ +#define CONFIG_MTD_DEVICE +#define CONFIG_MTD_PARTITIONS +#define CONFIG_CMD_MTDPARTS +#define CONFIG_FLASH_CFI_MTD +#define MTDIDS_DEFAULT "nor0=ef000000.nor" +#define MTDPARTS_DEFAULT "mtdparts=ef000000.nor:256k(vsc7385-firmware)," \ + "256k(dtb),4608k(kernel),9728k(fs)," \ + "256k(qe-ucode-firmware),1280k(u-boot)" #endif #if defined(CONFIG_P1024RDB) @@ -142,6 +163,16 @@ #define __SW_BOOT_NAND 0xe8 #define __SW_BOOT_PCIE 0xa8 #define CONFIG_SYS_L2_SIZE (512 << 10) +/* + * Dynamic MTD Partition support with mtdparts + */ +#define CONFIG_MTD_DEVICE +#define CONFIG_MTD_PARTITIONS +#define CONFIG_CMD_MTDPARTS +#define CONFIG_FLASH_CFI_MTD +#define MTDIDS_DEFAULT "nor0=ef000000.nor" +#define MTDPARTS_DEFAULT "mtdparts=ef000000.nor:256k(vsc7385-firmware)," \ + "256k(dtb),4608k(kernel),9984k(fs),1280k(u-boot)" #endif #ifdef CONFIG_SDCARD diff --git a/include/configs/p1_twr.h b/include/configs/p1_twr.h index c296a07..d3093f5 100644 --- a/include/configs/p1_twr.h +++ b/include/configs/p1_twr.h @@ -389,6 +389,18 @@ extern unsigned long get_board_sys_clk(unsigned long dummy); #endif /* CONFIG_TWR-P1025 */ /* + * Dynamic MTD Partition support with mtdparts + */ +#define CONFIG_MTD_DEVICE +#define CONFIG_MTD_PARTITIONS +#define CONFIG_CMD_MTDPARTS +#define CONFIG_FLASH_CFI_MTD +#define MTDIDS_DEFAULT "nor0=ec000000.nor" +#define MTDPARTS_DEFAULT "mtdparts=ec000000.nor:256k(vsc7385-firmware)," \ + "256k(dtb),5632k(kernel),57856k(fs)," \ + "256k(qe-ucode-firmware),1280k(u-boot)" + +/* * Environment */ #ifdef CONFIG_SYS_RAMBOOT