Message ID | 1404260278-29907-1-git-send-email-luka@openwrt.org |
---|---|
State | Deferred |
Delegated to: | Stefan Roese |
Headers | show |
On 02.07.2014 02:17, Luka Perkov wrote: > Each board with defines it's own set of values. If we do not define > CONFIG_MVGBE_PORTS we will hit following error: > > mvgbe.c: In function 'mvgbe_initialize': > mvgbe.c:700:34: error: 'CONFIG_MVGBE_PORTS' undeclared (first use in this function) > u8 used_ports[MAX_MVGBE_DEVS] = CONFIG_MVGBE_PORTS; > > This patch fixes above described problem. > > Signed-off-by: Luka Perkov <luka@openwrt.org> > CC: Prafulla Wadaskar <prafulla@marvell.com> > CC: Stefan Roese <sr@denx.de> Acked-by: Stefan Roese <sr@denx.de> Thanks, Stefan
> -----Original Message----- > From: Luka Perkov [mailto:luka@openwrt.org] > Sent: 02 July 2014 05:48 > To: u-boot@lists.denx.de > Cc: luka@openwrt.org; Prafulla Wadaskar; Stefan Roese > Subject: [PATCH] kirkwood: define empty > CONFIG_MVGBE_PORTS by default > > Each board with defines it's own set of values. If we > do not define > CONFIG_MVGBE_PORTS we will hit following error: > > mvgbe.c: In function 'mvgbe_initialize': > mvgbe.c:700:34: error: 'CONFIG_MVGBE_PORTS' undeclared > (first use in this function) > u8 used_ports[MAX_MVGBE_DEVS] = CONFIG_MVGBE_PORTS; > > This patch fixes above described problem. > > Signed-off-by: Luka Perkov <luka@openwrt.org> > CC: Prafulla Wadaskar <prafulla@marvell.com> > CC: Stefan Roese <sr@denx.de> > --- > drivers/net/mvgbe.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c > index 0cd06b6..d558f59 100644 > --- a/drivers/net/mvgbe.c > +++ b/drivers/net/mvgbe.c > @@ -35,6 +35,10 @@ > > DECLARE_GLOBAL_DATA_PTR; > > +#ifndef CONFIG_MVGBE_PORTS > +# define CONFIG_MVGBE_PORTS {0, 0} > +#endif > + > #define MV_PHY_ADR_REQUEST 0xee > #define MVGBE_SMI_REG (((struct mvgbe_registers > *)MVGBE0_BASE)->smi) > This is generic to network driver, to be picked up by net custodian.. +Joe Acked-by: Prafulla Wadaskar <prafulla@marvell.com> Regards... Prafulla . . .
On Fri, Jul 04, 2014 at 06:07:09AM -0700, Prafulla Wadaskar wrote: > > > > -----Original Message----- > > From: Luka Perkov [mailto:luka@openwrt.org] > > Sent: 02 July 2014 05:48 > > To: u-boot@lists.denx.de > > Cc: luka@openwrt.org; Prafulla Wadaskar; Stefan Roese > > Subject: [PATCH] kirkwood: define empty > > CONFIG_MVGBE_PORTS by default > > > > Each board with defines it's own set of values. If we > > do not define > > CONFIG_MVGBE_PORTS we will hit following error: > > > > mvgbe.c: In function 'mvgbe_initialize': > > mvgbe.c:700:34: error: 'CONFIG_MVGBE_PORTS' undeclared > > (first use in this function) > > u8 used_ports[MAX_MVGBE_DEVS] = CONFIG_MVGBE_PORTS; > > > > This patch fixes above described problem. > > > > Signed-off-by: Luka Perkov <luka@openwrt.org> > > CC: Prafulla Wadaskar <prafulla@marvell.com> > > CC: Stefan Roese <sr@denx.de> > > --- > > drivers/net/mvgbe.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c > > index 0cd06b6..d558f59 100644 > > --- a/drivers/net/mvgbe.c > > +++ b/drivers/net/mvgbe.c > > @@ -35,6 +35,10 @@ > > > > DECLARE_GLOBAL_DATA_PTR; > > > > +#ifndef CONFIG_MVGBE_PORTS > > +# define CONFIG_MVGBE_PORTS {0, 0} > > +#endif > > + > > #define MV_PHY_ADR_REQUEST 0xee > > #define MVGBE_SMI_REG (((struct mvgbe_registers > > *)MVGBE0_BASE)->smi) > > > > This is generic to network driver, to be picked up by net custodian.. > > +Joe > > Acked-by: Prafulla Wadaskar <prafulla@marvell.com> > It's in the marvell driver so please just pick it up, thanks.
diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index 0cd06b6..d558f59 100644 --- a/drivers/net/mvgbe.c +++ b/drivers/net/mvgbe.c @@ -35,6 +35,10 @@ DECLARE_GLOBAL_DATA_PTR; +#ifndef CONFIG_MVGBE_PORTS +# define CONFIG_MVGBE_PORTS {0, 0} +#endif + #define MV_PHY_ADR_REQUEST 0xee #define MVGBE_SMI_REG (((struct mvgbe_registers *)MVGBE0_BASE)->smi)
Each board with defines it's own set of values. If we do not define CONFIG_MVGBE_PORTS we will hit following error: mvgbe.c: In function 'mvgbe_initialize': mvgbe.c:700:34: error: 'CONFIG_MVGBE_PORTS' undeclared (first use in this function) u8 used_ports[MAX_MVGBE_DEVS] = CONFIG_MVGBE_PORTS; This patch fixes above described problem. Signed-off-by: Luka Perkov <luka@openwrt.org> CC: Prafulla Wadaskar <prafulla@marvell.com> CC: Stefan Roese <sr@denx.de> --- drivers/net/mvgbe.c | 4 ++++ 1 file changed, 4 insertions(+)