Message ID | 1400901095-29391-5-git-send-email-sjg@chromium.org |
---|---|
State | Superseded |
Delegated to: | Tom Rini |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id E3784140082 for <incoming@patchwork.ozlabs.org>; Sat, 24 May 2014 13:12:33 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8622F4B670; Sat, 24 May 2014 05:12:28 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tsFNePy87MDf; Sat, 24 May 2014 05:12:28 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7BAB24B662; Sat, 24 May 2014 05:12:14 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7E4C84B66A for <u-boot@lists.denx.de>; Sat, 24 May 2014 05:12:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hUHLEFzkvEoi for <u-boot@lists.denx.de>; Sat, 24 May 2014 05:12:05 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-qg0-f73.google.com (mail-qg0-f73.google.com [209.85.192.73]) by theia.denx.de (Postfix) with ESMTPS id 791054B664 for <u-boot@lists.denx.de>; Sat, 24 May 2014 05:11:59 +0200 (CEST) Received: by mail-qg0-f73.google.com with SMTP id q108so332071qgd.4 for <u-boot@lists.denx.de>; Fri, 23 May 2014 20:11:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GOZaPYmrt21lrYF724TZ4DPF1vPywjcucoc6hb2PdiM=; b=GFCM1uG0ZrqHd8bZVnH3j4I9DoZl3IeC0Iscs6oySaJtbtDwoDnkqyaQ+JWvVg1iek +JqTOSUas4TPMAhZhRX/aEFY/rpLjotm59U/6BLHlCe7KYse6GMzoSmm5IEwIq3OhKI6 /SJpJqt55AnwIuJA7wODSM+RwuNd71HhJU4BnXjNIDTrHMvjp3W2pRLT4hjkVzwtXEsE P3UxVGeTO3XIHaZzA3YR6oellFxKplYKVjl0CU5sxbGJbO1uk+K1+ZiOa+Es3eWIE0Tn eHJv2nSlACC9nXCbqUwCXIlXo/IkBMqRzGnf+3tbuEGmEgZLseoa+N7/QPPpnUKi7cfB 8Bog== X-Gm-Message-State: ALoCoQkY8+SyrSTtDxG0mlSduvhA7lyegnNGh1qxPx+ksuurf+tJE1R9ap/m4bvjm98ZENOuHo+m X-Received: by 10.58.106.75 with SMTP id gs11mr3997109veb.18.1400901117716; Fri, 23 May 2014 20:11:57 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id c22si138243yhe.1.2014.05.23.20.11.57 for <multiple recipients> (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 23 May 2014 20:11:57 -0700 (PDT) Received: from kaki.bld.corp.google.com (kaki.bld.corp.google.com [172.29.216.32]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 945D931CD82; Fri, 23 May 2014 20:11:57 -0700 (PDT) Received: by kaki.bld.corp.google.com (Postfix, from userid 121222) id 3E34F221148; Fri, 23 May 2014 21:11:57 -0600 (MDT) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Date: Fri, 23 May 2014 21:11:35 -0600 Message-Id: <1400901095-29391-5-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 1.9.1.423.g4596e3a In-Reply-To: <1400901095-29391-1-git-send-email-sjg@chromium.org> References: <1400901095-29391-1-git-send-email-sjg@chromium.org> Cc: Tom Rini <trini@ti.com> Subject: [U-Boot] [PATCH 4/4] Correct return code from builtin_run_command_list() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <http://lists.denx.de/mailman/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <http://lists.denx.de/pipermail/u-boot> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <http://lists.denx.de/mailman/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de |
diff --git a/common/main.c b/common/main.c index 9bee7bd..e2350bd 100644 --- a/common/main.c +++ b/common/main.c @@ -1485,7 +1485,7 @@ static int builtin_run_command_list(char *cmd, int flag) ++next; } if (rcode == 0 && *line) - rcode = (builtin_run_command(line, 0) >= 0); + rcode = (builtin_run_command(line, 0) < 0); return rcode; }
The return code is not consistent with builtin_run_command_list(). For the last command in a sequence, the return code is actually inverted. Fix it. Signed-off-by: Simon Glass <sjg@chromium.org> --- common/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)