diff mbox

[U-Boot,v2] tools: correct proftool build rule

Message ID 1391212484-24694-1-git-send-email-ijc@hellion.org.uk
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Ian Campbell Jan. 31, 2014, 11:54 p.m. UTC
The incorrect substitution made it rebuild every time.

Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Cc: Tom Rini <trini@ti.com>
Cc: Simon Glass <sjg@chromium.org>
---
 tools/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Glass Feb. 1, 2014, 12:10 a.m. UTC | #1
On 31 January 2014 16:54, Ian Campbell <ijc@hellion.org.uk> wrote:
> The incorrect substitution made it rebuild every time.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Tom Rini <trini@ti.com>
> Cc: Simon Glass <sjg@chromium.org>

Thanks Ian.

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  tools/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 328cea3..052e4d4 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -60,7 +60,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
>  BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
>  BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX)
>  BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX)
> -BIN_FILES-y += proftool(SFX)
> +BIN_FILES-y += proftool$(SFX)
>  BIN_FILES-$(CONFIG_STATIC_RELA) += relocate-rela$(SFX)
>
>  # Source files which exist outside the tools directory
> @@ -186,7 +186,7 @@ $(obj)bmp_logo$(SFX):       $(obj)bmp_logo.o
>         $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
>         $(HOSTSTRIP) $@
>
> -$(obj)proftool(SFX):   $(obj)proftool.o
> +$(obj)proftool$(SFX):  $(obj)proftool.o
>         $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
>         $(HOSTSTRIP) $@
>
> --
> 1.8.5.3
>
Tom Rini Feb. 19, 2014, 3:49 p.m. UTC | #2
On Fri, Jan 31, 2014 at 11:54:44PM +0000, Ian Campbell wrote:

> The incorrect substitution made it rebuild every time.
> 
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Tom Rini <trini@ti.com>
> Cc: Simon Glass <sjg@chromium.org>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/tools/Makefile b/tools/Makefile
index 328cea3..052e4d4 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -60,7 +60,7 @@  BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
 BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
 BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX)
 BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX)
-BIN_FILES-y += proftool(SFX)
+BIN_FILES-y += proftool$(SFX)
 BIN_FILES-$(CONFIG_STATIC_RELA) += relocate-rela$(SFX)
 
 # Source files which exist outside the tools directory
@@ -186,7 +186,7 @@  $(obj)bmp_logo$(SFX):	$(obj)bmp_logo.o
 	$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
 	$(HOSTSTRIP) $@
 
-$(obj)proftool(SFX):	$(obj)proftool.o
+$(obj)proftool$(SFX):	$(obj)proftool.o
 	$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
 	$(HOSTSTRIP) $@