diff mbox

[U-Boot,v2,4/8] cmd_mmc.c: Change 'bootpart' code to match normal coding style

Message ID 1391117520-21868-4-git-send-email-trini@ti.com
State Superseded
Delegated to: Pantelis Antoniou
Headers show

Commit Message

Tom Rini Jan. 30, 2014, 9:31 p.m. UTC 
Signed-off-by: Tom Rini <trini@ti.com>
---
 common/cmd_mmc.c |   15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

Comments

Jaehoon Chung Feb. 4, 2014, 12:54 a.m. UTC | #1 
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

On 01/31/2014 06:31 AM, Tom Rini wrote:
> Signed-off-by: Tom Rini <trini@ti.com>
> ---
>  common/cmd_mmc.c |   15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c
> index da5fef9..e118252 100644
> --- a/common/cmd_mmc.c
> +++ b/common/cmd_mmc.c
> @@ -314,11 +314,18 @@ static int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  
>  	} else if (strcmp(argv[1], "bootpart") == 0) {
>  		int dev;
> -		dev = simple_strtoul(argv[2], NULL, 10);
> +		struct *mmc;
> +		u32 bootsize, rpmbsize;
>  
> -		u32 bootsize = simple_strtoul(argv[3], NULL, 10);
> -		u32 rpmbsize = simple_strtoul(argv[4], NULL, 10);
> -		struct mmc *mmc = find_mmc_device(dev);
> +		if (argc == 5) {
> +			dev = simple_strtoul(argv[2], NULL, 10);
> +			bootsize = simple_strtoul(argv[3], NULL, 10);
> +			rpmbsize = simple_strtoul(argv[4], NULL, 10);
> +		} else {
> +			return CMD_RET_USAGE;
> +		}
> +
> +		mmc = find_mmc_device(dev);
>  		if (!mmc) {
>  			printf("no mmc device at slot %x\n", dev);
>  			return 1;
>
diff mbox

Patch

diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c
index da5fef9..e118252 100644
--- a/common/cmd_mmc.c
+++ b/common/cmd_mmc.c
@@ -314,11 +314,18 @@  static int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 	} else if (strcmp(argv[1], "bootpart") == 0) {
 		int dev;
-		dev = simple_strtoul(argv[2], NULL, 10);
+		struct *mmc;
+		u32 bootsize, rpmbsize;
 
-		u32 bootsize = simple_strtoul(argv[3], NULL, 10);
-		u32 rpmbsize = simple_strtoul(argv[4], NULL, 10);
-		struct mmc *mmc = find_mmc_device(dev);
+		if (argc == 5) {
+			dev = simple_strtoul(argv[2], NULL, 10);
+			bootsize = simple_strtoul(argv[3], NULL, 10);
+			rpmbsize = simple_strtoul(argv[4], NULL, 10);
+		} else {
+			return CMD_RET_USAGE;
+		}
+
+		mmc = find_mmc_device(dev);
 		if (!mmc) {
 			printf("no mmc device at slot %x\n", dev);
 			return 1;