diff mbox

[U-Boot,V3,07/12] cmd_test: evaluate to false without any arguments

Message ID 1390855802-17504-7-git-send-email-swarren@wwwdotorg.org
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Stephen Warren Jan. 27, 2014, 8:49 p.m. UTC 
From: Stephen Warren <swarren@nvidia.com>

This emulates bash:
$ if test; then echo yes; else echo no; fi
no

Currently, the code sets expr = -1 in this case, which gets mapped to
0 (true) at the end of do_test() by the logical -> shell exit code
conversion.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
v3: New patch.
---
 common/cmd_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/common/cmd_test.c b/common/cmd_test.c
index b927d09eb3e0..4c2f967c6dc0 100644
--- a/common/cmd_test.c
+++ b/common/cmd_test.c
@@ -77,7 +77,7 @@  static int do_test(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 	left = argc - 1;
 	ap = argv + 1;
-	expr = -1;
+	expr = 0;
 	last_unop = OP_INVALID;
 	last_binop = OP_INVALID;
 	last_expr = -1;