| Message ID | 1390832143-372-4-git-send-email-p.wilczek@samsung.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
On 27/01/14 23:15, Piotr Wilczek wrote: > This patch adds additional data parsing from DTB. > > Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Minkyu Kang <mk7.kang@samsung.com> > --- > drivers/video/exynos_fb.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c > index d4863e8..7e0099f 100644 > --- a/drivers/video/exynos_fb.c > +++ b/drivers/video/exynos_fb.c > @@ -20,6 +20,7 @@ > #include <asm/arch/dp_info.h> > #include <asm/arch/system.h> > #include <asm-generic/errno.h> > +#include <libtizen.h> > > #include "exynos_fb.h" > > @@ -269,6 +270,21 @@ int exynos_fimd_parse_dt(const void *blob) > panel_info.dual_lcd_enabled = fdtdec_get_int(blob, node, > "samsung,dual-lcd-enabled", 0); > > + panel_info.logo_on = fdtdec_get_int(blob, node, > + "samsung,logo-on", 0); duplicated. > + > + panel_info.resolution = fdtdec_get_int(blob, node, > + "samsung,resolution", 0); > + > + panel_info.rgb_mode = fdtdec_get_int(blob, node, > + "samsung,rgb-mode", 0); > + > + panel_info.power_on_delay = fdtdec_get_int(blob, node, > + "samsung,power-on-delay", 0); > + > +#ifdef CONFIG_TIZEN > + get_tizen_logo_info(&panel_info); It looks strange. Why you load the logo at frame buffer driver? > +#endif > return 0; > } > #endif > @@ -281,6 +297,9 @@ void lcd_ctrl_init(void *lcdbase) > #ifdef CONFIG_OF_CONTROL > if (exynos_fimd_parse_dt(gd->fdt_blob)) > debug("Can't get proper panel info\n"); > +#ifdef CONFIG_EXYNOS_MIPI_DSIM > + exynos_init_dsim_platform_data(&panel_info); > +#endif > #else > /* initialize parameters which is specific to panel. */ > init_panel_info(&panel_info); > Thanks, Minkyu Kang.
Dear Minkyu Kang, > On 27/01/14 23:15, Piotr Wilczek wrote: > > This patch adds additional data parsing from DTB. > > > > Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > Cc: Minkyu Kang <mk7.kang@samsung.com> > > --- > > drivers/video/exynos_fb.c | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c > > index d4863e8..7e0099f 100644 > > --- a/drivers/video/exynos_fb.c > > +++ b/drivers/video/exynos_fb.c > > @@ -20,6 +20,7 @@ > > #include <asm/arch/dp_info.h> > > #include <asm/arch/system.h> > > #include <asm-generic/errno.h> > > +#include <libtizen.h> > > > > #include "exynos_fb.h" > > > > @@ -269,6 +270,21 @@ int exynos_fimd_parse_dt(const void *blob) > > panel_info.dual_lcd_enabled = fdtdec_get_int(blob, node, > > "samsung,dual-lcd-enabled", 0); > > > > + panel_info.logo_on = fdtdec_get_int(blob, node, > > + "samsung,logo-on", 0); > > duplicated. Ok, will remove it. > > > + > > + panel_info.resolution = fdtdec_get_int(blob, node, > > + "samsung,resolution", 0); > > + > > + panel_info.rgb_mode = fdtdec_get_int(blob, node, > > + "samsung,rgb-mode", 0); > > + > > + panel_info.power_on_delay = fdtdec_get_int(blob, node, > > + "samsung,power-on-delay", 0); > > + > > +#ifdef CONFIG_TIZEN > > + get_tizen_logo_info(&panel_info); > > It looks strange. > Why you load the logo at frame buffer driver? Ok, I will move it. > > > +#endif > > return 0; > > } > > #endif > > @@ -281,6 +297,9 @@ void lcd_ctrl_init(void *lcdbase) #ifdef > > CONFIG_OF_CONTROL > > if (exynos_fimd_parse_dt(gd->fdt_blob)) > > debug("Can't get proper panel info\n"); > > +#ifdef CONFIG_EXYNOS_MIPI_DSIM > > + exynos_init_dsim_platform_data(&panel_info); > > +#endif > > #else > > /* initialize parameters which is specific to panel. */ > > init_panel_info(&panel_info); > > > > Thanks, > Minkyu Kang. Thanks for review. Piotr Wilczek
diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c index d4863e8..7e0099f 100644 --- a/drivers/video/exynos_fb.c +++ b/drivers/video/exynos_fb.c @@ -20,6 +20,7 @@ #include <asm/arch/dp_info.h> #include <asm/arch/system.h> #include <asm-generic/errno.h> +#include <libtizen.h> #include "exynos_fb.h" @@ -269,6 +270,21 @@ int exynos_fimd_parse_dt(const void *blob) panel_info.dual_lcd_enabled = fdtdec_get_int(blob, node, "samsung,dual-lcd-enabled", 0); + panel_info.logo_on = fdtdec_get_int(blob, node, + "samsung,logo-on", 0); + + panel_info.resolution = fdtdec_get_int(blob, node, + "samsung,resolution", 0); + + panel_info.rgb_mode = fdtdec_get_int(blob, node, + "samsung,rgb-mode", 0); + + panel_info.power_on_delay = fdtdec_get_int(blob, node, + "samsung,power-on-delay", 0); + +#ifdef CONFIG_TIZEN + get_tizen_logo_info(&panel_info); +#endif return 0; } #endif @@ -281,6 +297,9 @@ void lcd_ctrl_init(void *lcdbase) #ifdef CONFIG_OF_CONTROL if (exynos_fimd_parse_dt(gd->fdt_blob)) debug("Can't get proper panel info\n"); +#ifdef CONFIG_EXYNOS_MIPI_DSIM + exynos_init_dsim_platform_data(&panel_info); +#endif #else /* initialize parameters which is specific to panel. */ init_panel_info(&panel_info);