From patchwork Sat Jan 25 16:08:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 314148 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 53A8E2C0098 for ; Sun, 26 Jan 2014 03:09:08 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9FB8B4AF41; Sat, 25 Jan 2014 17:09:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bNGdri8x8vpW; Sat, 25 Jan 2014 17:09:06 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 556724AEBD; Sat, 25 Jan 2014 17:09:00 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 766554AEBD for ; Sat, 25 Jan 2014 17:08:54 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GJiJbRi2y2Fu for ; Sat, 25 Jan 2014 17:08:48 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 BL_NJABL=SKIP(-1.5) (only DNSBL check requested) Received: from mail-gg0-f176.google.com (mail-gg0-f176.google.com [209.85.161.176]) by theia.denx.de (Postfix) with ESMTPS id 2C30C4AC97 for ; Sat, 25 Jan 2014 17:08:46 +0100 (CET) Received: by mail-gg0-f176.google.com with SMTP id b1so1610616ggn.35 for ; Sat, 25 Jan 2014 08:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=8APMF/uE8NR+wJ9OxNQx22qm1+/1h+Ihmvh3vXcm2C4=; b=1F6NyeqYW4hIb7c/tn05RrfeFBDdKMDC4RdCFZ2Ogusoew22fKWtBJO2ugsrrLmxT2 L4spUS4wySRNqy6unBzKoBFt9d54oRC7TDdgzN1hrqnxedVmdqbER1apAG+J8aMV83/U xQuJajBR4Gk/O7R2rE637ViBM5KeP61VtzjKGcb0bSGoPXZq7eVWpRkQZ1hhZrJstBdV G6B53rE2/ColvkIp/O9s9A2tqjfOD+2/N/PbK0Gl+5GgHY89uvb6ahT4DF1InrGijEIw uUav3wMxQgzJfCqqqE1HchqwN/Pf7TaRsUaaQ6J7CZe+EsXmIvWkv3cwG48NBGjaU0Hn eVoQ== X-Received: by 10.236.37.105 with SMTP id x69mr18419856yha.15.1390666125089; Sat, 25 Jan 2014 08:08:45 -0800 (PST) Received: from localhost.localdomain ([189.101.178.124]) by mx.google.com with ESMTPSA id 23sm14591127yhj.5.2014.01.25.08.08.43 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 25 Jan 2014 08:08:44 -0800 (PST) From: Fabio Estevam To: sbabic@denx.de Date: Sat, 25 Jan 2014 14:08:24 -0200 Message-Id: <1390666104-9355-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.1.2 Cc: Fabio Estevam , u-boot@lists.denx.de, jon.nettleton@gmail.com Subject: [U-Boot] [PATCH] hummingboard: Return from cpu_eth_init() directly X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Fabio Estevam There is no need to print an error message when cpu_eth_init() fails because net/eth.c already prints it. In order to simplify the code, just return the value from cpu_eth_init(bis) directly. Signed-off-by: Fabio Estevam --- board/solidrun/hummingboard/hummingboard.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/board/solidrun/hummingboard/hummingboard.c b/board/solidrun/hummingboard/hummingboard.c index 8b309b4..2e2fb2a 100644 --- a/board/solidrun/hummingboard/hummingboard.c +++ b/board/solidrun/hummingboard/hummingboard.c @@ -156,11 +156,7 @@ int board_eth_init(bd_t *bis) setup_iomux_enet(); - ret = cpu_eth_init(bis); - if (ret) - printf("FEC MXC: %s:failed\n", __func__); - - return ret; + return cpu_eth_init(bis); } #endif