diff mbox

[U-Boot] hummingboard: Return from cpu_eth_init() directly

Message ID 1390666104-9355-1-git-send-email-festevam@gmail.com
State Accepted
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam Jan. 25, 2014, 4:08 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.
    
In order to simplify the code, just return the value from cpu_eth_init(bis)
directly.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/solidrun/hummingboard/hummingboard.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Stefano Babic Feb. 11, 2014, 10:25 a.m. UTC | #1 
On 25/01/2014 17:08, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> There is no need to print an error message when cpu_eth_init() fails because
> net/eth.c already prints it.
>     
> In order to simplify the code, just return the value from cpu_eth_init(bis)
> directly.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---


Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/solidrun/hummingboard/hummingboard.c b/board/solidrun/hummingboard/hummingboard.c
index 8b309b4..2e2fb2a 100644
--- a/board/solidrun/hummingboard/hummingboard.c
+++ b/board/solidrun/hummingboard/hummingboard.c
@@ -156,11 +156,7 @@  int board_eth_init(bd_t *bis)
 
 	setup_iomux_enet();
 
-	ret = cpu_eth_init(bis);
-	if (ret)
-		printf("FEC MXC: %s:failed\n", __func__);
-
-	return ret;
+	return cpu_eth_init(bis);
 }
 #endif