| Message ID | 1385564969-2043-1-git-send-email-andreas.devel@googlemail.com |
|---|---|
| State | Accepted |
| Delegated to: | Albert ARIBAUD |
| Headers | show |
Dear Albert Aribaud, On 27.11.13 16:09, Andreas Bießmann wrote: > Building some arm boards with older binutils may produce errors like this: > > ---8<--- > crt0.S: Assembler messages: > crt0.S:70: Error: register expected, not '#(184)' -- `sub sp,#(184)' > --->8--- > > Use canonical version of the subtract mnemonic to avoid those issues. any comment? Best regards Andreas Bießmann
Hi Andreas, On Fri, 13 Dec 2013 08:09:44 +0100, Andreas Bießmann <andreas.devel@googlemail.com> wrote: > Dear Albert Aribaud, > > On 27.11.13 16:09, Andreas Bießmann wrote: > > Building some arm boards with older binutils may produce errors like this: > > > > ---8<--- > > crt0.S: Assembler messages: > > crt0.S:70: Error: register expected, not '#(184)' -- `sub sp,#(184)' > > --->8--- > > > > Use canonical version of the subtract mnemonic to avoid those issues. > > any comment? None; I just haven't arrived to applying it yet. Will happen during the day. > Best regards > > Andreas Bießmann Amicalement,
Hi Andreas, On Wed, 27 Nov 2013 16:09:29 +0100, Andreas Bießmann <andreas.devel@googlemail.com> wrote: > Building some arm boards with older binutils may produce errors like this: > > ---8<--- > crt0.S: Assembler messages: > crt0.S:70: Error: register expected, not '#(184)' -- `sub sp,#(184)' > --->8--- > > Use canonical version of the subtract mnemonic to avoid those issues. > > Reported-by: Alexey Smishlayev <alexey@xtech2.lv> > Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com> > --- > > arch/arm/cpu/armv7/lowlevel_init.S | 2 +- > arch/arm/lib/crt0.S | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/cpu/armv7/lowlevel_init.S b/arch/arm/cpu/armv7/lowlevel_init.S > index 69e3053..f1aea05 100644 > --- a/arch/arm/cpu/armv7/lowlevel_init.S > +++ b/arch/arm/cpu/armv7/lowlevel_init.S > @@ -24,7 +24,7 @@ ENTRY(lowlevel_init) > #ifdef CONFIG_SPL_BUILD > ldr r9, =gdata > #else > - sub sp, #GD_SIZE > + sub sp, sp, #GD_SIZE > bic sp, sp, #7 > mov r9, sp > #endif > diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S > index ac54b93..dfc2de9 100644 > --- a/arch/arm/lib/crt0.S > +++ b/arch/arm/lib/crt0.S > @@ -67,7 +67,7 @@ ENTRY(_main) > ldr sp, =(CONFIG_SYS_INIT_SP_ADDR) > #endif > bic sp, sp, #7 /* 8-byte alignment for ABI compliance */ > - sub sp, #GD_SIZE /* allocate one GD above SP */ > + sub sp, sp, #GD_SIZE /* allocate one GD above SP */ > bic sp, sp, #7 /* 8-byte alignment for ABI compliance */ > mov r9, sp /* GD is above SP */ > mov r0, #0 Applied to u-boot-arm/master, thanks! Amicalement,
diff --git a/arch/arm/cpu/armv7/lowlevel_init.S b/arch/arm/cpu/armv7/lowlevel_init.S index 69e3053..f1aea05 100644 --- a/arch/arm/cpu/armv7/lowlevel_init.S +++ b/arch/arm/cpu/armv7/lowlevel_init.S @@ -24,7 +24,7 @@ ENTRY(lowlevel_init) #ifdef CONFIG_SPL_BUILD ldr r9, =gdata #else - sub sp, #GD_SIZE + sub sp, sp, #GD_SIZE bic sp, sp, #7 mov r9, sp #endif diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S index ac54b93..dfc2de9 100644 --- a/arch/arm/lib/crt0.S +++ b/arch/arm/lib/crt0.S @@ -67,7 +67,7 @@ ENTRY(_main) ldr sp, =(CONFIG_SYS_INIT_SP_ADDR) #endif bic sp, sp, #7 /* 8-byte alignment for ABI compliance */ - sub sp, #GD_SIZE /* allocate one GD above SP */ + sub sp, sp, #GD_SIZE /* allocate one GD above SP */ bic sp, sp, #7 /* 8-byte alignment for ABI compliance */ mov r9, sp /* GD is above SP */ mov r0, #0
Building some arm boards with older binutils may produce errors like this: ---8<--- crt0.S: Assembler messages: crt0.S:70: Error: register expected, not '#(184)' -- `sub sp,#(184)' --->8--- Use canonical version of the subtract mnemonic to avoid those issues. Reported-by: Alexey Smishlayev <alexey@xtech2.lv> Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com> --- arch/arm/cpu/armv7/lowlevel_init.S | 2 +- arch/arm/lib/crt0.S | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)